Skip to content

Commit e2304ed

Browse files
sjarmakclaude
andcommitted
fix: remove answer leakage from ccb_fix instruction.md files
Strip two leakage vectors from 21 ccb_fix task files: 1. Instance ID / Base commit metadata blocks (12 SWE-bench-derived tasks): Removed trailing "Base commit" + "Instance ID" blocks that embed the fix commit hash. Data preserved in task.toml (pre_fix_rev) and tests/config.json. 2. PR/issue numbers and GitHub URLs (5 HIGH-risk tasks): - pytorch-relu-gelu-fusion: removed #168157 (3 occurrences) - pytorch-tracer-graph-cleanup: removed #169388 - pytorch-cudnn-version: removed 2 GitHub URLs - pytorch-release-210: removed #162493 - envoy-udp-proxy-cds: removed exact fix method (insert_or_assign) Also rewrote task steps to say "find and fix" instead of "review the merged PR", and adjusted difficulty ratings on 3 task.toml files. Audited all 25 ccb_fix instructions — no remaining PR numbers, GitHub URLs, or Instance IDs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f624e3b commit e2304ed

File tree

21 files changed

+27
-92
lines changed

21 files changed

+27
-92
lines changed

benchmarks/ccb_fix/ansible-abc-imports-fix-001/instruction.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,3 @@ In various parts of the Ansible codebase (modules, `module_utils`, and controlle
2929
- Sanity checks are aligned with the updated import policy
3030
- All existing tests pass
3131

32-
---
33-
34-
**Base commit:** `e658995760ac1209cb12df97027a2e282b4536ae`
35-
**Instance ID:** `instance_ansible__ansible-379058e10f3dbc0fdcaf80394bd09b18927e7d33-v1055803c3a812189a1133297f7f5468579283f86`

benchmarks/ccb_fix/ansible-module-respawn-fix-001/instruction.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,3 @@ Modules such as `dnf`, `yum`, `apt`, `apt_repository`, and others rely on system
2929
- Basic SELinux operations work without `libselinux-python`
3030
- All existing tests pass
3131

32-
---
33-
34-
**Base commit:** `8a175f59c939ca29ad56f3fa9edbc37a8656879a`
35-
**Instance ID:** `instance_ansible__ansible-4c5ce5a1a9e79a845aff4978cfeb72a0d4ecf7d6-v1055803c3a812189a1133297f7f5468579283f86`

benchmarks/ccb_fix/envoy-udp-proxy-cds-fix-001/instruction.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66

77
## Description
88

9-
Envoy's UDP proxy filter crashes when a pre-existing cluster is updated via CDS (Cluster Discovery Service), for example when `HostSet` changes occur. The crash happens because `onClusterAddOrUpdate()` in `udp_proxy_filter.cc` uses `std::unordered_map::emplace()` to insert cluster info into the `cluster_infos_` map.
9+
Envoy's UDP proxy filter crashes when a pre-existing cluster is updated via CDS (Cluster Discovery Service), for example when `HostSet` changes occur. The crash happens because `onClusterAddOrUpdate()` in `udp_proxy_filter.cc` inserts cluster info into the `cluster_infos_` map in a way that silently fails when a cluster with the same name already exists (i.e., it's being updated rather than added for the first time).
1010

11-
When a cluster with the same name already exists (i.e., it's being updated rather than added for the first time), `emplace()` silently fails — it returns the existing entry unchanged without inserting the new one. This leaves a stale `ClusterInfo` object in the map that references the old `ThreadLocalCluster`. When the old `ThreadLocalCluster` is destroyed as part of the update, the filter still holds a dangling pointer through the stale map entry, leading to a crash on the next packet.
11+
When the insert fails, the existing entry is left unchanged, leaving a stale `ClusterInfo` object in the map that references the old `ThreadLocalCluster`. When the old `ThreadLocalCluster` is destroyed as part of the update, the filter still holds a dangling pointer through the stale map entry, leading to a crash on the next packet.
1212

13-
The fix replaces `emplace()` with `insert_or_assign()` in both the per-packet-load-balancing and sticky-session code paths, so that cluster updates correctly replace the old entry.
13+
The fix must ensure that cluster updates in `onClusterAddOrUpdate()` correctly replace the old entry in the map, in both the per-packet-load-balancing and sticky-session code paths.
1414

1515
## Task
1616

@@ -19,7 +19,7 @@ Changes:
1919
- 52 additions, 4 deletions
2020

2121
Tasks:
22-
1. Fix `onClusterAddOrUpdate()` in `source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc` to use `insert_or_assign()` instead of `emplace()` in both code paths
22+
1. Fix `onClusterAddOrUpdate()` in `source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc` so that cluster updates correctly replace existing map entries in both code paths
2323
2. Add a regression test `ClusterDynamicInfoMapUpdate` in the UDP proxy filter test file
2424
3. Add a changelog entry in `changelogs/current.yaml` under `bug_fixes`
2525

benchmarks/ccb_fix/envoy-udp-proxy-cds-fix-001/task.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ category = "cross_module_bug_fix"
1111
language = "cpp"
1212
pre_fix_rev = "1ae957c1f92b8e0b0322ab702c67612aa618d214"
1313
ground_truth_rev = "8d1ab6332f86b8010f8662fee233aadf79ad5ee0"
14-
difficulty = "medium"
14+
difficulty = "hard"
1515
time_limit_sec = 600
1616

1717
[verification]

benchmarks/ccb_fix/flipt-cockroachdb-backend-fix-001/instruction.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,3 @@ CockroachDB uses the same wire protocol as PostgreSQL, allowing it to work with
3030
- Existing database backends (PostgreSQL, MySQL, SQLite) are unaffected
3131
- All existing tests pass
3232

33-
---
34-
35-
**Base commit:** `2d0ff0c91a63a1165f5ca528faa1f0785b1f730c`
36-
**Instance ID:** `instance_flipt-io__flipt-9f8127f225a86245fa35dca4885c2daef824ee55`

benchmarks/ccb_fix/flipt-ecr-auth-oci-fix-001/instruction.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,3 @@ Flipt configured with OCI storage cannot continuously pull bundles from AWS ECR
3131
- Configuration accepts the new authentication type
3232
- All existing tests pass
3333

34-
---
35-
36-
**Base commit:** `47499077ce785f0eee0e3940ef6c074e29a664fc`
37-
**Instance ID:** `instance_flipt-io__flipt-c188284ff0c094a4ee281afebebd849555ebee59`

benchmarks/ccb_fix/flipt-otlp-exporter-fix-001/instruction.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,3 @@ Flipt currently only supports Jaeger and Zipkin as tracing exporters, limiting o
3737
- Existing Jaeger and Zipkin configurations continue to work
3838
- All existing tests pass
3939

40-
---
41-
42-
**Base commit:** `4e066b8b836ceac716b6f63db41a341fb4df1375`
43-
**Instance ID:** `instance_flipt-io__flipt-b433bd05ce405837804693bebd5f4b88d87133c8`

benchmarks/ccb_fix/flipt-trace-sampling-fix-001/instruction.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,3 @@ The current OpenTelemetry instrumentation in Flipt generates all traces with a f
3131
- Omitted values use sensible defaults
3232
- All existing tests pass
3333

34-
---
35-
36-
**Base commit:** `91cc1b9fc38280a53a36e1e9543d87d7306144b2`
37-
**Instance ID:** `instance_flipt-io__flipt-3d5a345f94c2adc8a0eaa102c189c08ad4c0f8e8`

benchmarks/ccb_fix/navidrome-windows-log-fix-001/instruction.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,3 @@ Navidrome does not format log output correctly for Windows users. Logs use only
3636
- Unix behavior is unchanged
3737
- All existing tests pass
3838

39-
---
40-
41-
**Base commit:** `23bebe4e06124becf1000e88472ae71a6ca7de4c`
42-
**Instance ID:** `instance_navidrome__navidrome-9c3b4561652a15846993d477003e111f0df0c585`

benchmarks/ccb_fix/nodebb-notif-dropdown-fix-001/instruction.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,3 @@ In NodeBB v4.4.3, the notifications dropdown and the category selector in topic
2727
- Category selector menus in fork/move topic modals render with correct placement and stable interaction
2828
- All existing tests pass
2929

30-
---
31-
32-
**Base commit:** `8fd8079a84d8e71ab02eaa69ef15cb33fcea85c7`
33-
**Instance ID:** `instance_NodeBB__NodeBB-eb49a64974ca844bca061744fb3383f5d13b02ad-vnan`

0 commit comments

Comments
 (0)