fix: NRE raised while clicking the issue link in commit detail message

love-linger · love-linger · commit 5a81eab60de8 · 2025-10-10T10:46:44.000+08:00
This is because that `e.Pointer.Capture(null)` will raise the `PointerExited` event

Signed-off-by: leo &lt;longshuang@msn.cn&gt;
diff --git a/src/Views/CommitMessagePresenter.cs b/src/Views/CommitMessagePresenter.cs
@@ -110,16 +110,17 @@ protected override void OnPointerPressed(PointerPressedEventArgs e)
             if (_lastHover != null)
             {
                 var link = _lastHover.Link;
+                var type = _lastHover.Type;
                 e.Pointer.Capture(null);
 
-                if (_lastHover.Type == Models.InlineElementType.CommitSHA)
+                if (type == Models.InlineElementType.CommitSHA)
                 {
                     var parentView = this.FindAncestorOfType<CommitBaseInfo>();
                     if (parentView is { DataContext: ViewModels.CommitDetail detail })
                     {
                         if (point.Properties.IsLeftButtonPressed)
                         {
-                            detail.NavigateTo(_lastHover.Link);
+                            detail.NavigateTo(link);
                         }
                         else if (point.Properties.IsRightButtonPressed)
                         {

Original file line number	Diff line number	Diff line change
`@@ -110,16 +110,17 @@ protected override void OnPointerPressed(PointerPressedEventArgs e)`
`110`	`110`	`if (_lastHover != null)`
`111`	`111`	`{`
`112`	`112`	`var link = _lastHover.Link;`
	`113`	`+ var type = _lastHover.Type;`
`113`	`114`	`e.Pointer.Capture(null);`
`114`	`115`
`115`		`- if (_lastHover.Type == Models.InlineElementType.CommitSHA)`
	`116`	`+ if (type == Models.InlineElementType.CommitSHA)`
`116`	`117`	`{`
`117`	`118`	`var parentView = this.FindAncestorOfType<CommitBaseInfo>();`
`118`	`119`	`if (parentView is { DataContext: ViewModels.CommitDetail detail })`
`119`	`120`	`{`
`120`	`121`	`if (point.Properties.IsLeftButtonPressed)`
`121`	`122`	`{`
`122`		`- detail.NavigateTo(_lastHover.Link);`
	`123`	`+ detail.NavigateTo(link);`
`123`	`124`	`}`
`124`	`125`	`else if (point.Properties.IsRightButtonPressed)`
`125`	`126`	`{`