From daaa4f187c23a1bee8fb70199be09cdbe3df018c Mon Sep 17 00:00:00 2001 From: Jared Norman Date: Thu, 12 Feb 2026 11:14:20 -0800 Subject: [PATCH 1/4] Switch to reusable GitHub Actions workflow Co-authored-by: Chris Todorov Co-authored-by: Adam Mueller --- .../extension/.github/workflows/test.yml | 58 +------------------ 1 file changed, 2 insertions(+), 56 deletions(-) diff --git a/lib/solidus_dev_support/templates/extension/.github/workflows/test.yml b/lib/solidus_dev_support/templates/extension/.github/workflows/test.yml index 4579edbb..47db34ae 100644 --- a/lib/solidus_dev_support/templates/extension/.github/workflows/test.yml +++ b/lib/solidus_dev_support/templates/extension/.github/workflows/test.yml @@ -7,65 +7,11 @@ on: pull_request: schedule: - cron: "0 0 * * 4" # every Thursday - -concurrency: - group: test-${{ github.ref_name }} - cancel-in-progress: ${{ github.ref_name != 'main' }} + workflow_call: permissions: contents: read jobs: rspec: - name: Solidus ${{ matrix.solidus-branch }}, Rails ${{ matrix.rails-version }} and Ruby ${{ matrix.ruby-version }} on ${{ matrix.database }} - runs-on: ubuntu-24.04 - strategy: - fail-fast: true - matrix: - rails-version: - - "7.0" - - "7.1" - - "7.2" - ruby-version: - - "3.1" - - "3.4" - solidus-branch: - - "v4.1" - - "v4.2" - - "v4.3" - - "v4.4" - - "v4.5" - database: - - "postgresql" - - "mysql" - - "sqlite" - exclude: - - rails-version: "7.2" - solidus-branch: "v4.3" - - rails-version: "7.2" - solidus-branch: "v4.2" - - rails-version: "7.2" - solidus-branch: "v4.1" - - rails-version: "7.1" - solidus-branch: "v4.2" - - rails-version: "7.1" - solidus-branch: "v4.1" - - ruby-version: "3.4" - rails-version: "7.0" - env: - CODECOV_COVERAGE_PATH: ./coverage/coverage.xml - steps: - - uses: actions/checkout@v4 - - name: Run extension tests - uses: solidusio/test-solidus-extension@main - with: - database: ${{ matrix.database }} - rails-version: ${{ matrix.rails-version }} - ruby-version: ${{ matrix.ruby-version }} - solidus-branch: ${{ matrix.solidus-branch }} - - name: Upload coverage reports to Codecov - uses: codecov/codecov-action@v5 - continue-on-error: true - with: - token: ${{ secrets.CODECOV_TOKEN }} - files: ${{ env.CODECOV_COVERAGE_PATH }} + uses: solidusio/test-solidus-extension/.github/workflows/test.yml@main From 5b8d9cc22e52f9f71daad9de6ff5ed75da72f2ae Mon Sep 17 00:00:00 2001 From: Adam Mueller Date: Thu, 5 Feb 2026 12:52:14 -0800 Subject: [PATCH 2/4] Fix missing services Co-authored-by: Chris Todorov --- .github/workflows/test.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5c281a5d..897ae89e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -47,6 +47,29 @@ jobs: rails-version: "8.0" - solidus-branch: "v4.4" rails-version: "8.0" + services: + postgres: + image: postgres:16 + env: + POSTGRES_HOST_AUTH_METHOD: trust + options: >- + --health-cmd="pg_isready" + --health-interval=10s + --health-timeout=5s + --health-retries=5 + ports: + - 5432:5432 + mysql: + image: mysql:8 + env: + MYSQL_ALLOW_EMPTY_PASSWORD: "yes" + options: >- + --health-cmd="mysqladmin ping" + --health-interval=10s + --health-timeout=5s + --health-retries=5 + ports: + - 3306:3306 steps: - uses: actions/checkout@v4 - name: Run extension tests From 9b50d973340f2cce5dea30d7f8d4145dd28d7e98 Mon Sep 17 00:00:00 2001 From: Jared Norman Date: Thu, 12 Feb 2026 11:24:51 -0800 Subject: [PATCH 3/4] Exclude incompatible Ruby/Solidus combo Co-authored-by: Chris Todorov Co-authored-by: Adam Mueller --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 897ae89e..3151725d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -39,6 +39,8 @@ jobs: - "mysql" - "sqlite" exclude: + - solidus-branch: "main" + ruby-version: "3.1" - rails-version: "7.2" solidus-branch: "v4.3" - ruby-version: "3.1" From 4a1f8daa07eca508b1dd7c0416058062fd0da31e Mon Sep 17 00:00:00 2001 From: Jared Norman Date: Thu, 12 Feb 2026 11:31:51 -0800 Subject: [PATCH 4/4] Appease Rubocop --- lib/solidus_dev_support/extension.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/solidus_dev_support/extension.rb b/lib/solidus_dev_support/extension.rb index 36f0accf..7d84e53f 100644 --- a/lib/solidus_dev_support/extension.rb +++ b/lib/solidus_dev_support/extension.rb @@ -8,6 +8,7 @@ module SolidusDevSupport class Extension < Thor include Thor::Actions + PREFIX = "solidus_" default_command :generate