fix: clear mistakes that fall out of new text range#97
Open
andrew-bekhiet-solid wants to merge 5 commits into
Open
fix: clear mistakes that fall out of new text range#97andrew-bekhiet-solid wants to merge 5 commits into
andrew-bekhiet-solid wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a _isDisposed flag to prevent operations on a disposed LanguageToolController and refactors _filterMistakesOnChanged to return a list while filtering out-of-bounds mistakes. The review feedback points out a potential bug where an invalid text selection causes incorrect mistake offset adjustments, and suggests removing a redundant .toList() call on the refactored method's result.
solid-danylosafonov
approved these changes
Jun 8, 2026
solid-danylosafonov
left a comment
solid-danylosafonov
left a comment
Collaborator
There was a problem hiding this comment.
See comment in gemini thread
andrew-bekhiet-solid
force-pushed
the
fix-filtering-mistakes-on-shorter-text
branch
from
cd44b1e to
ba39d5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: prevent notifying listeners after dispose
Fixes a bug where changing text programmatically throws a RangeError
For example changing text from "This text has a mistke" to "abc" throws RangeError because the offset of "mistke" is out of range on "abc"