Skip to content

Commit 4da2144

Browse files
committed
Revert "Ease pagination usage"
This reverts commit 24ceeea.
1 parent 2e74ac4 commit 4da2144

File tree

4 files changed

+28
-186
lines changed

4 files changed

+28
-186
lines changed

examples/Pagination.cs

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,29 @@
33
var client = new ClientOAuth("token");
44
var features = new Features(client);
55

6-
var list = features.Sendernames()
7-
.List()
8-
.ToIterator();
6+
var listSendernames = (uint collectionLimit, uint collectionOffset) =>
7+
{
8+
var list = features.Sendernames().List();
9+
10+
list.Limit = collectionLimit;
11+
list.Offset = collectionOffset;
12+
13+
return list.Execute();
14+
};
915

10-
foreach (var sendername in list)
16+
const uint limit = 25;
17+
uint offset = 0;
18+
bool hasMoreItems;
19+
20+
do
1121
{
12-
Console.WriteLine(sendername.Sender);
13-
}
22+
var sendernames = listSendernames(limit, offset);
23+
24+
sendernames.Collection.ForEach(sendername =>
25+
{
26+
Console.WriteLine($"Sender: {sendername.Sender}");
27+
});
28+
29+
hasMoreItems = sendernames.Size > limit + offset;
30+
offset += limit;
31+
} while (hasMoreItems);

smsapi/Api/Action/CollectionIterator.cs

Lines changed: 0 additions & 96 deletions
This file was deleted.

smsapi/Api/Response/Deserialization/LegacyJsonResponseDeserializer.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ public DeserializationResult<T> Deserialize<T>(HttpResponseEntity responseEntity
3030
{
3131
throw new HostException(e.Message, HostException.E_JSON_DECODE);
3232
}
33+
finally
34+
{
35+
data?.Close();
36+
}
3337

3438
return response;
3539
}

smsapiTests/Unit/Action/CollectionIteratorTest.cs

Lines changed: 0 additions & 84 deletions
This file was deleted.

0 commit comments

Comments
 (0)