Skip to content

feat: add datastore chain metadata changeset#75

Merged
giogam merged 2 commits into
mainfrom
CLD-2446/implement-delete-chain-metadata-changeset
Jun 2, 2026
Merged

feat: add datastore chain metadata changeset#75
giogam merged 2 commits into
mainfrom
CLD-2446/implement-delete-chain-metadata-changeset

Conversation

@giogam

@giogam giogam commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces a new changeset and supporting operation for deleting chain metadata entries in the Catalog service or from local datastore files

CLD-2303

@giogam giogam requested a review from a team as a code owner June 1, 2026 16:07
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

👋 giogam, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@graham-chainlink graham-chainlink left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side question, do you think we could have jsut provide a single sequence or similar where it accepts all 4 metadata and if provided, it will delete? So users dont have to call 4 operations if they want to delete 4 types of metadata?

@giogam

giogam commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Side question, do you think we could have jsut provide a single sequence or similar where it accepts all 4 metadata and if provided, it will delete? So users dont have to call 4 operations if they want to delete 4 types of metadata?

Interesting idea. We can definitely add something like that, and perhaps another endpoint for upsert/add operations. There’s a refactor I’d like to prioritize first, but I’ll create a couple of tickets for this afterward.

@giogam giogam enabled auto-merge (squash) June 2, 2026 07:26
@giogam giogam merged commit 7d0c300 into main Jun 2, 2026
15 checks passed
@giogam giogam deleted the CLD-2446/implement-delete-chain-metadata-changeset branch June 2, 2026 07:30
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
61.3% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

giogam pushed a commit that referenced this pull request Jun 2, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.0...v0.6.0)
(2026-06-02)


### Features

* add datastore chain metadata changeset
([#75](#75))
([7d0c300](7d0c300))
* add datastore contract metadata changeset
([#74](#74))
([4b75d9b](4b75d9b))
* add datastore delete address ref changeset
([#72](#72))
([11308c8](11308c8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants