Skip to content

Commit 7babbec

Browse files
committed
Addressed PR comments
1 parent 5cb6c4e commit 7babbec

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

simvue/api/objects/grids.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,11 @@ def on_reconnect(self, id_mapping: dict[str, str]) -> None:
7979
id_mapping : dict[str, str]
8080
mapping from offline identifier to new online identifier.
8181
"""
82-
_online_runs = [
82+
_online_runs = (
8383
(id_mapping[run_id], metric_name)
8484
for run_id, metric_name in self._staging.pop("runs", [])
85-
]
86-
super().commit() # TODO this means the sender iwll commit twice - that ok?
85+
)
86+
super().commit()
8787
for run_id, metric_name in _online_runs:
8888
try:
8989
self.attach_metric_for_run(run_id=run_id, metric_name=metric_name)

0 commit comments

Comments
 (0)