Skip to content

Commit e25770b

Browse files
waleedlatif1claude
andcommitted
fix(tables): remove dead props from DataRow and PositionGapRows
onRowMouseDown, onRowMouseEnter, and onClearSelection were no longer used after the checkbox td was unified to use onRowToggle exclusively. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent f326b05 commit e25770b

File tree

1 file changed

+1
-21
lines changed
  • apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table

1 file changed

+1
-21
lines changed

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1582,8 +1582,6 @@ export function Table({
15821582
firstRowUnderHeader={prevPosition === -1}
15831583
onCellMouseDown={handleCellMouseDown}
15841584
onCellMouseEnter={handleCellMouseEnter}
1585-
onRowMouseDown={handleRowMouseDown}
1586-
onRowMouseEnter={handleRowMouseEnter}
15871585
onRowToggle={handleRowToggle}
15881586
/>
15891587
)}
@@ -1609,11 +1607,8 @@ export function Table({
16091607
onContextMenu={handleRowContextMenu}
16101608
onCellMouseDown={handleCellMouseDown}
16111609
onCellMouseEnter={handleCellMouseEnter}
1612-
onRowMouseDown={handleRowMouseDown}
1613-
onRowMouseEnter={handleRowMouseEnter}
16141610
isRowChecked={checkedRows.has(row.position)}
16151611
onRowToggle={handleRowToggle}
1616-
onClearSelection={handleClearSelection}
16171612
/>
16181613
</React.Fragment>
16191614
)
@@ -1749,8 +1744,6 @@ interface PositionGapRowsProps {
17491744
firstRowUnderHeader?: boolean
17501745
onCellMouseDown: (rowIndex: number, colIndex: number, shiftKey: boolean) => void
17511746
onCellMouseEnter: (rowIndex: number, colIndex: number) => void
1752-
onRowMouseDown: (rowIndex: number, shiftKey: boolean) => void
1753-
onRowMouseEnter: (rowIndex: number) => void
17541747
onRowToggle: (rowIndex: number, shiftKey: boolean) => void
17551748
}
17561749

@@ -1764,8 +1757,6 @@ const PositionGapRows = React.memo(
17641757
firstRowUnderHeader = false,
17651758
onCellMouseDown,
17661759
onCellMouseEnter,
1767-
onRowMouseDown,
1768-
onRowMouseEnter,
17691760
onRowToggle,
17701761
}: PositionGapRowsProps) {
17711762
const capped = Math.min(count, GAP_ROW_LIMIT)
@@ -1875,8 +1866,6 @@ const PositionGapRows = React.memo(
18751866
prev.firstRowUnderHeader !== next.firstRowUnderHeader ||
18761867
prev.onCellMouseDown !== next.onCellMouseDown ||
18771868
prev.onCellMouseEnter !== next.onCellMouseEnter ||
1878-
prev.onRowMouseDown !== next.onRowMouseDown ||
1879-
prev.onRowMouseEnter !== next.onRowMouseEnter ||
18801869
prev.onRowToggle !== next.onRowToggle
18811870
) {
18821871
return false
@@ -1923,11 +1912,8 @@ interface DataRowProps {
19231912
onContextMenu: (e: React.MouseEvent, row: TableRowType) => void
19241913
onCellMouseDown: (rowIndex: number, colIndex: number, shiftKey: boolean) => void
19251914
onCellMouseEnter: (rowIndex: number, colIndex: number) => void
1926-
onRowMouseDown: (rowIndex: number, shiftKey: boolean) => void
1927-
onRowMouseEnter: (rowIndex: number) => void
19281915
isRowChecked: boolean
19291916
onRowToggle: (rowIndex: number, shiftKey: boolean) => void
1930-
onClearSelection: () => void
19311917
}
19321918

19331919
function rowSelectionChanged(
@@ -1976,11 +1962,8 @@ function dataRowPropsAreEqual(prev: DataRowProps, next: DataRowProps): boolean {
19761962
prev.onContextMenu !== next.onContextMenu ||
19771963
prev.onCellMouseDown !== next.onCellMouseDown ||
19781964
prev.onCellMouseEnter !== next.onCellMouseEnter ||
1979-
prev.onRowMouseDown !== next.onRowMouseDown ||
1980-
prev.onRowMouseEnter !== next.onRowMouseEnter ||
19811965
prev.isRowChecked !== next.isRowChecked ||
1982-
prev.onRowToggle !== next.onRowToggle ||
1983-
prev.onClearSelection !== next.onClearSelection
1966+
prev.onRowToggle !== next.onRowToggle
19841967
) {
19851968
return false
19861969
}
@@ -2016,10 +1999,7 @@ const DataRow = React.memo(function DataRow({
20161999
onContextMenu,
20172000
onCellMouseDown,
20182001
onCellMouseEnter,
2019-
onRowMouseDown,
2020-
onRowMouseEnter,
20212002
onRowToggle,
2022-
onClearSelection,
20232003
}: DataRowProps) {
20242004
const sel = normalizedSelection
20252005
const isMultiCell = sel !== null && (sel.startRow !== sel.endRow || sel.startCol !== sel.endCol)

0 commit comments

Comments
 (0)