address bugbot comment

Author: icecrasher321

apps/sim/app/workspace/[workspaceId]/providers/workspace-permissions-provider.tsx

@@ -75,6 +75,13 @@ export function WorkspacePermissionsProvider({ children }: WorkspacePermissionsP
       removeNotification(reconnectingNotificationIdRef.current)
       reconnectingNotificationIdRef.current = null
     }
+
+    return () => {
+      if (reconnectingNotificationIdRef.current) {
+        removeNotification(reconnectingNotificationIdRef.current)
+        reconnectingNotificationIdRef.current = null
+      }
+    }
   }, [isReconnecting, isOfflineMode, addNotification, removeNotification])
 
   useEffect(() => {

apps/sim/app/workspace/providers/socket-provider.tsx

@@ -67,9 +67,16 @@ interface SocketContextType {
     blockId: string,
     subblockId: string,
     value: any,
-    operationId?: string
+    operationId: string | undefined,
+    workflowId: string
+  ) => void
+  emitVariableUpdate: (
+    variableId: string,
+    field: string,
+    value: any,
+    operationId: string | undefined,
+    workflowId: string
   ) => void
-  emitVariableUpdate: (variableId: string, field: string, value: any, operationId?: string) => void
 
   emitCursorUpdate: (cursor: { x: number; y: number } | null) => void
   emitSelectionUpdate: (selection: { type: 'block' | 'edge' | 'none'; id?: string }) => void
@@ -685,13 +692,9 @@ export function SocketProvider({ children, user }: SocketProviderProps) {
       blockId: string,
       subblockId: string,
       value: any,
-      operationId?: string,
-      workflowId?: string
+      operationId: string | undefined,
+      workflowId: string
     ) => {
-      if (!workflowId) {
-        logger.error('emitSubblockUpdate called without workflowId', { blockId, subblockId })
-        return
-      }
       if (!socket) {
         logger.warn('Cannot emit subblock update: no socket connection', { workflowId, blockId })
         return
@@ -709,11 +712,13 @@ export function SocketProvider({ children, user }: SocketProviderProps) {
   )
 
   const emitVariableUpdate = useCallback(
-    (variableId: string, field: string, value: any, operationId?: string, workflowId?: string) => {
-      if (!workflowId) {
-        logger.error('emitVariableUpdate called without workflowId', { variableId, field })
-        return
-      }
+    (
+      variableId: string,
+      field: string,
+      value: any,
+      operationId: string | undefined,
+      workflowId: string
+    ) => {
       if (!socket) {
         logger.warn('Cannot emit variable update: no socket connection', { workflowId, variableId })
         return