Skip to content

Commit c4e8254

Browse files
committed
fix(files): only show loading skeleton while fetching, relax mongo auth validation
- files.tsx: gate loading skeleton on isLoading so navigating to a missing file ID doesn't permanently show the skeleton after load completes - database-tools.ts: remove refine() pairing username+password on mongo connection schema so either field can be provided independently
1 parent 3d11d59 commit c4e8254

2 files changed

Lines changed: 10 additions & 15 deletions

File tree

apps/sim/app/workspace/[workspaceId]/files/files.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,7 @@ export function Files() {
10331033
return tags
10341034
}, [typeFilter, sizeFilter, uploadedByFilter, members])
10351035

1036-
if (fileIdFromRoute && !selectedFile) {
1036+
if (fileIdFromRoute && !selectedFile && isLoading) {
10371037
return (
10381038
<div className='flex h-full flex-1 flex-col overflow-hidden bg-[var(--bg)]'>
10391039
<ResourceHeader icon={FilesIcon} breadcrumbs={loadingBreadcrumbs} />

apps/sim/lib/api/contracts/database-tools.ts

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -120,20 +120,15 @@ export const rdsIntrospectBodySchema = rdsConnectionBodySchema.extend({
120120
engine: z.enum(['aurora-postgresql', 'aurora-mysql']).optional(),
121121
})
122122

123-
const mongoConnectionBodySchema = z
124-
.object({
125-
host: z.string().min(1, 'Host is required'),
126-
port: z.coerce.number().int().positive('Port must be a positive integer'),
127-
database: z.string().min(1, 'Database name is required'),
128-
username: z.string().min(1, 'Username is required').optional(),
129-
password: z.string().min(1, 'Password is required').optional(),
130-
authSource: z.string().optional(),
131-
ssl: sslModeSchema,
132-
})
133-
.refine((data) => Boolean(data.username) === Boolean(data.password), {
134-
message: 'Username and password must be provided together',
135-
path: ['password'],
136-
})
123+
const mongoConnectionBodySchema = z.object({
124+
host: z.string().min(1, 'Host is required'),
125+
port: z.coerce.number().int().positive('Port must be a positive integer'),
126+
database: z.string().min(1, 'Database name is required'),
127+
username: z.string().min(1, 'Username is required').optional(),
128+
password: z.string().min(1, 'Password is required').optional(),
129+
authSource: z.string().optional(),
130+
ssl: sslModeSchema,
131+
})
137132

138133
const mongoJsonStringOrObjectSchema = (message: string) =>
139134
z

0 commit comments

Comments
 (0)