fix(logs): audit follow-ups — render side-effect, stats invalidation, enhanced spread order

- Move onActiveTabChange call from render into useEffect to avoid
  side-effects during render (StrictMode safety).
- Re-add logKeys.stats() invalidation to cancel/retry mutations so
  the dashboard reflects status flips immediately.
- Reorder enhanced: true after ...execData spread in detail and
  by-execution routes so the literal discriminator is never
  overwritten by stale execData.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/app/api/logs/[id]/route.ts

@@ -139,8 +139,8 @@ export const GET = withRouteHandler(
         hasPendingPause: false,
         executionData: {
           totalDuration: jobLog.totalDurationMs,
-          enhanced: true as const,
           ...execData,
+          enhanced: true as const,
         },
         files: null,
       }
@@ -191,8 +191,8 @@ export const GET = withRouteHandler(
       hasPendingPause,
       executionData: {
         totalDuration: log.totalDurationMs,
-        enhanced: true as const,
         ...((log.executionData as Record<string, unknown> | null) ?? {}),
+        enhanced: true as const,
       },
       files: log.files ?? null,
     }

apps/sim/app/api/logs/by-execution/[executionId]/route.ts

@@ -147,8 +147,8 @@ export const GET = withRouteHandler(
         hasPendingPause: false,
         executionData: {
           totalDuration: jobLog.totalDurationMs,
-          enhanced: true as const,
           ...execData,
+          enhanced: true as const,
         },
         files: null,
       }
@@ -199,8 +199,8 @@ export const GET = withRouteHandler(
       hasPendingPause,
       executionData: {
         totalDuration: log.totalDurationMs,
-        enhanced: true as const,
         ...((log.executionData as Record<string, unknown> | null) ?? {}),
+        enhanced: true as const,
       },
       files: log.files ?? null,
     }

apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx

@@ -313,11 +313,9 @@ export function LogDetailsContent({ log, onActiveTabChange }: LogDetailsContentP
 
   const resolvedTab: LogDetailsTab = activeTab === 'trace' && !showTraceTab ? 'overview' : activeTab
 
-  const prevResolvedTabRef = useRef<LogDetailsTab>(resolvedTab)
-  if (prevResolvedTabRef.current !== resolvedTab) {
-    prevResolvedTabRef.current = resolvedTab
+  useEffect(() => {
     onActiveTabChange?.(resolvedTab)
-  }
+  }, [resolvedTab, onActiveTabChange])
 
   const workflowOutput = useMemo(() => {
     const executionData = log.executionData as { finalOutput?: Record<string, unknown> } | undefined

apps/sim/hooks/queries/logs.ts

@@ -346,6 +346,7 @@ export function useCancelExecution() {
     onSettled: () => {
       queryClient.invalidateQueries({ queryKey: logKeys.lists() })
       queryClient.invalidateQueries({ queryKey: logKeys.details() })
+      queryClient.invalidateQueries({ queryKey: logKeys.stats() })
     },
   })
 }
@@ -374,6 +375,7 @@ export function useRetryExecution() {
     onSettled: () => {
       queryClient.invalidateQueries({ queryKey: logKeys.lists() })
       queryClient.invalidateQueries({ queryKey: logKeys.details() })
+      queryClient.invalidateQueries({ queryKey: logKeys.stats() })
     },
   })
 }