test(console-store): cover blockExecutionId keying and idempotency

Locks in the new console store invariants:
- Primary lookup via entryIdByBlockExecutionId fires no legacy warn
- Unknown blockExecutionId falls back to legacy keying and warns
- No-blockExecutionId updates use legacy path silently
- addConsole twice with same blockExecutionId returns the existing entry
- Distinct blockExecutionIds (loop iterations) produce distinct entries

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/stores/terminal/console/store.test.ts

@@ -1,22 +1,30 @@
 /**
  * @vitest-environment node
  */
+import { createLogger } from '@sim/logger'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 vi.unmock('@/stores/terminal')
 vi.unmock('@/stores/terminal/console/store')
 
 import { useTerminalConsoleStore } from '@/stores/terminal/console/store'
 
+const storeLogger = vi
+  .mocked(createLogger)
+  .mock.results.map((result) => result.value)
+  .find((value) => value && typeof value.warn === 'function')
+
 describe('terminal console store', () => {
   beforeEach(() => {
     useTerminalConsoleStore.setState({
       workflowEntries: {},
       entryIdsByBlockExecution: {},
+      entryIdByBlockExecutionId: {},
       entryLocationById: {},
       isOpen: false,
       _hasHydrated: true,
     })
+    storeLogger?.warn.mockClear()
   })
 
   it('normalizes oversized payloads when adding console entries', () => {
@@ -117,6 +125,148 @@ describe('terminal console store', () => {
     expect(after.getWorkflowEntries('wf-1')[0].output).toMatchObject({ status: 'updated' })
   })
 
+  describe('blockExecutionId keying', () => {
+    it('updates an entry via the primary index without firing legacy warn', () => {
+      useTerminalConsoleStore.getState().addConsole({
+        workflowId: 'wf-1',
+        blockId: 'block-1',
+        blockName: 'Function',
+        blockType: 'function',
+        executionId: 'exec-1',
+        blockExecutionId: 'bex-1',
+        executionOrder: 1,
+        isRunning: true,
+      })
+
+      useTerminalConsoleStore.getState().updateConsole(
+        'block-1',
+        {
+          executionOrder: 1,
+          blockExecutionId: 'bex-1',
+          success: true,
+          replaceOutput: { status: 'done' },
+        },
+        'exec-1'
+      )
+
+      const [entry] = useTerminalConsoleStore.getState().getWorkflowEntries('wf-1')
+      expect(entry.success).toBe(true)
+      expect(entry.output).toMatchObject({ status: 'done' })
+      expect(storeLogger?.warn).not.toHaveBeenCalled()
+    })
+
+    it('falls back to legacy keying and warns when blockExecutionId is unknown', () => {
+      useTerminalConsoleStore.getState().addConsole({
+        workflowId: 'wf-1',
+        blockId: 'block-1',
+        blockName: 'Function',
+        blockType: 'function',
+        executionId: 'exec-1',
+        executionOrder: 1,
+        isRunning: true,
+      })
+
+      useTerminalConsoleStore.getState().updateConsole(
+        'block-1',
+        {
+          executionOrder: 1,
+          blockExecutionId: 'bex-unknown',
+          success: true,
+          replaceOutput: { status: 'done' },
+        },
+        'exec-1'
+      )
+
+      const [entry] = useTerminalConsoleStore.getState().getWorkflowEntries('wf-1')
+      expect(entry.success).toBe(true)
+      expect(storeLogger?.warn).toHaveBeenCalledWith(
+        'updateConsole used legacy keying (hydrated or cross-deploy entry)',
+        expect.objectContaining({ blockExecutionId: 'bex-unknown', blockId: 'block-1' })
+      )
+    })
+
+    it('uses legacy keying without warning when no blockExecutionId is provided', () => {
+      useTerminalConsoleStore.getState().addConsole({
+        workflowId: 'wf-1',
+        blockId: 'block-1',
+        blockName: 'Function',
+        blockType: 'function',
+        executionId: 'exec-1',
+        executionOrder: 1,
+        isRunning: true,
+      })
+
+      useTerminalConsoleStore
+        .getState()
+        .updateConsole(
+          'block-1',
+          { executionOrder: 1, success: true, replaceOutput: { status: 'done' } },
+          'exec-1'
+        )
+
+      const [entry] = useTerminalConsoleStore.getState().getWorkflowEntries('wf-1')
+      expect(entry.success).toBe(true)
+      expect(storeLogger?.warn).not.toHaveBeenCalled()
+    })
+  })
+
+  describe('addConsole idempotency', () => {
+    it('returns the existing entry when called twice with the same blockExecutionId', () => {
+      const first = useTerminalConsoleStore.getState().addConsole({
+        workflowId: 'wf-1',
+        blockId: 'block-1',
+        blockName: 'Function',
+        blockType: 'function',
+        executionId: 'exec-1',
+        blockExecutionId: 'bex-1',
+        executionOrder: 1,
+        isRunning: true,
+      })
+
+      const second = useTerminalConsoleStore.getState().addConsole({
+        workflowId: 'wf-1',
+        blockId: 'block-1',
+        blockName: 'Function',
+        blockType: 'function',
+        executionId: 'exec-1',
+        blockExecutionId: 'bex-1',
+        executionOrder: 1,
+        isRunning: true,
+      })
+
+      const entries = useTerminalConsoleStore.getState().getWorkflowEntries('wf-1')
+      expect(entries).toHaveLength(1)
+      expect(second?.id).toBe(first?.id)
+    })
+
+    it('creates distinct entries for different blockExecutionIds (loop iterations)', () => {
+      useTerminalConsoleStore.getState().addConsole({
+        workflowId: 'wf-1',
+        blockId: 'block-1',
+        blockName: 'Function',
+        blockType: 'function',
+        executionId: 'exec-1',
+        blockExecutionId: 'bex-iter-1',
+        executionOrder: 1,
+        isRunning: true,
+      })
+
+      useTerminalConsoleStore.getState().addConsole({
+        workflowId: 'wf-1',
+        blockId: 'block-1',
+        blockName: 'Function',
+        blockType: 'function',
+        executionId: 'exec-1',
+        blockExecutionId: 'bex-iter-2',
+        executionOrder: 2,
+        isRunning: true,
+      })
+
+      const entries = useTerminalConsoleStore.getState().getWorkflowEntries('wf-1')
+      expect(entries).toHaveLength(2)
+    })
+  })
+
   describe('cancelRunningEntries', () => {
     it('flips a plain running entry to canceled', () => {
       useTerminalConsoleStore.getState().addConsole({