removed dead code

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/components/edit-chunk-modal/edit-chunk-modal.tsx

@@ -50,7 +50,7 @@ export function EditChunkModal({
   totalPages = 1,
   onNavigateToChunk,
   onNavigateToPage,
-  maxChunkSize = 1024,
+  maxChunkSize,
 }: EditChunkModalProps) {
   const queryClient = useQueryClient()
   const userPermissions = useUserPermissionsContext()
@@ -339,7 +339,8 @@ export function EditChunkModal({
                   <Switch checked={tokenizerOn} onCheckedChange={setTokenizerOn} />
                 </div>
                 <span className='text-[12px] text-[var(--text-secondary)]'>
-                  {tokenCount.toLocaleString()}/{maxChunkSize.toLocaleString()}
+                  {tokenCount.toLocaleString()}
+                  {maxChunkSize !== undefined && `/${maxChunkSize.toLocaleString()}`} tokens
                 </span>
               </div>
             </ModalBody>

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

@@ -35,7 +35,7 @@ import {
 import { Input } from '@/components/ui/input'
 import { SearchHighlight } from '@/components/ui/search-highlight'
 import { Skeleton } from '@/components/ui/skeleton'
-import type { ChunkData, DocumentData } from '@/lib/knowledge/types'
+import type { ChunkData } from '@/lib/knowledge/types'
 import {
   CreateChunkModal,
   DeleteChunkModal,
@@ -45,11 +45,7 @@ import {
 import { ActionBar } from '@/app/workspace/[workspaceId]/knowledge/[id]/components'
 import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider'
 import { knowledgeKeys } from '@/hooks/queries/knowledge'
-import {
-  useCachedDocuments,
-  useCachedKnowledgeBase,
-  useDocumentChunks,
-} from '@/hooks/use-knowledge'
+import { useDocument, useDocumentChunks, useKnowledgeBase } from '@/hooks/use-knowledge'
 
 const logger = createLogger('Document')
 
@@ -271,15 +267,12 @@ export function Document({
   const currentPageFromURL = Number.parseInt(searchParams.get('page') || '1', 10)
   const userPermissions = useUserPermissionsContext()
 
-  const cachedKnowledgeBase = useCachedKnowledgeBase(knowledgeBaseId)
-  const cachedDocumentsData = useCachedDocuments(knowledgeBaseId)
-
-  /**
-   * Get cached document synchronously for immediate render
-   */
-  const getInitialCachedDocument = useCallback(() => {
-    return cachedDocumentsData?.documents?.find((d: DocumentData) => d.id === documentId) || null
-  }, [cachedDocumentsData, documentId])
+  const { knowledgeBase } = useKnowledgeBase(knowledgeBaseId)
+  const {
+    document: documentData,
+    isLoading: isLoadingDocument,
+    error: documentError,
+  } = useDocument(knowledgeBaseId, documentId)
 
   const [showTagsModal, setShowTagsModal] = useState(false)
 
@@ -298,9 +291,7 @@ export function Document({
     refreshChunks: initialRefreshChunks,
     updateChunk: initialUpdateChunk,
     isFetching: isFetchingChunks,
-  } = useDocumentChunks(knowledgeBaseId, documentId, currentPageFromURL, '', {
-    enableClientSearch: false,
-  })
+  } = useDocumentChunks(knowledgeBaseId, documentId, currentPageFromURL)
 
   const [searchResults, setSearchResults] = useState<ChunkData[]>([])
   const [isLoadingSearch, setIsLoadingSearch] = useState(false)
@@ -436,67 +427,16 @@ export function Document({
   const refreshChunks = showingSearch ? async () => {} : initialRefreshChunks
   const updateChunk = showingSearch ? (id: string, updates: any) => {} : initialUpdateChunk
 
-  const initialCachedDoc = getInitialCachedDocument()
-  const [documentData, setDocumentData] = useState<DocumentData | null>(initialCachedDoc)
-  const [isLoadingDocument, setIsLoadingDocument] = useState(!initialCachedDoc)
-  const [error, setError] = useState<string | null>(null)
-
   const [isCreateChunkModalOpen, setIsCreateChunkModalOpen] = useState(false)
   const [chunkToDelete, setChunkToDelete] = useState<ChunkData | null>(null)
   const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false)
   const [isBulkOperating, setIsBulkOperating] = useState(false)
   const [showDeleteDocumentDialog, setShowDeleteDocumentDialog] = useState(false)
   const [isDeletingDocument, setIsDeletingDocument] = useState(false)
 
-  const combinedError = error || searchError || initialError
+  const combinedError = documentError || searchError || initialError
 
-  useEffect(() => {
-    const fetchDocument = async () => {
-      const cachedDoc = cachedDocumentsData?.documents?.find(
-        (d: DocumentData) => d.id === documentId
-      )
-
-      if (cachedDoc) {
-        setDocumentData(cachedDoc)
-        setIsLoadingDocument(false)
-        return
-      }
-
-      setIsLoadingDocument(true)
-      setError(null)
-
-      try {
-        const response = await fetch(`/api/knowledge/${knowledgeBaseId}/documents/${documentId}`)
-
-        if (!response.ok) {
-          if (response.status === 404) {
-            throw new Error('Document not found')
-          }
-          throw new Error(`Failed to fetch document: ${response.statusText}`)
-        }
-
-        const result = await response.json()
-
-        if (result.success) {
-          setDocumentData(result.data)
-        } else {
-          throw new Error(result.error || 'Failed to fetch document')
-        }
-      } catch (err) {
-        logger.error('Error fetching document:', err)
-        setError(err instanceof Error ? err.message : 'An error occurred')
-      } finally {
-        setIsLoadingDocument(false)
-      }
-    }
-
-    if (knowledgeBaseId && documentId) {
-      fetchDocument()
-    }
-  }, [knowledgeBaseId, documentId, cachedDocumentsData])
-
-  const effectiveKnowledgeBaseName =
-    cachedKnowledgeBase?.name || knowledgeBaseName || 'Knowledge Base'
+  const effectiveKnowledgeBaseName = knowledgeBase?.name || knowledgeBaseName || 'Knowledge Base'
   const effectiveDocumentName = documentData?.filename || documentName || 'Document'
 
   const breadcrumbItems = [
@@ -702,15 +642,11 @@ export function Document({
 
   const isAllSelected = displayChunks.length > 0 && selectedChunks.size === displayChunks.length
 
-  const handleDocumentTagsUpdate = useCallback(
-    (tagData: Record<string, string>) => {
-      setDocumentData((prev) => (prev ? { ...prev, ...tagData } : null))
-      queryClient.invalidateQueries({
-        queryKey: knowledgeKeys.detail(knowledgeBaseId),
-      })
-    },
-    [knowledgeBaseId, queryClient]
-  )
+  const handleDocumentTagsUpdate = useCallback(() => {
+    queryClient.invalidateQueries({
+      queryKey: knowledgeKeys.document(knowledgeBaseId, documentId),
+    })
+  }, [knowledgeBaseId, documentId, queryClient])
 
   const prevDocumentIdRef = useRef<string>(documentId)
   const isNavigatingToNewDoc = prevDocumentIdRef.current !== documentId
@@ -1139,7 +1075,7 @@ export function Document({
         onNavigateToChunk={(chunk: ChunkData) => {
           setSelectedChunk(chunk)
         }}
-        maxChunkSize={cachedKnowledgeBase?.chunkingConfig?.maxSize}
+        maxChunkSize={knowledgeBase?.chunkingConfig?.maxSize}
         onNavigateToPage={async (page: number, selectChunk: 'first' | 'last') => {
           await goToPage(page)
 

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx

@@ -593,7 +593,6 @@ export function KnowledgeBase({
 
     const newEnabled = !document.enabled
 
-    // Optimistic update - immediately update the UI
     updateDocument(docId, { enabled: newEnabled })
 
     try {
@@ -614,11 +613,9 @@ export function KnowledgeBase({
       const result = await response.json()
 
       if (!result.success) {
-        // Revert on failure
         updateDocument(docId, { enabled: !newEnabled })
       }
     } catch (err) {
-      // Revert on error
       updateDocument(docId, { enabled: !newEnabled })
       logger.error('Error updating document:', err)
     }
@@ -842,15 +839,13 @@ export function KnowledgeBase({
       const result = await response.json()
 
       if (result.success) {
-        // Update successful documents in the store
         result.data.updatedDocuments.forEach((updatedDoc: { id: string; enabled: boolean }) => {
           updateDocument(updatedDoc.id, { enabled: updatedDoc.enabled })
         })
 
         logger.info(`Successfully enabled ${result.data.successCount} documents`)
       }
 
-      // Clear selection after successful operation
       setSelectedDocuments(new Set())
     } catch (err) {
       logger.error('Error enabling documents:', err)
@@ -960,20 +955,15 @@ export function KnowledgeBase({
   const enabledCount = selectedDocumentsList.filter((doc) => doc.enabled).length
   const disabledCount = selectedDocumentsList.filter((doc) => !doc.enabled).length
 
-  // Track previous KB id to detect navigation between different knowledge bases
   const prevKnowledgeBaseIdRef = useRef<string>(id)
   const isNavigatingToNewKB = prevKnowledgeBaseIdRef.current !== id
 
-  // Update ref when KB data loads successfully
   useEffect(() => {
     if (knowledgeBase && knowledgeBase.id === id) {
       prevKnowledgeBaseIdRef.current = id
     }
   }, [knowledgeBase, id])
 
-  // Show full page skeleton when:
-  // 1. Initial load (no KB data yet), OR
-  // 2. Navigating to a different KB (showing placeholder data from previous KB)
   const isInitialLoad = isLoadingKnowledgeBase && !knowledgeBase
   const isFetchingNewKB = isNavigatingToNewKB && isFetchingDocuments
 

apps/sim/app/workspace/[workspaceId]/knowledge/components/knowledge-header/knowledge-header.tsx

@@ -125,12 +125,10 @@ export function KnowledgeHeader({ breadcrumbs, options }: KnowledgeHeaderProps)
           `Knowledge base workspace updated: ${options.knowledgeBaseId} -> ${workspaceId}`
         )
 
-        // Invalidate React Query cache
         await queryClient.invalidateQueries({
           queryKey: knowledgeKeys.detail(options.knowledgeBaseId),
         })
 
-        // Notify parent component of the change to refresh data
         await options.onWorkspaceChange?.(workspaceId)
       } else {
         throw new Error(result.error || 'Failed to update workspace')

apps/sim/hooks/queries/knowledge.ts

@@ -1,5 +1,4 @@
-import { createLogger } from '@sim/logger'
-import { keepPreviousData, useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
+import { keepPreviousData, useQuery } from '@tanstack/react-query'
 import type {
   ChunkData,
   ChunksPagination,
@@ -8,23 +7,17 @@ import type {
   KnowledgeBaseData,
 } from '@/lib/knowledge/types'
 
-const logger = createLogger('KnowledgeQueries')
-
 export const knowledgeKeys = {
   all: ['knowledge'] as const,
   list: (workspaceId?: string) => [...knowledgeKeys.all, 'list', workspaceId ?? 'all'] as const,
   detail: (knowledgeBaseId?: string) =>
     [...knowledgeKeys.all, 'detail', knowledgeBaseId ?? ''] as const,
   documents: (knowledgeBaseId: string, paramsKey: string) =>
     [...knowledgeKeys.detail(knowledgeBaseId), 'documents', paramsKey] as const,
+  document: (knowledgeBaseId: string, documentId: string) =>
+    [...knowledgeKeys.detail(knowledgeBaseId), 'document', documentId] as const,
   chunks: (knowledgeBaseId: string, documentId: string, paramsKey: string) =>
-    [
-      ...knowledgeKeys.detail(knowledgeBaseId),
-      'document',
-      documentId,
-      'chunks',
-      paramsKey,
-    ] as const,
+    [...knowledgeKeys.document(knowledgeBaseId, documentId), 'chunks', paramsKey] as const,
 }
 
 export async function fetchKnowledgeBases(workspaceId?: string): Promise<KnowledgeBaseData[]> {
@@ -58,6 +51,27 @@ export async function fetchKnowledgeBase(knowledgeBaseId: string): Promise<Knowl
   return result.data
 }
 
+export async function fetchDocument(
+  knowledgeBaseId: string,
+  documentId: string
+): Promise<DocumentData> {
+  const response = await fetch(`/api/knowledge/${knowledgeBaseId}/documents/${documentId}`)
+
+  if (!response.ok) {
+    if (response.status === 404) {
+      throw new Error('Document not found')
+    }
+    throw new Error(`Failed to fetch document: ${response.status} ${response.statusText}`)
+  }
+
+  const result = await response.json()
+  if (!result?.success || !result?.data) {
+    throw new Error(result?.error || 'Failed to fetch document')
+  }
+
+  return result.data
+}
+
 export interface KnowledgeDocumentsParams {
   knowledgeBaseId: string
   search?: string
@@ -192,6 +206,15 @@ export function useKnowledgeBaseQuery(knowledgeBaseId?: string) {
   })
 }
 
+export function useDocumentQuery(knowledgeBaseId?: string, documentId?: string) {
+  return useQuery({
+    queryKey: knowledgeKeys.document(knowledgeBaseId ?? '', documentId ?? ''),
+    queryFn: () => fetchDocument(knowledgeBaseId as string, documentId as string),
+    enabled: Boolean(knowledgeBaseId && documentId),
+    staleTime: 60 * 1000,
+  })
+}
+
 export const serializeDocumentParams = (params: KnowledgeDocumentsParams) =>
   JSON.stringify({
     search: params.search ?? '',
@@ -239,61 +262,3 @@ export function useKnowledgeChunksQuery(
     placeholderData: keepPreviousData,
   })
 }
-
-interface UpdateDocumentPayload {
-  knowledgeBaseId: string
-  documentId: string
-  updates: Partial<DocumentData>
-}
-
-export function useMutateKnowledgeDocument() {
-  const queryClient = useQueryClient()
-  return useMutation({
-    mutationFn: async ({ knowledgeBaseId, documentId, updates }: UpdateDocumentPayload) => {
-      const response = await fetch(`/api/knowledge/${knowledgeBaseId}/documents/${documentId}`, {
-        method: 'PUT',
-        headers: {
-          'Content-Type': 'application/json',
-        },
-        body: JSON.stringify(updates),
-      })
-
-      if (!response.ok) {
-        const errorData = await response.json().catch(() => ({}))
-        throw new Error(errorData.error || 'Failed to update document')
-      }
-
-      const result = await response.json()
-      if (!result?.success) {
-        throw new Error(result?.error || 'Failed to update document')
-      }
-
-      return result
-    },
-    onMutate: async ({ knowledgeBaseId, documentId, updates }) => {
-      await queryClient.cancelQueries({ queryKey: knowledgeKeys.detail(knowledgeBaseId) })
-
-      const documentQueries = queryClient
-        .getQueriesData<KnowledgeDocumentsResponse>({
-          queryKey: knowledgeKeys.detail(knowledgeBaseId),
-        })
-        .filter(([key]) => Array.isArray(key) && key.includes('documents'))
-
-      documentQueries.forEach(([key, data]) => {
-        if (!data) return
-        queryClient.setQueryData(key, {
-          ...data,
-          documents: data.documents.map((doc) =>
-            doc.id === documentId ? { ...doc, ...updates } : doc
-          ),
-        })
-      })
-    },
-    onError: (error) => {
-      logger.error('Failed to mutate document', error)
-    },
-    onSettled: (_data, _error, variables) => {
-      queryClient.invalidateQueries({ queryKey: knowledgeKeys.detail(variables.knowledgeBaseId) })
-    },
-  })
-}