fix(workspace): prevent stale placeholder data from corrupting workflow registry on switch

- Guard completeMetadataLoad to skip when isPlaceholderData is true, preventing
  the previous workspace's workflows from briefly populating the registry during switch
- Trigger beginMetadataLoad when isPlaceholderData is true to ensure loading state
  is shown correctly on direct URL navigation (no switchToWorkspace call)
- Narrow useCreateWorkspace invalidation from workspaceKeys.all to workspaceKeys.lists()
  to avoid unnecessary refetches of permissions, settings, and members

Author: waleedlatif1

apps/sim/hooks/queries/workflows.ts

@@ -113,22 +113,36 @@ export function useWorkflows(
   })
 
   useEffect(() => {
-    if (syncRegistry && scope === 'active' && workspaceId && query.status === 'pending') {
+    if (
+      syncRegistry &&
+      scope === 'active' &&
+      workspaceId &&
+      (query.status === 'pending' || query.isPlaceholderData)
+    ) {
       beginMetadataLoad(workspaceId)
     }
-  }, [syncRegistry, scope, workspaceId, query.status, beginMetadataLoad])
+  }, [syncRegistry, scope, workspaceId, query.status, query.isPlaceholderData, beginMetadataLoad])
 
   useEffect(() => {
     if (
       syncRegistry &&
       scope === 'active' &&
       workspaceId &&
       query.status === 'success' &&
-      query.data
+      query.data &&
+      !query.isPlaceholderData
     ) {
       completeMetadataLoad(workspaceId, query.data)
     }
-  }, [syncRegistry, scope, workspaceId, query.status, query.data, completeMetadataLoad])
+  }, [
+    syncRegistry,
+    scope,
+    workspaceId,
+    query.status,
+    query.data,
+    query.isPlaceholderData,
+    completeMetadataLoad,
+  ])
 
   useEffect(() => {
     if (syncRegistry && scope === 'active' && workspaceId && query.status === 'error') {

apps/sim/hooks/queries/workspace.ts

@@ -86,14 +86,8 @@ export function useCreateWorkspace() {
       const data = await response.json()
       return data.workspace as Workspace
     },
-    onSuccess: (data) => {
-      queryClient.invalidateQueries({ queryKey: workspaceKeys.all })
-      if (data?.id) {
-        queryClient.removeQueries({ queryKey: workspaceKeys.detail(data.id) })
-        queryClient.removeQueries({ queryKey: workspaceKeys.settings(data.id) })
-        queryClient.removeQueries({ queryKey: workspaceKeys.permissions(data.id) })
-        queryClient.removeQueries({ queryKey: workspaceKeys.members(data.id) })
-      }
+    onSuccess: () => {
+      queryClient.invalidateQueries({ queryKey: workspaceKeys.lists() })
     },
   })
 }