fix: add default timeout for internal routes and validate finite timeout

- Internal routes now use same 5-minute default as external routes
- Added Number.isFinite() check to reject Infinity values

Author: waleedlatif1

apps/sim/tools/index.ts

@@ -627,9 +627,8 @@ async function executeToolRequest(
     if (isInternalRoute) {
       // Set up AbortController for timeout support on internal routes
       const controller = new AbortController()
-      const timeoutId = requestParams.timeout
-        ? setTimeout(() => controller.abort(), requestParams.timeout)
-        : undefined
+      const timeout = requestParams.timeout || 300000
+      const timeoutId = setTimeout(() => controller.abort(), timeout)
 
       try {
         response = await fetch(fullUrl, {
@@ -641,11 +640,11 @@ async function executeToolRequest(
       } catch (error) {
         // Convert AbortError to a timeout error message
         if (error instanceof Error && error.name === 'AbortError') {
-          throw new Error(`Request timed out after ${requestParams.timeout}ms`)
+          throw new Error(`Request timed out after ${timeout}ms`)
         }
         throw error
       } finally {
-        if (timeoutId) clearTimeout(timeoutId)
+        clearTimeout(timeoutId)
       }
     } else {
       const urlValidation = await validateUrlWithDNS(fullUrl, 'toolUrl')

apps/sim/tools/utils.ts

@@ -123,12 +123,11 @@ export function formatRequestParams(tool: ToolConfig, params: Record<string, any
     }
   }
 
-  // Get timeout from params (if specified) and ensure it's a valid positive number
-  // The short-input subBlock returns a string, so we need to convert it
+  // Get timeout from params (if specified)
   const rawTimeout = params.timeout
   const timeout = rawTimeout != null ? Number(rawTimeout) : undefined
   const validTimeout =
-    timeout != null && !Number.isNaN(timeout) && timeout > 0 ? timeout : undefined
+    timeout != null && Number.isFinite(timeout) && timeout > 0 ? timeout : undefined
 
   return { url, method, headers, body, timeout: validTimeout }
 }