address comments

Author: icecrasher321

apps/sim/app/api/jobs/[jobId]/route.ts

@@ -27,7 +27,7 @@ export async function GET(
 
     const dispatchJob = await getDispatchJobRecord(taskId)
     const jobQueue = await getJobQueue()
-    const job = dispatchJob ? await jobQueue.getJob(taskId) : await jobQueue.getJob(taskId)
+    const job = dispatchJob ? null : await jobQueue.getJob(taskId)
 
     if (!job && !dispatchJob) {
       return createErrorResponse('Task not found', 404)

apps/sim/app/api/schedules/execute/route.ts

@@ -115,11 +115,10 @@ export async function GET(request: NextRequest) {
       }
 
       try {
-        const workspaceId = schedule.workflowId
-          ? (await import('@/lib/workflows/utils')).getWorkflowById
+        const { getWorkflowById } = await import('@/lib/workflows/utils')
+        const resolvedWorkflow = schedule.workflowId
+          ? await getWorkflowById(schedule.workflowId)
           : null
-        const resolvedWorkflow =
-          schedule.workflowId && workspaceId ? await workspaceId(schedule.workflowId) : null
         const resolvedWorkspaceId = resolvedWorkflow?.workspaceId
 
         let jobId: string

apps/sim/app/api/workflows/[id]/execute/route.ts

@@ -812,6 +812,17 @@ async function handleExecutePost(
             (preprocessResult.executionTimeout?.sync ?? 300000) + 30000
           )
 
+          if (resultRecord.status === 'failed') {
+            return NextResponse.json(
+              {
+                success: false,
+                executionId,
+                error: resultRecord.error ?? 'Workflow execution failed',
+              },
+              { status: 500 }
+            )
+          }
+
           const result = resultRecord.output as QueuedWorkflowExecutionResult
 
           const resultForResponseBlock = {
@@ -977,8 +988,8 @@ async function handleExecutePost(
     }
 
     if (shouldUseDraftState) {
-      const useDispatchForManual = shouldUseBullMQ() && triggerType !== 'manual'
-      if (useDispatchForManual) {
+      const shouldDispatchViaQueue = shouldUseBullMQ() && triggerType !== 'manual'
+      if (shouldDispatchViaQueue) {
         const metadata: ExecutionMetadata = {
           requestId,
           executionId,

apps/sim/lib/core/admission/gate.ts

@@ -15,7 +15,9 @@ export interface AdmissionTicket {
 /**
  * Attempts to admit a request through the in-process gate.
  * Returns a ticket with a release() handle on success, or null if at capacity.
- * Zero external calls — purely in-process atomic counter.
+ * Zero external calls — purely in-process atomic counter. Each pod maintains its
+ * own counter, so the effective aggregate limit across N pods is N × MAX_INFLIGHT.
+ * Configure ADMISSION_GATE_MAX_INFLIGHT per pod based on what each pod can sustain.
  */
 export function tryAdmit(): AdmissionTicket | null {
   if (inflight >= MAX_INFLIGHT) {