type improvments

icecrasher321 · icecrasher321 · commit 63e79fcb3b9f · 2026-05-05T23:19:35.000-07:00
diff --git a/apps/sim/tools/emailbison/attach_leads_to_campaign.ts b/apps/sim/tools/emailbison/attach_leads_to_campaign.ts
@@ -5,8 +5,8 @@ import type {
 import {
   actionOutput,
   actionOutputs,
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   jsonBody,
 } from '@/tools/emailbison/utils'
@@ -58,7 +58,7 @@ export const attachLeadsToCampaignTool: ToolConfig<
       }),
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'campaign lead attachment result')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/attach_tags_to_leads.ts b/apps/sim/tools/emailbison/attach_tags_to_leads.ts
@@ -5,8 +5,8 @@ import type {
 import {
   actionOutput,
   actionOutputs,
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   jsonBody,
 } from '@/tools/emailbison/utils'
@@ -60,7 +60,7 @@ export const attachTagsToLeadsTool: ToolConfig<
       }),
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'tag attachment result')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/create_campaign.ts b/apps/sim/tools/emailbison/create_campaign.ts
@@ -4,8 +4,8 @@ import type {
 } from '@/tools/emailbison/types'
 import {
   campaignOutputs,
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   jsonBody,
   mapCampaign,
@@ -51,7 +51,7 @@ export const createCampaignTool: ToolConfig<
       }),
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'campaign')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/create_lead.ts b/apps/sim/tools/emailbison/create_lead.ts
@@ -1,7 +1,7 @@
 import type { EmailBisonLeadMutationParams, EmailBisonLeadResponse } from '@/tools/emailbison/types'
 import {
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   jsonBody,
   leadOutputs,
@@ -87,7 +87,7 @@ export const createLeadTool: ToolConfig<EmailBisonLeadMutationParams, EmailBison
       }),
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'lead')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/create_tag.ts b/apps/sim/tools/emailbison/create_tag.ts
@@ -1,7 +1,7 @@
 import type { EmailBisonCreateTagParams, EmailBisonTagResponse } from '@/tools/emailbison/types'
 import {
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   jsonBody,
   mapTag,
@@ -35,7 +35,7 @@ export const createTagTool: ToolConfig<EmailBisonCreateTagParams, EmailBisonTagR
     body: (params) => jsonBody({ name: params.name }),
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'tag')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/get_lead.ts b/apps/sim/tools/emailbison/get_lead.ts
@@ -1,7 +1,7 @@
 import type { EmailBisonGetLeadParams, EmailBisonLeadResponse } from '@/tools/emailbison/types'
 import {
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   leadOutputs,
   mapLead,
@@ -33,7 +33,7 @@ export const getLeadTool: ToolConfig<EmailBisonGetLeadParams, EmailBisonLeadResp
     headers: emailBisonHeaders,
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'lead')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/list_campaigns.ts b/apps/sim/tools/emailbison/list_campaigns.ts
@@ -3,7 +3,7 @@ import type {
   EmailBisonListCampaignsResponse,
 } from '@/tools/emailbison/types'
 import {
-  emailBisonData,
+  emailBisonArrayData,
   emailBisonHeaders,
   emailBisonUrl,
   listCampaignsOutputs,
@@ -31,8 +31,8 @@ export const listCampaignsTool: ToolConfig<EmailBisonBaseParams, EmailBisonListC
       headers: emailBisonHeaders,
     },
     transformResponse: async (response) => {
-      const data = (await emailBisonData<unknown[]>(response)) ?? []
-      const campaigns = Array.isArray(data) ? data.map(mapCampaign) : []
+      const data = await emailBisonArrayData(response, 'campaigns')
+      const campaigns = data.map(mapCampaign)
 
       return {
         success: true,
diff --git a/apps/sim/tools/emailbison/list_leads.ts b/apps/sim/tools/emailbison/list_leads.ts
@@ -3,7 +3,7 @@ import type {
   EmailBisonListLeadsResponse,
 } from '@/tools/emailbison/types'
 import {
-  emailBisonData,
+  emailBisonArrayData,
   emailBisonHeaders,
   emailBisonUrl,
   listLeadsOutputs,
@@ -70,8 +70,8 @@ export const listLeadsTool: ToolConfig<EmailBisonListLeadsParams, EmailBisonList
     headers: emailBisonHeaders,
   },
   transformResponse: async (response) => {
-    const data = (await emailBisonData<unknown[]>(response)) ?? []
-    const leads = Array.isArray(data) ? data.map(mapLead) : []
+    const data = await emailBisonArrayData(response, 'leads')
+    const leads = data.map(mapLead)
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/list_replies.ts b/apps/sim/tools/emailbison/list_replies.ts
@@ -3,7 +3,7 @@ import type {
   EmailBisonListRepliesResponse,
 } from '@/tools/emailbison/types'
 import {
-  emailBisonData,
+  emailBisonArrayData,
   emailBisonHeaders,
   emailBisonUrl,
   listRepliesOutputs,
@@ -93,8 +93,8 @@ export const listRepliesTool: ToolConfig<
     headers: emailBisonHeaders,
   },
   transformResponse: async (response) => {
-    const data = (await emailBisonData<unknown[]>(response)) ?? []
-    const replies = Array.isArray(data) ? data.map(mapReply) : []
+    const data = await emailBisonArrayData(response, 'replies')
+    const replies = data.map(mapReply)
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/list_tags.ts b/apps/sim/tools/emailbison/list_tags.ts
@@ -1,6 +1,6 @@
 import type { EmailBisonBaseParams, EmailBisonListTagsResponse } from '@/tools/emailbison/types'
 import {
-  emailBisonData,
+  emailBisonArrayData,
   emailBisonHeaders,
   emailBisonUrl,
   listTagsOutputs,
@@ -27,8 +27,8 @@ export const listTagsTool: ToolConfig<EmailBisonBaseParams, EmailBisonListTagsRe
     headers: emailBisonHeaders,
   },
   transformResponse: async (response) => {
-    const data = (await emailBisonData<unknown[]>(response)) ?? []
-    const tags = Array.isArray(data) ? data.map(mapTag) : []
+    const data = await emailBisonArrayData(response, 'tags')
+    const tags = data.map(mapTag)
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/types.ts b/apps/sim/tools/emailbison/types.ts
@@ -5,23 +5,23 @@ export interface EmailBisonBaseParams {
 }
 
 export interface EmailBisonCustomVariable {
-  name: string
+  name: string | null
   value: string | null
 }
 
 export interface EmailBisonLeadStats {
-  emails_sent: number
-  opens: number
-  replies: number
-  unique_replies: number
-  unique_opens: number
+  emails_sent: number | null
+  opens: number | null
+  replies: number | null
+  unique_replies: number | null
+  unique_opens: number | null
 }
 
 export interface EmailBisonLead {
-  id: number
-  first_name: string
-  last_name: string
-  email: string
+  id: number | null
+  first_name: string | null
+  last_name: string | null
+  email: string | null
   title: string | null
   company: string | null
   notes: string | null
@@ -34,36 +34,35 @@ export interface EmailBisonLead {
 }
 
 export interface EmailBisonTag {
-  id: number
-  name: string
-  default: boolean
+  id: number | null
+  name: string | null
+  default: boolean | null
   created_at?: string | null
   updated_at?: string | null
 }
 
 export interface EmailBisonCampaignTag {
-  id: number
-  name: string
-  default: boolean
+  id: number | null
+  name: string | null
+  default: boolean | null
 }
 
 export interface EmailBisonCampaign {
-  id: number
+  id: number | null
   uuid: string | null
-  name: string
+  name: string | null
   type: string | null
   status: string | null
-  emails_sent: number
-  opened: number
-  unique_opens: number
-  replied: number
-  unique_replies: number
-  bounced: number
-  unsubscribed: number
-  interested: number
-  total_leads_contacted: number
-  total_leads: number
-  completion_percentage?: number | null
+  emails_sent: number | null
+  opened: number | null
+  unique_opens: number | null
+  replied: number | null
+  unique_replies: number | null
+  bounced: number | null
+  unsubscribed: number | null
+  interested: number | null
+  total_leads_contacted: number | null
+  total_leads: number | null
   max_emails_per_day: number | null
   max_new_leads_per_day: number | null
   plain_text: boolean | null
@@ -78,11 +77,11 @@ export interface EmailBisonCampaign {
 
 export interface EmailBisonReplyAddress {
   name: string | null
-  address: string
+  address: string | null
 }
 
 export interface EmailBisonReplyAttachment {
-  id: number
+  id: number | null
   uuid: string | null
   reply_id: number | null
   file_name: string | null
@@ -92,20 +91,20 @@ export interface EmailBisonReplyAttachment {
 }
 
 export interface EmailBisonReply {
-  id: number
+  id: number | null
   uuid: string | null
   folder: string | null
   subject: string | null
-  read: boolean
-  interested: boolean
-  automated_reply: boolean
+  read: boolean | null
+  interested: boolean | null
+  automated_reply: boolean | null
   html_body: string | null
   text_body: string | null
   raw_body: string | null
   headers: string | null
   date_received: string | null
   type: string | null
-  tracked_reply: boolean
+  tracked_reply: boolean | null
   scheduled_email_id: number | string | null
   campaign_id: number | string | null
   lead_id: number | null
diff --git a/apps/sim/tools/emailbison/update_campaign.ts b/apps/sim/tools/emailbison/update_campaign.ts
@@ -4,8 +4,8 @@ import type {
 } from '@/tools/emailbison/types'
 import {
   campaignOutputs,
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   jsonBody,
   mapCampaign,
@@ -106,7 +106,7 @@ export const updateCampaignTool: ToolConfig<
       }),
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'campaign')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/update_campaign_status.ts b/apps/sim/tools/emailbison/update_campaign_status.ts
@@ -4,8 +4,8 @@ import type {
 } from '@/tools/emailbison/types'
 import {
   campaignOutputs,
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   mapCampaign,
 } from '@/tools/emailbison/utils'
@@ -45,7 +45,7 @@ export const updateCampaignStatusTool: ToolConfig<
     headers: emailBisonHeaders,
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'campaign')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/update_lead.ts b/apps/sim/tools/emailbison/update_lead.ts
@@ -1,7 +1,7 @@
 import type { EmailBisonLeadMutationParams, EmailBisonLeadResponse } from '@/tools/emailbison/types'
 import {
-  emailBisonData,
   emailBisonHeaders,
+  emailBisonRecordData,
   emailBisonUrl,
   jsonBody,
   leadOutputs,
@@ -94,7 +94,7 @@ export const updateLeadTool: ToolConfig<EmailBisonLeadMutationParams, EmailBison
       }),
   },
   transformResponse: async (response) => {
-    const data = await emailBisonData<unknown>(response)
+    const data = await emailBisonRecordData(response, 'lead')
 
     return {
       success: true,
diff --git a/apps/sim/tools/emailbison/utils.ts b/apps/sim/tools/emailbison/utils.ts
