address comments

Author: icecrasher321

apps/sim/tools/emailbison/update_campaign_status.ts

@@ -12,6 +12,8 @@ import {
 } from '@/tools/emailbison/utils'
 import type { ToolConfig } from '@/tools/types'
 
+const CAMPAIGN_STATUS_ACTIONS = new Set(['pause', 'resume', 'archive'])
+
 export const updateCampaignStatusTool: ToolConfig<
   EmailBisonCampaignStatusParams,
   EmailBisonCampaignResponse
@@ -36,8 +38,17 @@ export const updateCampaignStatusTool: ToolConfig<
     },
   },
   request: {
-    url: (params) =>
-      emailBisonUrl(`/api/campaigns/${params.campaignId}/${params.action}`, {}, params.apiBaseUrl),
+    url: (params) => {
+      if (!CAMPAIGN_STATUS_ACTIONS.has(params.action)) {
+        throw new Error('Email Bison campaign status action must be pause, resume, or archive')
+      }
+
+      return emailBisonUrl(
+        `/api/campaigns/${params.campaignId}/${params.action}`,
+        {},
+        params.apiBaseUrl
+      )
+    },
     method: 'PATCH',
     headers: emailBisonHeaders,
   },

apps/sim/tools/sharepoint/read_page.ts

@@ -255,7 +255,7 @@ export const readPageTool: ToolConfig<SharepointToolParams, SharepointReadPageRe
 
     const siteId = params?.siteId || params?.siteSelector || 'root'
     const pagesWithContent = []
-    const nextPageUrl = getGraphNextPageUrl(data as unknown as Record<string, unknown>)
+    const nextPageUrl = getGraphNextPageUrl(data)
 
     logger.info('Fetching content for all pages', {
       totalPages: data.value.length,

apps/sim/tools/sharepoint/utils.ts

@@ -13,8 +13,8 @@ export function escapeODataString(value: string): string {
   return value.replace(/'/g, "''")
 }
 
-export function getGraphNextPageUrl(data: Record<string, unknown>): string | undefined {
-  const nextLink = data['@odata.nextLink']
+export function getGraphNextPageUrl(data: object): string | undefined {
+  const nextLink = (data as Record<string, unknown>)['@odata.nextLink']
   return typeof nextLink === 'string' ? nextLink : undefined
 }