Skip to content

Commit 2b1e223

Browse files
committed
improvement(confluence): memoize persisted canonical modes parse
1 parent 73d0c66 commit 2b1e223

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/edit-connector-modal/edit-connector-modal.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,14 @@ export function EditConnectorModal({
136136
const subscriptionAccess = getSubscriptionAccessState(subscriptionResponse?.data)
137137
const hasMaxAccess = !isBillingEnabled || subscriptionAccess.hasUsableMaxAccess
138138

139+
const persistedCanonicalModes = useMemo(
140+
() => readPersistedCanonicalModes(connector.sourceConfig),
141+
[connector.sourceConfig]
142+
)
143+
139144
const hasChanges = useMemo(() => {
140145
if (syncInterval !== connector.syncIntervalMinutes) return true
141-
const persisted = readPersistedCanonicalModes(connector.sourceConfig)
142-
if (didCanonicalModesChange(canonicalModes, persisted)) return true
146+
if (didCanonicalModesChange(canonicalModes, persistedCanonicalModes)) return true
143147
const resolved = resolveSourceConfig()
144148
for (const [key, value] of Object.entries(resolved)) {
145149
if (String(connector.sourceConfig[key] ?? '') !== value) return true
@@ -151,6 +155,7 @@ export function EditConnectorModal({
151155
connector.syncIntervalMinutes,
152156
connector.sourceConfig,
153157
canonicalModes,
158+
persistedCanonicalModes,
154159
])
155160

156161
const handleSave = () => {
@@ -168,8 +173,7 @@ export function EditConnectorModal({
168173
if (String(connector.sourceConfig[key] ?? '') !== value) changedEntries[key] = value
169174
}
170175

171-
const persistedModes = readPersistedCanonicalModes(connector.sourceConfig)
172-
const modesChanged = didCanonicalModesChange(canonicalModes, persistedModes)
176+
const modesChanged = didCanonicalModesChange(canonicalModes, persistedCanonicalModes)
173177

174178
if (Object.keys(changedEntries).length > 0 || modesChanged) {
175179
const next: Record<string, unknown> = { ...connector.sourceConfig, ...changedEntries }

0 commit comments

Comments
 (0)