fix

icecrasher321 · icecrasher321 · commit 175b72899cfb · 2026-01-29T19:28:53.000-08:00
diff --git a/apps/sim/socket/handlers/workflow.ts b/apps/sim/socket/handlers/workflow.ts
@@ -125,8 +125,9 @@ export function setupWorkflowHandlers(socket: AuthenticatedSocket, roomManager:
       )
     } catch (error) {
       logger.error('Error joining workflow:', error)
-      // Undo socket.join if addUserToRoom or subsequent operations failed
+      // Undo socket.join and room manager entry if any operation failed
       socket.leave(workflowId)
+      await roomManager.removeUserFromRoom(socket.id)
       socket.emit('join-workflow-error', { error: 'Failed to join workflow' })
     }
   })

Original file line number	Diff line number	Diff line change
`@@ -125,8 +125,9 @@ export function setupWorkflowHandlers(socket: AuthenticatedSocket, roomManager:`
`125`	`125`	`)`
`126`	`126`	`} catch (error) {`
`127`	`127`	`logger.error('Error joining workflow:', error)`
`128`		`- // Undo socket.join if addUserToRoom or subsequent operations failed`
	`128`	`+ // Undo socket.join and room manager entry if any operation failed`
`129`	`129`	`socket.leave(workflowId)`
	`130`	`+ await roomManager.removeUserFromRoom(socket.id)`
`130`	`131`	`socket.emit('join-workflow-error', { error: 'Failed to join workflow' })`
`131`	`132`	`}`
`132`	`133`	`})`