improvement(block-error-logs): workflow in workflow (#1084)

* improvement(add-block-logs): workflow in workflow

* fix lint

Author: icecrasher321

apps/sim/executor/handlers/workflow/workflow-handler.ts

@@ -118,7 +118,13 @@ export class WorkflowBlockHandler implements BlockHandler {
 
       if ((mappedResult as any).success === false) {
         const childError = (mappedResult as any).error || 'Unknown error'
-        throw new Error(`Error in child workflow "${childWorkflowName}": ${childError}`)
+        const errorWithSpans = new Error(
+          `Error in child workflow "${childWorkflowName}": ${childError}`
+        ) as any
+        // Attach trace spans and name for higher-level logging to consume
+        errorWithSpans.childTraceSpans = childTraceSpans
+        errorWithSpans.childWorkflowName = childWorkflowName
+        throw errorWithSpans
       }
 
       return mappedResult
@@ -306,11 +312,16 @@ export class WorkflowBlockHandler implements BlockHandler {
     const success = childResult.success !== false
     if (!success) {
       logger.warn(`Child workflow ${childWorkflowName} failed`)
-      return {
+      const failure: Record<string, any> = {
         success: false,
         childWorkflowName,
         error: childResult.error || 'Child workflow execution failed',
-      } as Record<string, any>
+      }
+      // Only include spans when present to keep output stable for callers/tests
+      if (Array.isArray(childTraceSpans) && childTraceSpans.length > 0) {
+        failure.childTraceSpans = childTraceSpans
+      }
+      return failure as Record<string, any>
     }
     let result = childResult
     if (childResult?.output) {

apps/sim/executor/index.ts

@@ -1742,6 +1742,11 @@ export class Executor {
       blockLog.durationMs =
         new Date(blockLog.endedAt).getTime() - new Date(blockLog.startedAt).getTime()
 
+      // If this error came from a child workflow execution, persist its trace spans on the log
+      if (block.metadata?.id === BlockType.WORKFLOW) {
+        this.attachChildWorkflowSpansToLog(blockLog, error)
+      }
+
       // Log the error even if we'll continue execution through error path
       context.blockLogs.push(blockLog)
 
@@ -1820,6 +1825,11 @@ export class Executor {
         status: error.status || 500,
       }
 
+      // Preserve child workflow spans on the block state so downstream logging can render them
+      if (block.metadata?.id === BlockType.WORKFLOW) {
+        this.attachChildWorkflowSpansToOutput(errorOutput, error)
+      }
+
       // Set block state with error output
       context.blockStates.set(blockId, {
         output: errorOutput,
@@ -1864,6 +1874,39 @@ export class Executor {
     }
   }
 
+  /**
+   * Copies child workflow trace spans from an error object into a block log.
+   * Ensures consistent structure and avoids duplication of inline guards.
+   */
+  private attachChildWorkflowSpansToLog(blockLog: BlockLog, error: unknown): void {
+    const spans = (
+      error as { childTraceSpans?: TraceSpan[]; childWorkflowName?: string } | null | undefined
+    )?.childTraceSpans
+    if (Array.isArray(spans) && spans.length > 0) {
+      blockLog.output = {
+        ...(blockLog.output || {}),
+        childTraceSpans: spans,
+        childWorkflowName: (error as { childWorkflowName?: string } | null | undefined)
+          ?.childWorkflowName,
+      }
+    }
+  }
+
+  /**
+   * Copies child workflow trace spans from an error object into a normalized output.
+   */
+  private attachChildWorkflowSpansToOutput(output: NormalizedBlockOutput, error: unknown): void {
+    const spans = (
+      error as { childTraceSpans?: TraceSpan[]; childWorkflowName?: string } | null | undefined
+    )?.childTraceSpans
+    if (Array.isArray(spans) && spans.length > 0) {
+      output.childTraceSpans = spans
+      output.childWorkflowName = (
+        error as { childWorkflowName?: string } | null | undefined
+      )?.childWorkflowName
+    }
+  }
+
   /**
    * Activates error paths from a block that had an error.
    * Checks for connections from the block's "error" handle and adds them to the active execution path.

apps/sim/executor/types.ts

@@ -1,3 +1,4 @@
+import type { TraceSpan } from '@/lib/logs/types'
 import type { BlockOutput } from '@/blocks/types'
 import type { SerializedBlock, SerializedWorkflow } from '@/serializer/types'
 
@@ -52,6 +53,9 @@ export interface NormalizedBlockOutput {
   headers?: Record<string, string> // HTTP headers
   // Error handling
   error?: string // Error message if block execution failed
+  // Child workflow introspection (for workflow blocks)
+  childTraceSpans?: TraceSpan[]
+  childWorkflowName?: string
 }
 
 /**

apps/sim/lib/logs/execution/trace-spans/trace-spans.ts

@@ -56,9 +56,15 @@ export function buildTraceSpans(result: ExecutionResult): {
       }
     }
 
+    // Prefer human-friendly workflow block naming if provided by child execution mapping
+    const displayName =
+      log.blockType === 'workflow' && log.output?.childWorkflowName
+        ? `${log.output.childWorkflowName} workflow`
+        : log.blockName || log.blockId
+
     const span: TraceSpan = {
       id: spanId,
-      name: log.blockName || log.blockId,
+      name: displayName,
       type: log.blockType,
       duration: duration,
       startTime: log.startedAt,