fix tests

Author: icecrasher321

apps/sim/executor/utils/block-data.ts

@@ -35,7 +35,8 @@ function getInputFormatFields(block: SerializedBlock): OutputSchema {
 
   const schema: OutputSchema = {}
   for (const field of inputFormat) {
-    schema[field.name!] = {
+    if (!field.name) continue
+    schema[field.name] = {
       type: (field.type || 'any') as 'string' | 'number' | 'boolean' | 'object' | 'array' | 'any',
     }
   }

apps/sim/lib/workflows/comparison/compare.test.ts

@@ -557,7 +557,8 @@ describe('hasWorkflowChanged', () => {
   })
 
   describe('InputFormat SubBlock Special Handling', () => {
-    it.concurrent('should ignore value and collapsed fields in inputFormat', () => {
+    it.concurrent('should ignore collapsed field but detect value changes in inputFormat', () => {
+      // Only collapsed changes - should NOT detect as change
       const state1 = createWorkflowState({
         blocks: {
           block1: createBlock('block1', {
@@ -578,8 +579,8 @@ describe('hasWorkflowChanged', () => {
             subBlocks: {
               inputFormat: {
                 value: [
-                  { id: 'input1', name: 'Name', value: 'Jane', collapsed: false },
-                  { id: 'input2', name: 'Age', value: 30, collapsed: true },
+                  { id: 'input1', name: 'Name', value: 'John', collapsed: false },
+                  { id: 'input2', name: 'Age', value: 25, collapsed: true },
                 ],
               },
             },
@@ -589,6 +590,32 @@ describe('hasWorkflowChanged', () => {
       expect(hasWorkflowChanged(state1, state2)).toBe(false)
     })
 
+    it.concurrent('should detect value changes in inputFormat', () => {
+      const state1 = createWorkflowState({
+        blocks: {
+          block1: createBlock('block1', {
+            subBlocks: {
+              inputFormat: {
+                value: [{ id: 'input1', name: 'Name', value: 'John' }],
+              },
+            },
+          }),
+        },
+      })
+      const state2 = createWorkflowState({
+        blocks: {
+          block1: createBlock('block1', {
+            subBlocks: {
+              inputFormat: {
+                value: [{ id: 'input1', name: 'Name', value: 'Jane' }],
+              },
+            },
+          }),
+        },
+      })
+      expect(hasWorkflowChanged(state1, state2)).toBe(true)
+    })
+
     it.concurrent('should detect actual inputFormat changes', () => {
       const state1 = createWorkflowState({
         blocks: {
@@ -1712,15 +1739,15 @@ describe('hasWorkflowChanged', () => {
   })
 
   describe('Input Format Field Scenarios', () => {
-    it.concurrent('should not detect change when inputFormat value is typed and cleared', () => {
-      // The "value" field in inputFormat is UI-only and should be ignored
+    it.concurrent('should not detect change when only inputFormat collapsed changes', () => {
+      // The "collapsed" field in inputFormat is UI-only and should be ignored
       const deployedState = createWorkflowState({
         blocks: {
           block1: createBlock('block1', {
             subBlocks: {
               inputFormat: {
                 value: [
-                  { id: 'field1', name: 'Name', type: 'string', value: '', collapsed: false },
+                  { id: 'field1', name: 'Name', type: 'string', value: 'test', collapsed: false },
                 ],
               },
             },
@@ -1738,7 +1765,7 @@ describe('hasWorkflowChanged', () => {
                     id: 'field1',
                     name: 'Name',
                     type: 'string',
-                    value: 'typed then cleared',
+                    value: 'test',
                     collapsed: true,
                   },
                 ],
@@ -1748,10 +1775,40 @@ describe('hasWorkflowChanged', () => {
         },
       })
 
-      // value and collapsed are UI-only fields - should NOT detect as change
+      // collapsed is UI-only field - should NOT detect as change
       expect(hasWorkflowChanged(currentState, deployedState)).toBe(false)
     })
 
+    it.concurrent('should detect change when inputFormat value changes', () => {
+      // The "value" field in inputFormat is meaningful and should trigger change detection
+      const deployedState = createWorkflowState({
+        blocks: {
+          block1: createBlock('block1', {
+            subBlocks: {
+              inputFormat: {
+                value: [{ id: 'field1', name: 'Name', type: 'string', value: '' }],
+              },
+            },
+          }),
+        },
+      })
+
+      const currentState = createWorkflowState({
+        blocks: {
+          block1: createBlock('block1', {
+            subBlocks: {
+              inputFormat: {
+                value: [{ id: 'field1', name: 'Name', type: 'string', value: 'new value' }],
+              },
+            },
+          }),
+        },
+      })
+
+      // value changes should be detected
+      expect(hasWorkflowChanged(currentState, deployedState)).toBe(true)
+    })
+
     it.concurrent('should detect change when inputFormat field name changes', () => {
       const deployedState = createWorkflowState({
         blocks: {

apps/sim/lib/workflows/comparison/normalize.test.ts

@@ -370,7 +370,7 @@ describe('Workflow Normalization Utilities', () => {
       expect(sanitizeInputFormat({} as any)).toEqual([])
     })
 
-    it.concurrent('should remove value and collapsed fields', () => {
+    it.concurrent('should remove collapsed field but keep value', () => {
       const inputFormat = [
         { id: 'input1', name: 'Name', value: 'John', collapsed: true },
         { id: 'input2', name: 'Age', value: 25, collapsed: false },
@@ -379,13 +379,13 @@ describe('Workflow Normalization Utilities', () => {
       const result = sanitizeInputFormat(inputFormat)
 
       expect(result).toEqual([
-        { id: 'input1', name: 'Name' },
-        { id: 'input2', name: 'Age' },
+        { id: 'input1', name: 'Name', value: 'John' },
+        { id: 'input2', name: 'Age', value: 25 },
         { id: 'input3', name: 'Email' },
       ])
     })
 
-    it.concurrent('should preserve all other fields', () => {
+    it.concurrent('should preserve all other fields including value', () => {
       const inputFormat = [
         {
           id: 'input1',
@@ -402,6 +402,7 @@ describe('Workflow Normalization Utilities', () => {
       expect(result[0]).toEqual({
         id: 'input1',
         name: 'Complex Input',
+        value: 'test-value',
         type: 'string',
         required: true,
         validation: { min: 0, max: 100 },