From 2e6afaa84fbf606d156f272c09ea70d478bfc866 Mon Sep 17 00:00:00 2001 From: Dario Fazio Date: Thu, 19 Mar 2026 17:12:32 +0100 Subject: [PATCH 1/6] fix(nest-logger): remove faulty array wrapping for logging --- packages/nest-logger/src/model/nest-logger.ts | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/nest-logger/src/model/nest-logger.ts b/packages/nest-logger/src/model/nest-logger.ts index d784ea7f..2e2856c7 100644 --- a/packages/nest-logger/src/model/nest-logger.ts +++ b/packages/nest-logger/src/model/nest-logger.ts @@ -8,23 +8,23 @@ import { Logger } from '@shiftcode/logger' export class NestLogger implements LoggerService { constructor(private readonly logger: Logger) {} - error(message: any, trace?: string) { - this.logger.error([message, trace]) + error(message: any, ...optionalParams: any[]) { + this.logger.error(message, optionalParams) } - warn(message: any) { - this.logger.warn([message]) + warn(message: any, ...optionalParams: any[]) { + this.logger.warn(message, optionalParams) } - debug(message: any) { - this.logger.debug([message]) + debug(message: any, ...optionalParams: any[]) { + this.logger.debug(message, optionalParams) } - verbose(message: any) { - this.debug(message) + verbose(message: any, ...optionalParams: any[]) { + this.debug(message, optionalParams) } - log(message: any) { - this.logger.info([message]) + log(message: any, ...optionalParams: any[]) { + this.logger.info(message, optionalParams) } } From db0521bd04cf0c817a452dc1d1788b0ff268f43b Mon Sep 17 00:00:00 2001 From: Github Actions Date: Thu, 19 Mar 2026 16:19:39 +0000 Subject: [PATCH 2/6] build(release): next version [skip_build] - @shiftcode/nest-logger@1.0.1-pr79.0 --- package-lock.json | 2 +- packages/nest-logger/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 25e334f6..c77dd00d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18773,7 +18773,7 @@ }, "packages/nest-logger": { "name": "@shiftcode/nest-logger", - "version": "1.0.0", + "version": "1.0.1-pr79.0", "license": "MIT", "devDependencies": { "@nestjs/common": "^11.0.0", diff --git a/packages/nest-logger/package.json b/packages/nest-logger/package.json index f5a8098a..2247e1f9 100644 --- a/packages/nest-logger/package.json +++ b/packages/nest-logger/package.json @@ -1,6 +1,6 @@ { "name": "@shiftcode/nest-logger", - "version": "1.0.0", + "version": "1.0.1-pr79.0", "description": "NestJS support for the logger package", "repository": "https://github.com/shiftcode/sc-commons-public", "license": "MIT", From bf0b4069b47c0ec899d575175efb05ebca8eeea4 Mon Sep 17 00:00:00 2001 From: Dario Fazio Date: Thu, 19 Mar 2026 17:21:48 +0100 Subject: [PATCH 3/6] fix(nest-logger): spread optional parameters in logging methods --- packages/nest-logger/src/model/nest-logger.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/nest-logger/src/model/nest-logger.ts b/packages/nest-logger/src/model/nest-logger.ts index 2e2856c7..13ea4051 100644 --- a/packages/nest-logger/src/model/nest-logger.ts +++ b/packages/nest-logger/src/model/nest-logger.ts @@ -9,22 +9,22 @@ export class NestLogger implements LoggerService { constructor(private readonly logger: Logger) {} error(message: any, ...optionalParams: any[]) { - this.logger.error(message, optionalParams) + this.logger.error(message, ...optionalParams) } warn(message: any, ...optionalParams: any[]) { - this.logger.warn(message, optionalParams) + this.logger.warn(message, ...optionalParams) } debug(message: any, ...optionalParams: any[]) { - this.logger.debug(message, optionalParams) + this.logger.debug(message, ...optionalParams) } verbose(message: any, ...optionalParams: any[]) { - this.debug(message, optionalParams) + this.debug(message, ...optionalParams) } log(message: any, ...optionalParams: any[]) { - this.logger.info(message, optionalParams) + this.logger.info(message, ...optionalParams) } } From 6cab1433393dddf7c3a90c8ae454b487edda6c65 Mon Sep 17 00:00:00 2001 From: Github Actions Date: Thu, 19 Mar 2026 16:25:25 +0000 Subject: [PATCH 4/6] build(release): next version [skip_build] - @shiftcode/nest-logger@1.0.1-pr79.1 --- package-lock.json | 2 +- packages/nest-logger/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index c77dd00d..76f0c607 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18773,7 +18773,7 @@ }, "packages/nest-logger": { "name": "@shiftcode/nest-logger", - "version": "1.0.1-pr79.0", + "version": "1.0.1-pr79.1", "license": "MIT", "devDependencies": { "@nestjs/common": "^11.0.0", diff --git a/packages/nest-logger/package.json b/packages/nest-logger/package.json index 2247e1f9..6ba444a5 100644 --- a/packages/nest-logger/package.json +++ b/packages/nest-logger/package.json @@ -1,6 +1,6 @@ { "name": "@shiftcode/nest-logger", - "version": "1.0.1-pr79.0", + "version": "1.0.1-pr79.1", "description": "NestJS support for the logger package", "repository": "https://github.com/shiftcode/sc-commons-public", "license": "MIT", From 12be563502b0a754ea7f59837a6e6cdb5e6eae76 Mon Sep 17 00:00:00 2001 From: Dario Fazio Date: Thu, 19 Mar 2026 18:04:06 +0100 Subject: [PATCH 5/6] fix(nest-logger): add unit tests for NestLogger methods to verify argument forwarding --- .../nest-logger/src/model/nest-logger.spec.ts | 47 +++++++++++++++++++ .../nest-logger/test/mock-log.transport.ts | 10 +++- 2 files changed, 56 insertions(+), 1 deletion(-) create mode 100644 packages/nest-logger/src/model/nest-logger.spec.ts diff --git a/packages/nest-logger/src/model/nest-logger.spec.ts b/packages/nest-logger/src/model/nest-logger.spec.ts new file mode 100644 index 00000000..373ae7ea --- /dev/null +++ b/packages/nest-logger/src/model/nest-logger.spec.ts @@ -0,0 +1,47 @@ +import { Logger, LogLevel } from '@shiftcode/logger' +import { beforeEach, describe, expect, test } from 'vitest' + +import { MockLogTransport } from '../../test/mock-log.transport.js' +import { NestLogger } from './nest-logger.js' + +describe('NestLogger', () => { + let transport: MockLogTransport + let logger: Logger + let nestLogger: NestLogger + + beforeEach(() => { + transport = new MockLogTransport({ logLevel: LogLevel.DEBUG, mockAttribute: 'test' }) + logger = new Logger('TestLogger', '#ffffff', [transport]) + nestLogger = new NestLogger(logger) + }) + + test('error(message, trace, context) forwards args as flat array, not nested', () => { + nestLogger.error('msg', 'trace', 'ctx') + expect(transport.logArgs?.args).toEqual(['msg', 'trace', 'ctx']) + }) + + test('warn(message, context) forwards args as flat array', () => { + nestLogger.warn('msg', 'ctx') + expect(transport.logArgs?.args).toEqual(['msg', 'ctx']) + }) + + test('log(message, context) forwards args as flat array', () => { + nestLogger.log('msg', 'ctx') + expect(transport.logArgs?.args).toEqual(['msg', 'ctx']) + }) + + test('debug(message, context) forwards args as flat array', () => { + nestLogger.debug('msg', 'ctx') + expect(transport.logArgs?.args).toEqual(['msg', 'ctx']) + }) + + test('verbose(message, context) forwards args as flat array', () => { + nestLogger.verbose('msg', 'ctx') + expect(transport.logArgs?.args).toEqual(['msg', 'ctx']) + }) + + test('error with only a message forwards a single-element args array', () => { + nestLogger.error('only message') + expect(transport.logArgs?.args).toEqual(['only message']) + }) +}) diff --git a/packages/nest-logger/test/mock-log.transport.ts b/packages/nest-logger/test/mock-log.transport.ts index 45dbf661..1a08dbe9 100644 --- a/packages/nest-logger/test/mock-log.transport.ts +++ b/packages/nest-logger/test/mock-log.transport.ts @@ -5,8 +5,16 @@ export interface MockLogTransportConfig { mockAttribute: string } +export interface MockLogArgs { + level: LogLevel + clazzName: string + hexColor: string + timestamp: Date + args: unknown[] +} + export class MockLogTransport extends LogTransport { - logArgs: any + logArgs: MockLogArgs | undefined constructor(config: MockLogTransportConfig) { super(config.logLevel) From 6655a3a822cc3898a34413cd6c2f510b532dc0ba Mon Sep 17 00:00:00 2001 From: Github Actions Date: Thu, 19 Mar 2026 17:07:38 +0000 Subject: [PATCH 6/6] build(release): next version [skip_build] - @shiftcode/nest-logger@1.0.1-pr79.2 --- package-lock.json | 2 +- packages/nest-logger/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 76f0c607..55cffd09 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18773,7 +18773,7 @@ }, "packages/nest-logger": { "name": "@shiftcode/nest-logger", - "version": "1.0.1-pr79.1", + "version": "1.0.1-pr79.2", "license": "MIT", "devDependencies": { "@nestjs/common": "^11.0.0", diff --git a/packages/nest-logger/package.json b/packages/nest-logger/package.json index 6ba444a5..565d41ad 100644 --- a/packages/nest-logger/package.json +++ b/packages/nest-logger/package.json @@ -1,6 +1,6 @@ { "name": "@shiftcode/nest-logger", - "version": "1.0.1-pr79.1", + "version": "1.0.1-pr79.2", "description": "NestJS support for the logger package", "repository": "https://github.com/shiftcode/sc-commons-public", "license": "MIT",