Skip to content

Commit 57fb070

Browse files
authored
Fixing flaky scheduler test (#1411)
There was an implicit race condition between the start().join() and the scheduledInstances() Signed-off-by: fjtirado <ftirados@redhat.com>
1 parent cb713b5 commit 57fb070

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

impl/test/src/test/java/io/serverlessworkflow/impl/test/SchedulerTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import io.serverlessworkflow.impl.WorkflowApplication;
2323
import io.serverlessworkflow.impl.WorkflowDefinition;
24+
import io.serverlessworkflow.impl.WorkflowInstance;
2425
import java.io.IOException;
2526
import java.time.Duration;
2627
import java.util.Map;
@@ -48,8 +49,9 @@ static void tearDown() throws IOException {
4849
void testAfter() throws IOException, InterruptedException, ExecutionException {
4950
try (WorkflowDefinition def =
5051
appl.workflowDefinition(readWorkflowFromClasspath("workflows-samples/after-start.yaml"))) {
51-
def.instance(Map.of()).start().join();
52+
WorkflowInstance instance = def.instance(Map.of());
5253
assertThat(def.scheduledInstances()).isEmpty();
54+
instance.start().join();
5355
await()
5456
.pollDelay(Duration.ofMillis(50))
5557
.atMost(Duration.ofMillis(200))

0 commit comments

Comments
 (0)