Skip to content

Commit e530d48

Browse files
author
Inbal Tako
committed
SN-1938 Validate user id
1 parent d526246 commit e530d48

File tree

4 files changed

+26
-88
lines changed

4 files changed

+26
-88
lines changed

securenative/config/configuration_builder.py

Lines changed: 0 additions & 67 deletions
This file was deleted.

securenative/config/configuration_manager.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import os
22
from configparser import ConfigParser
33

4-
from securenative.config.configuration_builder import ConfigurationBuilder
4+
from securenative.config.securenative_options import SecureNativeOptions
55
from securenative.exceptions.securenative_config_exception import SecureNativeConfigException
66

77

@@ -32,10 +32,6 @@ def _get_resource_path(cls, env_name):
3232

3333
return os.environ.get(cls.DEFAULT_CONFIG_FILE)
3434

35-
@staticmethod
36-
def config_builder():
37-
return ConfigurationBuilder.default_config_builder()
38-
3935
@classmethod
4036
def _get_env_or_default(cls, properties, key, default):
4137
if os.environ.get(key):
@@ -46,21 +42,25 @@ def _get_env_or_default(cls, properties, key, default):
4642

4743
@classmethod
4844
def load_config(cls, resource_path):
49-
options = ConfigurationBuilder().get_default_securenative_options()
45+
options = SecureNativeOptions()
5046

5147
if not resource_path:
5248
resource_path = os.environ.get(cls.CUSTOM_CONFIG_FILE_ENV_NAME)
5349

5450
properties = cls.read_resource_file(resource_path)
5551

56-
return ConfigurationBuilder(). \
57-
with_api_key(cls._get_env_or_default(properties, "SECURENATIVE_API_KEY", options.api_key)). \
58-
with_api_url(cls._get_env_or_default(properties, "SECURENATIVE_API_URL", options.api_url)). \
59-
with_interval(cls._get_env_or_default(properties, "SECURENATIVE_INTERVAL", options.interval)). \
60-
with_max_events(cls._get_env_or_default(properties, "SECURENATIVE_MAX_EVENTS", options.max_events)). \
61-
with_timeout(cls._get_env_or_default(properties, "SECURENATIVE_TIMEOUT", options.timeout)). \
62-
with_auto_send(cls._get_env_or_default(properties, "SECURENATIVE_AUTO_SEND", options.auto_send)). \
63-
with_disable(cls._get_env_or_default(properties, "SECURENATIVE_DISABLE", options.disable)). \
64-
with_log_level(cls._get_env_or_default(properties, "SECURENATIVE_LOG_LEVEL", options.log_level)). \
65-
with_fail_over_strategy(cls._get_env_or_default(
66-
properties, "SECURENATIVE_FAILOVER_STRATEGY", options.fail_over_strategy))
52+
return SecureNativeOptions(api_key=cls._get_env_or_default(properties, "SECURENATIVE_API_KEY", options.api_key),
53+
api_url=cls._get_env_or_default(properties, "SECURENATIVE_API_URL", options.api_url),
54+
interval=cls._get_env_or_default(properties, "SECURENATIVE_INTERVAL",
55+
options.interval),
56+
max_events=cls._get_env_or_default(properties, "SECURENATIVE_MAX_EVENTS",
57+
options.max_events),
58+
timeout=cls._get_env_or_default(properties, "SECURENATIVE_TIMEOUT", options.timeout),
59+
auto_send=cls._get_env_or_default(properties, "SECURENATIVE_AUTO_SEND",
60+
options.auto_send),
61+
disable=cls._get_env_or_default(properties, "SECURENATIVE_DISABLE", options.disable),
62+
log_level=cls._get_env_or_default(properties, "SECURENATIVE_LOG_LEVEL",
63+
options.log_level),
64+
fail_over_strategy=cls._get_env_or_default(properties,
65+
"SECURENATIVE_FAILOVER_STRATEGY",
66+
options.fail_over_strategy))

securenative/config/securenative_options.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ class SecureNativeOptions(object):
66
def __init__(self, api_key=None, api_url="https://api.securenative.com/collector/api/v1", interval=1000,
77
max_events=1000, timeout=1500, auto_send=True, disable=False, log_level="CRITICAL",
88
fail_over_strategy=FailOverStrategy.FAIL_OPEN.value):
9+
10+
if fail_over_strategy != FailOverStrategy.FAIL_OPEN.value and \
11+
fail_over_strategy != FailOverStrategy.FAIL_CLOSED.value:
12+
self.fail_over_strategy = FailOverStrategy.FAIL_OPEN.value
13+
else:
14+
self.fail_over_strategy = fail_over_strategy
15+
916
self.api_key = api_key
1017
self.api_url = api_url
1118
self.interval = interval
@@ -14,4 +21,3 @@ def __init__(self, api_key=None, api_url="https://api.securenative.com/collector
1421
self.auto_send = auto_send
1522
self.disable = disable
1623
self.log_level = log_level
17-
self.fail_over_strategy = fail_over_strategy

securenative/securenative.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from securenative.api_manager import ApiManager
2-
from securenative.config.configuration_builder import ConfigurationBuilder
32
from securenative.config.configuration_manager import ConfigurationManager
3+
from securenative.config.securenative_options import SecureNativeOptions
44
from securenative.event_manager import EventManager
55
from securenative.exceptions.securenative_config_exception import SecureNativeConfigException
66
from securenative.exceptions.securenative_sdk_Illegal_state_exception import SecureNativeSDKIllegalStateException
@@ -44,8 +44,7 @@ def init_with_api_key(cls, api_key):
4444
raise SecureNativeConfigException("You must pass your SecureNative api key")
4545

4646
if cls._securenative is None:
47-
builder = ConfigurationBuilder().default_config_builder()
48-
options = builder.with_api_key(api_key)
47+
options = SecureNativeOptions(api_key=api_key)
4948
cls._securenative = SecureNative(options)
5049
return cls._securenative
5150
else:

0 commit comments

Comments
 (0)