#36 Extract exception for missingproxy config in own file forbetter readability

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/http/MissingProxyConfigValue.java

@@ -0,0 +1,12 @@
+package io.securecodebox.persistence.defectdojo.http;
+
+import lombok.NonNull;
+
+/**
+ * This exception indicates a missing proxy config value
+ */
+public final class MissingProxyConfigValue extends RuntimeException {
+    MissingProxyConfigValue(@NonNull final ProxyConfigNames name) {
+        super(String.format("Expected system property '%s' not set!", name.getLiterat()));
+    }
+}

src/main/java/io/securecodebox/persistence/defectdojo/http/ProxyConfigFactory.java

@@ -68,12 +68,4 @@ private String getProperty(@NonNull final ProxyConfigNames name) {
         }
     }
 
-    /**
-     * This exception indicates a missing proxy config value
-     */
-    final static class MissingProxyConfigValue extends RuntimeException {
-        MissingProxyConfigValue(ProxyConfigNames name) {
-            super(String.format("Expected System property '%s' not set!", name.getLiterat()));
-        }
-    }
 }

src/test/java/io/securecodebox/persistence/defectdojo/http/MissingProxyConfigValueTest.java

@@ -0,0 +1,19 @@
+package io.securecodebox.persistence.defectdojo.http;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.*;
+
+/**
+ * Tests for {@link MissingProxyConfigValue}
+ */
+class MissingProxyConfigValueTest {
+    @Test
+    void rendersMessageFromProxyConfigName() {
+        final var sut = new MissingProxyConfigValue(ProxyConfigNames.HTTP_PROXY_HOST);
+
+        assertThat(sut.getMessage(), is("Expected system property 'http.proxyHost' not set!"));
+    }
+}

src/test/java/io/securecodebox/persistence/defectdojo/http/ProxyConfigFactoryTest.java

@@ -7,7 +7,7 @@
 import uk.org.webcompere.systemstubs.properties.SystemProperties;
 
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.*;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 /**
@@ -27,10 +27,10 @@ void create_throesExceptionIfUserNotSet() {
         System.setProperty(ProxyConfigNames.HTTP_PROXY_PORT.getLiterat(), "4242");
 
         final var thrown = assertThrows(
-            ProxyConfigFactory.MissingProxyConfigValue.class,
+            MissingProxyConfigValue.class,
             sut::create);
 
-        assertThat(thrown.getMessage(), is("Expected System property 'http.proxyUser' not set!"));
+        assertThat(thrown.getMessage(), containsString("'http.proxyUser'"));
     }
 
     @Test
@@ -41,10 +41,10 @@ void create_throesExceptionIfPasswordNotSet() {
         System.setProperty(ProxyConfigNames.HTTP_PROXY_PORT.getLiterat(), "4242");
 
         final var thrown = assertThrows(
-            ProxyConfigFactory.MissingProxyConfigValue.class,
+            MissingProxyConfigValue.class,
             sut::create);
 
-        assertThat(thrown.getMessage(), is("Expected System property 'http.proxyPassword' not set!"));
+        assertThat(thrown.getMessage(), containsString("'http.proxyPassword'"));
     }
 
     @Test
@@ -55,10 +55,10 @@ void create_throesExceptionIfHostNotSet() {
         System.setProperty(ProxyConfigNames.HTTP_PROXY_PORT.getLiterat(), "4242");
 
         final var thrown = assertThrows(
-            ProxyConfigFactory.MissingProxyConfigValue.class,
+            MissingProxyConfigValue.class,
             sut::create);
 
-        assertThat(thrown.getMessage(), is("Expected System property 'http.proxyHost' not set!"));
+        assertThat(thrown.getMessage(), containsString("'http.proxyHost'"));
     }
 
     @Test
@@ -69,10 +69,10 @@ void create_throesExceptionIfPortNotSet() {
         System.clearProperty(ProxyConfigNames.HTTP_PROXY_PORT.getLiterat());
 
         final var thrown = assertThrows(
-            ProxyConfigFactory.MissingProxyConfigValue.class,
+            MissingProxyConfigValue.class,
             sut::create);
 
-        assertThat(thrown.getMessage(), is("Expected System property 'http.proxyPort' not set!"));
+        assertThat(thrown.getMessage(), containsString("'http.proxyPort'"));
     }
 
     @Test