#36 Marke methods deprecated which will be removed after code refactoring

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/service/DefaultImportScanService.java

@@ -44,6 +44,7 @@ class DefaultImportScanService implements ImportScanService {
         new FormHttpMessageConverter(),
         new ResourceHttpMessageConverter(),
         new MappingJackson2HttpMessageConverter());
+    @Deprecated
     private final SystemPropertyFinder properties = new SystemPropertyFinder();
     @Getter
     private final String defectDojoUrl;
@@ -230,6 +231,7 @@ ClientHttpRequestFactory createRequestFactoryWithProxyAuthConfig() {
         return factory;
     }
 
+    @Deprecated
     private static class SystemPropertyFinder {
         private boolean hasProperty(@NonNull final ProxyConfigNames name) {
             return System.getProperty(name.getLiterat()) != null;
@@ -244,6 +246,7 @@ private String getProperty(@NonNull final ProxyConfigNames name) {
         }
     }
 
+    @Deprecated
     final static class MissingProxyAuthenticationConfig extends RuntimeException {
         MissingProxyAuthenticationConfig(ProxyConfigNames name) {
             super(String.format("Expected System property '%s' not set!", name.getLiterat()));

src/main/java/io/securecodebox/persistence/defectdojo/service/ImportScanService.java

@@ -62,6 +62,7 @@ class ImportScanResponse {
      * or none of them!
      * </p>
      */
+    @Deprecated
     enum ProxyConfigNames {
         HTTP_PROXY_HOST("http.proxyHost"),
         HTTP_PROXY_PORT("http.proxyPort"),

src/test/java/io/securecodebox/persistence/defectdojo/service/DefaultImportScanServiceTest.java

@@ -107,6 +107,7 @@ void shouldConfigureProxySettings_trueIfUserAndPasswordSet() {
     }
 
     @Test
+    @Deprecated
     void createRequestFactoryWithProxyAuthConfig_throesExceptionIfUserNotSet() {
         System.clearProperty(ProxyConfigNames.HTTP_PROXY_USER.getLiterat());
         System.setProperty(ProxyConfigNames.HTTP_PROXY_PASSWORD.getLiterat(), "password");
@@ -121,6 +122,7 @@ void createRequestFactoryWithProxyAuthConfig_throesExceptionIfUserNotSet() {
     }
 
     @Test
+    @Deprecated
     void createRequestFactoryWithProxyAuthConfig_throesExceptionIfPasswordNotSet() {
         System.setProperty(ProxyConfigNames.HTTP_PROXY_USER.getLiterat(), "user");
         System.clearProperty(ProxyConfigNames.HTTP_PROXY_PASSWORD.getLiterat());
@@ -135,6 +137,7 @@ void createRequestFactoryWithProxyAuthConfig_throesExceptionIfPasswordNotSet() {
     }
 
     @Test
+    @Deprecated
     void createRequestFactoryWithProxyAuthConfig_throesExceptionIfHostNotSet() {
         System.setProperty(ProxyConfigNames.HTTP_PROXY_USER.getLiterat(), "user");
         System.setProperty(ProxyConfigNames.HTTP_PROXY_PASSWORD.getLiterat(), "password");
@@ -149,6 +152,7 @@ void createRequestFactoryWithProxyAuthConfig_throesExceptionIfHostNotSet() {
     }
 
     @Test
+    @Deprecated
     void createRequestFactoryWithProxyAuthConfig_throesExceptionIfPortNotSet() {
         System.setProperty(ProxyConfigNames.HTTP_PROXY_USER.getLiterat(), "user");
         System.setProperty(ProxyConfigNames.HTTP_PROXY_PASSWORD.getLiterat(), "password");
@@ -163,6 +167,7 @@ void createRequestFactoryWithProxyAuthConfig_throesExceptionIfPortNotSet() {
     }
 
     @Test
+    @Deprecated
     void createRequestFactoryWithProxyAuthConfig_throesExceptionIfPortIsNotInteger() {
         System.setProperty(ProxyConfigNames.HTTP_PROXY_USER.getLiterat(), "user");
         System.setProperty(ProxyConfigNames.HTTP_PROXY_PASSWORD.getLiterat(), "password");