fixed tests

Author: timtreis

src/spatialdata_plot/pl/utils.py

@@ -425,8 +425,10 @@ def _as_rgba_array(x: Any) -> np.ndarray:
             fill_c[is_num] = cmap(used_norm(num[is_num]))
 
         # non-numeric entries as explicit colors
-        if (~is_num).any():
-            fill_c[~is_num] = ColorConverter().to_rgba_array(c_series[~is_num].tolist())
+        # treat missing values as na_color, and only convert valid color-like entries
+        non_numeric_mask = (~is_num) & c_series.notna()
+        if non_numeric_mask.any():
+            fill_c[non_numeric_mask] = ColorConverter().to_rgba_array(c_series[non_numeric_mask].tolist())
 
     # Case C: single color or list of color-like specs (strings or tuples)
     else:

tests/_images/Labels_respects_custom_colors_from_uns.png

@@ -619,6 +619,8 @@ def test_plot_can_annotate_shapes_with_table_layer(self, sdata_blobs: SpatialDat
 
     def test_plot_respects_custom_colors_from_uns(self, sdata_blobs: SpatialData):
         shapes_name = "blobs_polygons"
+        # Ensure that the table annotations point to the shapes element
+        sdata_blobs["table"].obs["region"] = pd.Categorical([shapes_name] * sdata_blobs["table"].n_obs)
         sdata_blobs.set_table_annotates_spatialelement("table", region=shapes_name)
 
         categories = get_standard_RNG().choice(["a", "b", "c"], size=sdata_blobs["table"].n_obs)
@@ -631,6 +633,8 @@ def test_plot_respects_custom_colors_from_uns(self, sdata_blobs: SpatialData):
 
     def test_plot_respects_custom_colors_from_uns_dict(self, sdata_blobs: SpatialData):
         shapes_name = "blobs_polygons"
+        # Ensure that the table annotations point to the shapes element
+        sdata_blobs["table"].obs["region"] = pd.Categorical([shapes_name] * sdata_blobs["table"].n_obs)
         sdata_blobs.set_table_annotates_spatialelement("table", region=shapes_name)
 
         categories = get_standard_RNG().choice(["a", "b", "c"], size=sdata_blobs["table"].n_obs)