fix: moran's calculation parallelization#4148
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4148 +/- ##
==========================================
+ Coverage 79.59% 79.61% +0.02%
==========================================
Files 120 120
Lines 12786 12786
==========================================
+ Hits 10177 10180 +3
+ Misses 2609 2606 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
At this point, I think this may just be worth reporting upstream to |
c1f7f7a to
02d5793
Compare
ilan-gold
added a commit
that referenced
this pull request
Jun 9, 2026
…ization) (#4149) Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was getting the following beginning with
numba>=0.66rc1:Details
=================================== FAILURES =================================== __________________ test_consistency[morans_i-single-threaded] __________________ [gw1] linux -- Python 3.14.5 /home/runner/.local/share/hatch/env/virtual/scanpy/B9PcT7QG/hatch-test.pre/bin/python3metric = <function morans_i at 0x7fae9eda6140>
E AssertionError:
E Not equal to tolerance rtol=1e-09, atol=0
E
E Mismatched elements: 1 / 1 (100%)
E Max absolute difference among violations: 7.9750179849e-08
E Max relative difference among violations: 1.8702209022e-07
E ACTUAL: array(0.426421)
E DESIRED: array(0.426421)
tests/test_metrics.py:72: AssertionError
__________________ test_consistency[morans_i-multi-threaded] ___________________
[gw1] linux -- Python 3.14.5 /home/runner/.local/share/hatch/env/virtual/scanpy/B9PcT7QG/hatch-test.pre/bin/python3
data[i] -= regressor[i] @ coeff
tests/test_scaling.py::test_scale[mask-center-int64-array-csc_matrix]
tests/test_scaling.py::test_scale[mask-center-int64-anndata-csc_matrix]
tests/test_scaling.py::test_scale[mask-center-float32-anndata-csc_matrix]
tests/test_scaling.py::test_scale[mask-center-float32-array-csc_matrix]
/home/runner/.local/share/hatch/env/virtual/scanpy/B9PcT7QG/hatch-test.pre/lib/python3.14/site-packages/scipy/sparse/_index.py:216: SparseEfficiencyWarning: Changing the sparsity structure of a csc_matrix is expensive. lil and dok are more efficient.
self._set_arrayXarray(i, j, x)
tests/test_scaling.py::test_scale[mask-center-int64-anndata-csr_matrix]
tests/test_scaling.py::test_scale[mask-center-float32-array-csr_matrix]
tests/test_scaling.py::test_scale[mask-center-float32-anndata-csr_matrix]
tests/test_scaling.py::test_scale[mask-center-int64-array-csr_matrix]
/home/runner/.local/share/hatch/env/virtual/scanpy/B9PcT7QG/hatch-test.pre/lib/python3.14/site-packages/scipy/sparse/_index.py:216: SparseEfficiencyWarning: Changing the sparsity structure of a csr_matrix is expensive. lil and dok are more efficient.
self._set_arrayXarray(i, j, x)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_metrics.py::test_consistency[morans_i-single-threaded] - AssertionError:
Not equal to tolerance rtol=1e-09, atol=0
Mismatched elements: 1 / 1 (100%)
Max absolute difference among violations: 7.9750179849e-08
Max relative difference among violations: 1.8702209022e-07
ACTUAL: array(0.426421)
DESIRED: array(0.426421)
FAILED tests/test_metrics.py::test_consistency[morans_i-multi-threaded] - AssertionError:
Not equal to tolerance rtol=1e-09, atol=0
Mismatched elements: 1 / 1 (100%)
Max absolute difference among violations: 7.9750179849e-08
Max relative difference among violations: 1.8702209022e-07
ACTUAL: array(0.426421)
DESIRED: array(0.426421)
and suspect this could be the cause