Skip to content

Commit 6ec293a

Browse files
committed
html-report: fix bug with erroneous None action
I wanted to make it so that timestamp overrides automatically set the action to None, so that maintainers could decide to postpone updating to newly released versions. This is useful when major a new release lands for a third-party component, since there is often not time immediately to upgrade the entire SciJava component collection to use that release. Unfortunately, the logic was too general: components with no activity outside a 24-hour window of their last release were erroneously flagged with None action. We only want to override the action when the vetting was done manually as a timestamp override.
1 parent e96fc2a commit 6ec293a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

html-report.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,9 @@ do
122122
releaseOK=$checkMark
123123
fi
124124

125-
if [ "$((lastUpdated-lastVetted))" -lt 0 ]
125+
if [ "$((lastUpdated-timestampOverride))" -lt 0 ]
126126
then
127-
# NB: Last vetted more recently than last update; no bump needed.
127+
# NB: Manually vetted more recently than last update; no bump needed.
128128
bomStatus="bom-ok"
129129
bomOK=$checkMark
130130
fi

0 commit comments

Comments
 (0)