Skip to content

Commit e4fcbd6

Browse files
committed
SwingSearchBar: remove todo about URL for icons
Maybe I'll regret it later. But using String is working fine. The expectation is that people will ship icons with their plugins. If they were to use a remote URL instead, it would just make the search UI depend on the Internet gratuitously, which I'd rather not encourage.
1 parent c97ddb6 commit e4fcbd6

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/main/java/org/scijava/ui/swing/search/SwingSearchBar.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -671,7 +671,6 @@ private void rebuild() {
671671
}
672672

673673
private Component icon(final String iconPath) {
674-
// TODO make icon() return URL, not String.
675674
if (iconPath == null || iconPath.isEmpty()) return emptyIcon();
676675
final URL iconURL = getClass().getResource(iconPath);
677676
if (iconURL == null) return emptyIcon();

0 commit comments

Comments
 (0)