Skip to content

Commit be88a57

Browse files
committed
Merge branch 'quickfix-additional-archs'
This fixes some erroneous detection of artifacts as duplicates, when really they have different classifiers. Closes joheras/IJ-OpenCV#13.
2 parents a5cc397 + 8f57693 commit be88a57

File tree

3 files changed

+24
-3
lines changed

3 files changed

+24
-3
lines changed

src/it/do-not-delete-natives/setup.bsh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,14 @@ source(new File(basedir, "../../../src/it/lib.bsh").getPath());
3232

3333
if (!plugins.exists()) plugins.mkdirs();
3434
touchFile(new File(plugins, "Example_PlugIn-0.9.0-natives-linux.jar"));
35+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-android-arm.jar"));
36+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-android-arm64.jar"));
37+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-android-x86.jar"));
38+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-android-x86_64.jar"));
39+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-linux-x86.jar"));
40+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-linux-x86_64.jar"));
41+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-linux-armhf.jar"));
42+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-linux-ppc64le.jar"));
43+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-macosx-x86_64.jar"));
44+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-windows-x86.jar"));
45+
touchFile(new File(plugins, "Example_PlugIn-0.9.0-windows-x86_64.jar"));

src/it/do-not-delete-natives/verify.bsh

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,15 @@
3131
source(new File(basedir, "../../../src/it/lib.bsh").getPath());
3232

3333
assertTrue("Should exist: " + plugin, plugin.exists());
34-
natives = new File(plugins, "Example_PlugIn-0.9.0-natives-linux.jar");
35-
assertTrue("Should exist: " + natives, natives.exists());
34+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-natives-linux.jar"), new File(plugins, "Example_PlugIn-0.9.0-natives-linux.jar").exists());
35+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-android-arm.jar"), new File(plugins, "Example_PlugIn-0.9.0-android-arm.jar").exists());
36+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-android-arm64.jar"), new File(plugins, "Example_PlugIn-0.9.0-android-arm64.jar").exists());
37+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-android-x86.jar"), new File(plugins, "Example_PlugIn-0.9.0-android-x86.jar").exists());
38+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-android-x86_64.jar"), new File(plugins, "Example_PlugIn-0.9.0-android-x86_64.jar").exists());
39+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-linux-x86.jar"), new File(plugins, "Example_PlugIn-0.9.0-linux-x86.jar").exists());
40+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-linux-x86_64.jar"), new File(plugins, "Example_PlugIn-0.9.0-linux-x86_64.jar").exists());
41+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-linux-armhf.jar"), new File(plugins, "Example_PlugIn-0.9.0-linux-armhf.jar").exists());
42+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-linux-ppc64le.jar"), new File(plugins, "Example_PlugIn-0.9.0-linux-ppc64le.jar").exists());
43+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-macosx-x86_64.jar"), new File(plugins, "Example_PlugIn-0.9.0-macosx-x86_64.jar").exists());
44+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-windows-x86.jar"), new File(plugins, "Example_PlugIn-0.9.0-windows-x86.jar").exists());
45+
assertTrue("Should exist: " + new File(plugins, "Example_PlugIn-0.9.0-windows-x86_64.jar"), new File(plugins, "Example_PlugIn-0.9.0-windows-x86_64.jar").exists());

src/main/java/org/scijava/maven/plugin/install/AbstractCopyJarsMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ private static boolean isIJ1Plugin(final File file) {
439439

440440
private final static Pattern versionPattern = Pattern.compile("(.+?)"
441441
+ "(-\\d+(\\.\\d+|\\d{7})+[a-z]?\\d?(-[A-Za-z0-9.]+?|\\.GA)*?)?"
442-
+ "((-(swing|swt|sources|javadoc|native|linux-x86|linux-x86_64|macosx-x86_64|windows-x86|windows-x86_64|android-arm|android-x86|natives-windows|natives-macos|natives-linux))?(\\.jar(-[a-z]*)?))");
442+
+ "((-(swing|swt|sources|javadoc|native|linux-x86|linux-x86_64|linux-armhf|linux-ppc64le|macosx-x86_64|windows-x86|windows-x86_64|android-x86|android-x86_64|android-arm|android-arm64|ios-x86_64|ios-arm64|natives-windows|natives-macos|natives-linux))?(\\.jar(-[a-z]*)?))");
443443
private final static int PREFIX_INDEX = 1;
444444
private final static int VERSION_INDEX = 2;
445445
private final static int SUFFIX_INDEX = 5;

0 commit comments

Comments
 (0)