Skip to content

Commit b4aea0e

Browse files
author
Ben Romberg
committed
ignore \r in expected output for IntegrationTest
1 parent 3b790aa commit b4aea0e

File tree

2 files changed

+117
-112
lines changed

2 files changed

+117
-112
lines changed

src/test/java/de/andrena/tools/nopackagecycles/NoPackageCyclesRuleIntegrationTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import static org.junit.Assert.fail;
55

66
import java.io.File;
7+
import java.io.IOException;
78
import java.net.URL;
89

910
import org.apache.commons.io.IOUtils;
@@ -39,7 +40,11 @@ public void integrationTest() throws Exception {
3940
rule.execute(helper);
4041
fail("expected EnforcerRuleException");
4142
} catch (EnforcerRuleException e) {
42-
assertEquals(IOUtils.toString(EXPECTED_OUTPUT.openStream()), e.getMessage());
43+
assertEquals(getExpectedOutput(), e.getMessage());
4344
}
4445
}
46+
47+
private String getExpectedOutput() throws IOException {
48+
return IOUtils.toString(EXPECTED_OUTPUT.openStream()).replaceAll("\r", "");
49+
}
4550
}
Lines changed: 111 additions & 111 deletions
Original file line numberDiff line numberDiff line change
@@ -1,112 +1,112 @@
1-
There are package cycles:
2-
3-
Package-cycle found involving junit.extensions, junit.framework, junit.runner, org.junit, org.junit.experimental.theories, org.junit.experimental.theories.internal, org.junit.internal, org.junit.internal.builders, org.junit.internal.matchers, org.junit.internal.requests, org.junit.internal.runners, org.junit.internal.runners.model, org.junit.internal.runners.rules, org.junit.internal.runners.statements, org.junit.matchers, org.junit.rules, org.junit.runner, org.junit.runner.manipulation, org.junit.runner.notification, org.junit.runners, org.junit.runners.model:
4-
junit.extensions depends on:
5-
junit.framework (ActiveTestSuite, ActiveTestSuite$1, RepeatedTest, TestDecorator, TestSetup, TestSetup$1)
6-
junit.framework depends on:
7-
org.junit (JUnit4TestAdapter)
8-
org.junit.internal (TestSuite)
9-
org.junit.runner (JUnit4TestAdapter, JUnit4TestAdapterCache, JUnit4TestAdapterCache$1, JUnit4TestCaseFacade)
10-
org.junit.runner.manipulation (JUnit4TestAdapter)
11-
org.junit.runner.notification (JUnit4TestAdapterCache, JUnit4TestAdapterCache$1)
12-
junit.runner depends on:
13-
junit.framework (BaseTestRunner)
14-
org.junit depends on:
15-
org.junit.internal (Assert, Assume)
16-
org.junit.runners (FixMethodOrder)
17-
org.junit.experimental.theories depends on:
18-
org.junit (Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$2)
19-
org.junit.experimental.theories.internal (Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$1$1, Theories$TheoryAnchor$2)
20-
org.junit.internal (Theories$TheoryAnchor, Theories$TheoryAnchor$1$1)
21-
org.junit.runners (Theories, Theories$TheoryAnchor$1)
22-
org.junit.runners.model (Theories, Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$1$1, Theories$TheoryAnchor$2)
23-
org.junit.experimental.theories.internal depends on:
24-
org.junit (AllMembersSupplier$MethodParameterValue)
25-
org.junit.experimental.theories (AllMembersSupplier, AllMembersSupplier$MethodParameterValue, Assignments, BooleanSupplier, EnumSupplier, SpecificDataPointsSupplier)
26-
org.junit.runners.model (AllMembersSupplier, AllMembersSupplier$MethodParameterValue, Assignments, SpecificDataPointsSupplier)
27-
org.junit.internal depends on:
28-
org.junit (ComparisonCriteria, ExactComparisonCriteria, InexactComparisonCriteria, MethodSorter)
29-
org.junit.runner (TextListener)
30-
org.junit.runner.notification (TextListener)
31-
org.junit.runners (MethodSorter)
32-
org.junit.internal.builders depends on:
33-
junit.framework (JUnit3Builder)
34-
org.junit (IgnoredBuilder)
35-
org.junit.internal.runners (JUnit3Builder, SuiteMethodBuilder)
36-
org.junit.runner (AllDefaultPossibilitiesBuilder, AnnotatedBuilder, IgnoredBuilder, IgnoredClassRunner, JUnit3Builder, JUnit4Builder, NullBuilder, SuiteMethodBuilder)
37-
org.junit.runner.notification (IgnoredClassRunner)
38-
org.junit.runners (JUnit4Builder)
39-
org.junit.runners.model (AllDefaultPossibilitiesBuilder, AnnotatedBuilder, IgnoredBuilder, JUnit3Builder, JUnit4Builder, NullBuilder, SuiteMethodBuilder)
40-
org.junit.internal.matchers depends on:
41-
org.junit.internal (TypeSafeMatcher)
42-
org.junit.internal.requests depends on:
43-
org.junit.internal.builders (ClassRequest)
44-
org.junit.internal.runners (FilterRequest)
45-
org.junit.runner (ClassRequest, FilterRequest, SortingRequest)
46-
org.junit.runner.manipulation (FilterRequest, SortingRequest)
47-
org.junit.internal.runners depends on:
48-
junit.extensions (JUnit38ClassRunner)
49-
junit.framework (JUnit38ClassRunner, JUnit38ClassRunner$OldTestClassAdaptingListener, SuiteMethod)
50-
org.junit (MethodValidator, TestClass, TestMethod)
51-
org.junit.internal (ClassRoadie, MethodRoadie, TestClass)
52-
org.junit.runner (ClassRoadie, ErrorReportingRunner, JUnit38ClassRunner, JUnit38ClassRunner$OldTestClassAdaptingListener, JUnit4ClassRunner, MethodRoadie)
53-
org.junit.runner.manipulation (JUnit38ClassRunner, JUnit4ClassRunner, JUnit4ClassRunner$2)
54-
org.junit.runner.notification (ClassRoadie, ErrorReportingRunner, JUnit38ClassRunner, JUnit38ClassRunner$OldTestClassAdaptingListener, JUnit4ClassRunner, JUnit4ClassRunner$1, MethodRoadie)
55-
org.junit.runners.model (ErrorReportingRunner)
56-
org.junit.internal.runners.model depends on:
57-
org.junit.internal (EachTestNotifier)
58-
org.junit.runner (EachTestNotifier)
59-
org.junit.runner.notification (EachTestNotifier)
60-
org.junit.runners.model (EachTestNotifier, MultipleFailureException)
61-
org.junit.internal.runners.rules depends on:
62-
org.junit (RuleFieldValidator)
63-
org.junit.rules (RuleFieldValidator)
64-
org.junit.runners.model (RuleFieldValidator)
65-
org.junit.internal.runners.statements depends on:
66-
org.junit.internal (ExpectException)
67-
org.junit.runners.model (ExpectException, Fail, FailOnTimeout, FailOnTimeout$CallableStatement, InvokeMethod, RunAfters, RunBefores)
68-
org.junit.matchers depends on:
69-
org.junit.internal.matchers (JUnitMatchers)
70-
org.junit.rules depends on:
71-
org.junit (ErrorCollector$1, ExpectedException)
72-
org.junit.internal (ExpectedException$ExpectedExceptionStatement, Stopwatch, TestWatcher, TestWatcher$1, TestWatchman$1)
73-
org.junit.internal.matchers (ExpectedException)
74-
org.junit.internal.runners.statements (Timeout)
75-
org.junit.matchers (ExpectedExceptionMatcherBuilder)
76-
org.junit.runner (ExpectedException, ExternalResource, RuleChain, RunRules, Stopwatch, TestName, TestRule, TestWatcher, TestWatcher$1, Timeout, Verifier)
77-
org.junit.runners.model (ErrorCollector, ExpectedException, ExpectedException$ExpectedExceptionStatement, ExternalResource, ExternalResource$1, MethodRule, RuleChain, RunRules, TestRule, TestWatcher, TestWatcher$1, TestWatchman, TestWatchman$1, Timeout, Verifier, Verifier$1)
78-
org.junit.runner depends on:
79-
junit.framework (JUnitCore)
80-
junit.runner (JUnitCore)
81-
org.junit.internal (JUnitCore)
82-
org.junit.internal.builders (Request)
83-
org.junit.internal.requests (Request)
84-
org.junit.internal.runners (JUnitCore, Request)
85-
org.junit.runner.manipulation (Request)
86-
org.junit.runner.notification (JUnitCore, Result, Result$Listener, Runner)
87-
org.junit.runners (Computer)
88-
org.junit.runners.model (Computer, Computer$1, Request)
89-
org.junit.runner.manipulation depends on:
90-
org.junit.runner (Filter, Filter$1, Filter$2, Filter$3, Sorter, Sorter$1)
91-
org.junit.runner.notification depends on:
92-
org.junit.runner (Failure, RunListener, RunNotifier, RunNotifier$1, RunNotifier$2, RunNotifier$3, RunNotifier$6, RunNotifier$7, RunNotifier$SafeNotifier, SynchronizedRunListener)
93-
org.junit.runners depends on:
94-
org.junit (BlockJUnit4ClassRunner, ParentRunner)
95-
org.junit.internal (MethodSorters, ParentRunner)
96-
org.junit.internal.builders (Suite)
97-
org.junit.internal.runners (AllTests)
98-
org.junit.internal.runners.model (BlockJUnit4ClassRunner$1, ParentRunner)
99-
org.junit.internal.runners.rules (BlockJUnit4ClassRunner, ParentRunner)
100-
org.junit.internal.runners.statements (BlockJUnit4ClassRunner, ParentRunner)
101-
org.junit.rules (BlockJUnit4ClassRunner, ParentRunner)
102-
org.junit.runner (BlockJUnit4ClassRunner, Parameterized, ParentRunner, Suite)
103-
org.junit.runner.manipulation (ParentRunner, ParentRunner$4)
104-
org.junit.runner.notification (BlockJUnit4ClassRunner, Parameterized$TestClassRunnerForParameters, ParentRunner, ParentRunner$2, ParentRunner$3, Suite)
105-
org.junit.runners.model (BlockJUnit4ClassRunner, JUnit4, Parameterized, Parameterized$TestClassRunnerForParameters, ParentRunner, ParentRunner$1, ParentRunner$2, Suite)
106-
org.junit.runners.model depends on:
107-
org.junit (TestClass)
108-
org.junit.experimental.theories (FrameworkMethod)
109-
org.junit.internal (TestClass)
110-
org.junit.internal.runners (RunnerBuilder)
111-
org.junit.internal.runners.model (FrameworkMethod$1, MultipleFailureException)
1+
There are package cycles:
2+
3+
Package-cycle found involving junit.extensions, junit.framework, junit.runner, org.junit, org.junit.experimental.theories, org.junit.experimental.theories.internal, org.junit.internal, org.junit.internal.builders, org.junit.internal.matchers, org.junit.internal.requests, org.junit.internal.runners, org.junit.internal.runners.model, org.junit.internal.runners.rules, org.junit.internal.runners.statements, org.junit.matchers, org.junit.rules, org.junit.runner, org.junit.runner.manipulation, org.junit.runner.notification, org.junit.runners, org.junit.runners.model:
4+
junit.extensions depends on:
5+
junit.framework (ActiveTestSuite, ActiveTestSuite$1, RepeatedTest, TestDecorator, TestSetup, TestSetup$1)
6+
junit.framework depends on:
7+
org.junit (JUnit4TestAdapter)
8+
org.junit.internal (TestSuite)
9+
org.junit.runner (JUnit4TestAdapter, JUnit4TestAdapterCache, JUnit4TestAdapterCache$1, JUnit4TestCaseFacade)
10+
org.junit.runner.manipulation (JUnit4TestAdapter)
11+
org.junit.runner.notification (JUnit4TestAdapterCache, JUnit4TestAdapterCache$1)
12+
junit.runner depends on:
13+
junit.framework (BaseTestRunner)
14+
org.junit depends on:
15+
org.junit.internal (Assert, Assume)
16+
org.junit.runners (FixMethodOrder)
17+
org.junit.experimental.theories depends on:
18+
org.junit (Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$2)
19+
org.junit.experimental.theories.internal (Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$1$1, Theories$TheoryAnchor$2)
20+
org.junit.internal (Theories$TheoryAnchor, Theories$TheoryAnchor$1$1)
21+
org.junit.runners (Theories, Theories$TheoryAnchor$1)
22+
org.junit.runners.model (Theories, Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$1$1, Theories$TheoryAnchor$2)
23+
org.junit.experimental.theories.internal depends on:
24+
org.junit (AllMembersSupplier$MethodParameterValue)
25+
org.junit.experimental.theories (AllMembersSupplier, AllMembersSupplier$MethodParameterValue, Assignments, BooleanSupplier, EnumSupplier, SpecificDataPointsSupplier)
26+
org.junit.runners.model (AllMembersSupplier, AllMembersSupplier$MethodParameterValue, Assignments, SpecificDataPointsSupplier)
27+
org.junit.internal depends on:
28+
org.junit (ComparisonCriteria, ExactComparisonCriteria, InexactComparisonCriteria, MethodSorter)
29+
org.junit.runner (TextListener)
30+
org.junit.runner.notification (TextListener)
31+
org.junit.runners (MethodSorter)
32+
org.junit.internal.builders depends on:
33+
junit.framework (JUnit3Builder)
34+
org.junit (IgnoredBuilder)
35+
org.junit.internal.runners (JUnit3Builder, SuiteMethodBuilder)
36+
org.junit.runner (AllDefaultPossibilitiesBuilder, AnnotatedBuilder, IgnoredBuilder, IgnoredClassRunner, JUnit3Builder, JUnit4Builder, NullBuilder, SuiteMethodBuilder)
37+
org.junit.runner.notification (IgnoredClassRunner)
38+
org.junit.runners (JUnit4Builder)
39+
org.junit.runners.model (AllDefaultPossibilitiesBuilder, AnnotatedBuilder, IgnoredBuilder, JUnit3Builder, JUnit4Builder, NullBuilder, SuiteMethodBuilder)
40+
org.junit.internal.matchers depends on:
41+
org.junit.internal (TypeSafeMatcher)
42+
org.junit.internal.requests depends on:
43+
org.junit.internal.builders (ClassRequest)
44+
org.junit.internal.runners (FilterRequest)
45+
org.junit.runner (ClassRequest, FilterRequest, SortingRequest)
46+
org.junit.runner.manipulation (FilterRequest, SortingRequest)
47+
org.junit.internal.runners depends on:
48+
junit.extensions (JUnit38ClassRunner)
49+
junit.framework (JUnit38ClassRunner, JUnit38ClassRunner$OldTestClassAdaptingListener, SuiteMethod)
50+
org.junit (MethodValidator, TestClass, TestMethod)
51+
org.junit.internal (ClassRoadie, MethodRoadie, TestClass)
52+
org.junit.runner (ClassRoadie, ErrorReportingRunner, JUnit38ClassRunner, JUnit38ClassRunner$OldTestClassAdaptingListener, JUnit4ClassRunner, MethodRoadie)
53+
org.junit.runner.manipulation (JUnit38ClassRunner, JUnit4ClassRunner, JUnit4ClassRunner$2)
54+
org.junit.runner.notification (ClassRoadie, ErrorReportingRunner, JUnit38ClassRunner, JUnit38ClassRunner$OldTestClassAdaptingListener, JUnit4ClassRunner, JUnit4ClassRunner$1, MethodRoadie)
55+
org.junit.runners.model (ErrorReportingRunner)
56+
org.junit.internal.runners.model depends on:
57+
org.junit.internal (EachTestNotifier)
58+
org.junit.runner (EachTestNotifier)
59+
org.junit.runner.notification (EachTestNotifier)
60+
org.junit.runners.model (EachTestNotifier, MultipleFailureException)
61+
org.junit.internal.runners.rules depends on:
62+
org.junit (RuleFieldValidator)
63+
org.junit.rules (RuleFieldValidator)
64+
org.junit.runners.model (RuleFieldValidator)
65+
org.junit.internal.runners.statements depends on:
66+
org.junit.internal (ExpectException)
67+
org.junit.runners.model (ExpectException, Fail, FailOnTimeout, FailOnTimeout$CallableStatement, InvokeMethod, RunAfters, RunBefores)
68+
org.junit.matchers depends on:
69+
org.junit.internal.matchers (JUnitMatchers)
70+
org.junit.rules depends on:
71+
org.junit (ErrorCollector$1, ExpectedException)
72+
org.junit.internal (ExpectedException$ExpectedExceptionStatement, Stopwatch, TestWatcher, TestWatcher$1, TestWatchman$1)
73+
org.junit.internal.matchers (ExpectedException)
74+
org.junit.internal.runners.statements (Timeout)
75+
org.junit.matchers (ExpectedExceptionMatcherBuilder)
76+
org.junit.runner (ExpectedException, ExternalResource, RuleChain, RunRules, Stopwatch, TestName, TestRule, TestWatcher, TestWatcher$1, Timeout, Verifier)
77+
org.junit.runners.model (ErrorCollector, ExpectedException, ExpectedException$ExpectedExceptionStatement, ExternalResource, ExternalResource$1, MethodRule, RuleChain, RunRules, TestRule, TestWatcher, TestWatcher$1, TestWatchman, TestWatchman$1, Timeout, Verifier, Verifier$1)
78+
org.junit.runner depends on:
79+
junit.framework (JUnitCore)
80+
junit.runner (JUnitCore)
81+
org.junit.internal (JUnitCore)
82+
org.junit.internal.builders (Request)
83+
org.junit.internal.requests (Request)
84+
org.junit.internal.runners (JUnitCore, Request)
85+
org.junit.runner.manipulation (Request)
86+
org.junit.runner.notification (JUnitCore, Result, Result$Listener, Runner)
87+
org.junit.runners (Computer)
88+
org.junit.runners.model (Computer, Computer$1, Request)
89+
org.junit.runner.manipulation depends on:
90+
org.junit.runner (Filter, Filter$1, Filter$2, Filter$3, Sorter, Sorter$1)
91+
org.junit.runner.notification depends on:
92+
org.junit.runner (Failure, RunListener, RunNotifier, RunNotifier$1, RunNotifier$2, RunNotifier$3, RunNotifier$6, RunNotifier$7, RunNotifier$SafeNotifier, SynchronizedRunListener)
93+
org.junit.runners depends on:
94+
org.junit (BlockJUnit4ClassRunner, ParentRunner)
95+
org.junit.internal (MethodSorters, ParentRunner)
96+
org.junit.internal.builders (Suite)
97+
org.junit.internal.runners (AllTests)
98+
org.junit.internal.runners.model (BlockJUnit4ClassRunner$1, ParentRunner)
99+
org.junit.internal.runners.rules (BlockJUnit4ClassRunner, ParentRunner)
100+
org.junit.internal.runners.statements (BlockJUnit4ClassRunner, ParentRunner)
101+
org.junit.rules (BlockJUnit4ClassRunner, ParentRunner)
102+
org.junit.runner (BlockJUnit4ClassRunner, Parameterized, ParentRunner, Suite)
103+
org.junit.runner.manipulation (ParentRunner, ParentRunner$4)
104+
org.junit.runner.notification (BlockJUnit4ClassRunner, Parameterized$TestClassRunnerForParameters, ParentRunner, ParentRunner$2, ParentRunner$3, Suite)
105+
org.junit.runners.model (BlockJUnit4ClassRunner, JUnit4, Parameterized, Parameterized$TestClassRunnerForParameters, ParentRunner, ParentRunner$1, ParentRunner$2, Suite)
106+
org.junit.runners.model depends on:
107+
org.junit (TestClass)
108+
org.junit.experimental.theories (FrameworkMethod)
109+
org.junit.internal (TestClass)
110+
org.junit.internal.runners (RunnerBuilder)
111+
org.junit.internal.runners.model (FrameworkMethod$1, MultipleFailureException)
112112
org.junit.runner (RunnerBuilder)

0 commit comments

Comments
 (0)