Skip to content

Commit 8fc18a8

Browse files
committed
removed obsolete @SuppressWarnings and casts due to new jdepend library
1 parent cb856b9 commit 8fc18a8

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

src/main/java/de/andrena/tools/nopackagecycles/NoPackageCyclesRule.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ protected JDepend createJDepend() {
5151
}
5252

5353
private String getPackageCycles(JDepend jdepend) {
54-
@SuppressWarnings("unchecked")
5554
Collection<JavaPackage> packages = jdepend.getPackages();
5655
return new PackageCycleOutput(new ArrayList<JavaPackage>(packages)).getOutput();
5756
}

src/main/java/de/andrena/tools/nopackagecycles/PackageCycleCollector.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,27 @@
11
package de.andrena.tools.nopackagecycles;
22

3-
import java.util.Collection;
43
import java.util.Iterator;
54
import java.util.List;
65
import java.util.Set;
76

8-
import jdepend.framework.JavaPackage;
9-
107
import org.jgrapht.DirectedGraph;
118
import org.jgrapht.alg.StrongConnectivityInspector;
129
import org.jgrapht.graph.DefaultDirectedGraph;
1310
import org.jgrapht.graph.DefaultEdge;
1411

12+
import jdepend.framework.JavaPackage;
13+
1514
public class PackageCycleCollector {
1615

1716
public List<Set<JavaPackage>> collectCycles(List<JavaPackage> packages) {
18-
DirectedGraph<JavaPackage, DefaultEdge> graph = new DefaultDirectedGraph<JavaPackage, DefaultEdge>(
19-
DefaultEdge.class);
17+
DirectedGraph<JavaPackage, DefaultEdge> graph = new DefaultDirectedGraph<>(DefaultEdge.class);
2018
addVerticesToGraph(packages, graph);
2119
addEdgesToGraph(packages, graph);
2220
return collectCycles(graph);
2321
}
2422

2523
private List<Set<JavaPackage>> collectCycles(DirectedGraph<JavaPackage, DefaultEdge> graph) {
26-
List<Set<JavaPackage>> stronglyConnectedSets = new StrongConnectivityInspector<JavaPackage, DefaultEdge>(graph)
27-
.stronglyConnectedSets();
24+
List<Set<JavaPackage>> stronglyConnectedSets = new StrongConnectivityInspector<>(graph).stronglyConnectedSets();
2825
removeSingletonSets(stronglyConnectedSets);
2926
return stronglyConnectedSets;
3027
}
@@ -39,10 +36,9 @@ private void removeSingletonSets(List<Set<JavaPackage>> stronglyConnectedSets) {
3936
}
4037
}
4138

42-
@SuppressWarnings("unchecked")
4339
private void addEdgesToGraph(List<JavaPackage> packages, DirectedGraph<JavaPackage, DefaultEdge> graph) {
4440
for (JavaPackage javaPackage : packages) {
45-
for (JavaPackage efferent : (Collection<JavaPackage>) javaPackage.getEfferents()) {
41+
for (JavaPackage efferent : javaPackage.getEfferents()) {
4642
graph.addEdge(javaPackage, efferent);
4743
}
4844
}

src/main/java/de/andrena/tools/nopackagecycles/PackageCycleOutput.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ private void appendOutputForCyclicPackage(final JavaPackage javaPackage, JavaPac
8484

8585
private List<JavaClass> getOrderedDependentClasses(JavaPackage javaPackage, JavaPackage cyclicPackage) {
8686
List<JavaClass> dependentClasses = new ArrayList<JavaClass>();
87-
@SuppressWarnings("unchecked")
8887
Collection<JavaClass> allClasses = javaPackage.getClasses();
8988
for (JavaClass javaClass : allClasses) {
9089
if (javaClass.getImportedPackages().contains(cyclicPackage)) {

0 commit comments

Comments
 (0)