Skip to content

Commit 10285bc

Browse files
committed
fix #11 - updating dependencies for jdepend to a fork supporting java 8
1 parent a080b14 commit 10285bc

File tree

5 files changed

+33
-28
lines changed

5 files changed

+33
-28
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Usage: Add the following plugin to your POM:
1212
<dependency>
1313
<groupId>de.andrena.tools.nopackagecycles</groupId>
1414
<artifactId>no-package-cycles-enforcer-rule</artifactId>
15-
<version>1.0.4</version>
15+
<version>1.0.6</version>
1616
</dependency>
1717
</dependencies>
1818
<executions>

pom.xml

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,12 @@
55
<parent>
66
<groupId>org.sonatype.oss</groupId>
77
<artifactId>oss-parent</artifactId>
8-
<version>7</version>
8+
<version>9</version>
99
</parent>
1010

1111
<groupId>de.andrena.tools.nopackagecycles</groupId>
1212
<artifactId>no-package-cycles-enforcer-rule</artifactId>
1313
<version>1.0.6-SNAPSHOT</version>
14-
<packaging>jar</packaging>
1514

1615
<name>NoPackageCyclesEnforcerRule</name>
1716
<description>A rule for the maven-enforcer-plugin that detects and prevents package cycles.</description>
@@ -43,24 +42,23 @@
4342
</developers>
4443

4544
<properties>
46-
<api.version>1.0</api.version>
4745
<maven.version>2.2.1</maven.version>
4846
</properties>
4947

5048
<build>
5149
<plugins>
5250
<plugin>
5351
<artifactId>maven-compiler-plugin</artifactId>
54-
<version>2.2</version>
52+
<version>3.6.0</version>
5553
<configuration>
56-
<source>1.5</source>
57-
<target>1.5</target>
54+
<source>1.8</source>
55+
<target>1.8</target>
5856
</configuration>
5957
</plugin>
6058
<plugin>
6159
<groupId>org.apache.maven.plugins</groupId>
6260
<artifactId>maven-surefire-plugin</artifactId>
63-
<version>2.14.1</version>
61+
<version>2.19.1</version>
6462
<configuration>
6563
<excludes>
6664
<exclude>*-target/**</exclude>
@@ -71,7 +69,7 @@
7169
<plugin>
7270
<groupId>org.apache.maven.plugins</groupId>
7371
<artifactId>maven-failsafe-plugin</artifactId>
74-
<version>2.14.1</version>
72+
<version>2.19.1</version>
7573
<executions>
7674
<execution>
7775
<goals>
@@ -92,7 +90,7 @@
9290
</plugin>
9391
<plugin>
9492
<artifactId>maven-enforcer-plugin</artifactId>
95-
<version>1.2</version>
93+
<version>1.4.1</version>
9694
<dependencies>
9795
<dependency>
9896
<groupId>de.andrena.tools.nopackagecycles</groupId>
@@ -122,7 +120,7 @@
122120
<dependency>
123121
<groupId>org.apache.maven.enforcer</groupId>
124122
<artifactId>enforcer-api</artifactId>
125-
<version>${api.version}</version>
123+
<version>1.4.1</version>
126124
</dependency>
127125
<dependency>
128126
<groupId>org.apache.maven</groupId>
@@ -147,12 +145,12 @@
147145
<dependency>
148146
<groupId>org.codehaus.plexus</groupId>
149147
<artifactId>plexus-container-default</artifactId>
150-
<version>1.5.5</version>
148+
<version>1.7.1</version>
151149
</dependency>
152150
<dependency>
153-
<groupId>jdepend</groupId>
151+
<groupId>guru.nidi</groupId>
154152
<artifactId>jdepend</artifactId>
155-
<version>2.9.1</version>
153+
<version>2.9.5</version>
156154
</dependency>
157155
<dependency>
158156
<groupId>net.sf.jgrapht</groupId>
@@ -163,7 +161,7 @@
163161
<dependency>
164162
<groupId>junit</groupId>
165163
<artifactId>junit</artifactId>
166-
<version>4.11</version>
164+
<version>4.12</version>
167165
<scope>test</scope>
168166
</dependency>
169167
<dependency>
@@ -179,4 +177,4 @@
179177
<scope>test</scope>
180178
</dependency>
181179
</dependencies>
182-
</project>
180+
</project>

src/test/java/de/andrena/tools/nopackagecycles/NoPackageCyclesRuleIntegrationTest.java

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
package de.andrena.tools.nopackagecycles;
22

3-
import static org.junit.Assert.assertEquals;
4-
import static org.junit.Assert.fail;
3+
import de.andrena.tools.nopackagecycles.mock.EnforcerRuleHelperMock;
4+
import org.apache.commons.io.IOUtils;
5+
import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
6+
import org.junit.Before;
7+
import org.junit.Test;
58

69
import java.io.File;
710
import java.io.IOException;
811
import java.net.URISyntaxException;
912
import java.net.URL;
1013

11-
import org.apache.commons.io.IOUtils;
12-
import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
13-
import org.junit.Before;
14-
import org.junit.Test;
14+
import static org.junit.Assert.*;
1515

16-
import de.andrena.tools.nopackagecycles.mock.EnforcerRuleHelperMock;
1716

1817
public class NoPackageCyclesRuleIntegrationTest {
18+
1919
private static final URL FITNESSE_TARGET_FOLDER = getResource("fitnesse-target");
2020
private static final URL FITNESSE_EXPECTED_OUTPUT = getResource("fitnesse-expected-output.txt");
2121
private static final URL JUNIT_TARGET_FOLDER = getResource("junit-target");
@@ -24,38 +24,45 @@ public class NoPackageCyclesRuleIntegrationTest {
2424
private NoPackageCyclesRule rule;
2525
private EnforcerRuleHelperMock helper;
2626

27+
2728
@Before
2829
public void setUp() throws Exception {
2930
rule = new NoPackageCyclesRule();
3031
helper = new EnforcerRuleHelperMock();
3132
}
3233

34+
3335
@Test
3436
public void fitnesseIntegrationTest() throws Exception {
3537
assertPackageCycles(FITNESSE_TARGET_FOLDER, FITNESSE_EXPECTED_OUTPUT);
3638
}
3739

40+
3841
@Test
3942
public void junitIntegrationTest() throws Exception {
4043
assertPackageCycles(JUNIT_TARGET_FOLDER, JUNIT_EXPECTED_OUTPUT);
4144
}
4245

46+
4347
private void assertPackageCycles(URL targetFolder, URL expectedOutput) throws URISyntaxException, IOException {
4448
helper.setTestClassesDir(new File("non-existent"));
4549
helper.setClassesDir(new File(targetFolder.toURI()));
4650
try {
4751
rule.execute(helper);
4852
fail("expected EnforcerRuleException");
49-
} catch (EnforcerRuleException e) {
53+
}
54+
catch (EnforcerRuleException e) {
5055
// using assertEquals to get a nice comparison editor in eclipse
51-
assertEquals(getExpectedOutput(expectedOutput), e.getMessage());
56+
assertEquals(getExpectedOutput(expectedOutput), e.getMessage() + "\n");
5257
}
5358
}
5459

60+
5561
private String getExpectedOutput(URL expectedOutput) throws IOException {
5662
return IOUtils.toString(expectedOutput.openStream()).replaceAll("\r", "");
5763
}
5864

65+
5966
private static URL getResource(String path) {
6067
return Thread.currentThread().getContextClassLoader().getResource(path);
6168
}

src/test/resources/fitnesse-expected-output.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,4 +295,4 @@ Package-cycle found involving fit, fit.decorator.util, fit.testFxtr, fitnesse, f
295295
fitnesse.http (TemplateUtilTest)
296296
fitnesse.responders.editing (TemplateUtilTest)
297297
fitnesse.testutil (TemplateUtilTest)
298-
fitnesse.wiki (TemplateUtil, TemplateUtilTest)
298+
fitnesse.wiki (TemplateUtil, TemplateUtilTest)

src/test/resources/junit-expected-output.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Package-cycle found involving junit.extensions, junit.framework, junit.runner, o
1616
org.junit.runners (FixMethodOrder)
1717
org.junit.experimental.theories depends on:
1818
org.junit (Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$2)
19-
org.junit.experimental.theories.internal (Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$1$1, Theories$TheoryAnchor$2)
19+
org.junit.experimental.theories.internal (FromDataPoints, Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$1$1, Theories$TheoryAnchor$2)
2020
org.junit.internal (Theories$TheoryAnchor, Theories$TheoryAnchor$1$1)
2121
org.junit.runners (Theories, Theories$TheoryAnchor$1)
2222
org.junit.runners.model (Theories, Theories$TheoryAnchor, Theories$TheoryAnchor$1, Theories$TheoryAnchor$1$1, Theories$TheoryAnchor$2)
@@ -109,4 +109,4 @@ Package-cycle found involving junit.extensions, junit.framework, junit.runner, o
109109
org.junit.internal (TestClass)
110110
org.junit.internal.runners (RunnerBuilder)
111111
org.junit.internal.runners.model (FrameworkMethod$1, MultipleFailureException)
112-
org.junit.runner (RunnerBuilder)
112+
org.junit.runner (RunnerBuilder)

0 commit comments

Comments
 (0)