ReflectedUniverse: remove LogService usage

The LogService was only used for debugging, and only to emit the same
information already thrown by the checked ReflectException. In other
words: totally superfluous.

The only really valid usage was in the main method, which is merely a
test driver. That method uses System.out.println elsewhere, so using
System.err.println for that one situation is more consistent anyway.

Author: ctrueden

src/main/java/org/scijava/util/ReflectedUniverse.java

@@ -43,9 +43,6 @@
 import java.util.HashMap;
 import java.util.StringTokenizer;
 
-import org.scijava.log.LogService;
-import org.scijava.log.StderrLogService;
-
 /**
  * A general-purpose reflection wrapper class.
  * <p>
@@ -71,18 +68,11 @@ public class ReflectedUniverse {
 	/** Whether to force our way past restrictive access modifiers. */
 	private boolean force;
 
-	private final LogService log;
-
 	// -- Constructors --
 
 	/** Constructs a new reflected universe. */
 	public ReflectedUniverse() {
-		this(null, null);
-	}
-
-	/** Constructs a new reflected universe. */
-	public ReflectedUniverse(final LogService log) {
-		this(null, log);
+		this((ClassLoader) null);
 	}
 
 	/**
@@ -96,13 +86,8 @@ public ReflectedUniverse(final URL[] urls) {
 
 	/** Constructs a new reflected universe that uses the given class loader. */
 	public ReflectedUniverse(final ClassLoader loader) {
-		this(loader, null);
-	}
-
-	public ReflectedUniverse(final ClassLoader loader, final LogService log) {
 		variables = new HashMap<String, Object>();
 		this.loader = loader == null ? getClass().getClassLoader() : loader;
-		this.log = log == null ? new StderrLogService() : log;
 	}
 
 	// -- Utility methods --
@@ -166,18 +151,15 @@ public Object exec(String command) throws ReflectException {
 				c = Class.forName(command, true, loader);
 			}
 			catch (final NoClassDefFoundError err) {
-				log.debug("No such class: " + command, err);
 				throw new ReflectException("No such class: " + command, err);
 			}
 			catch (final ClassNotFoundException exc) {
-				log.debug("No such class: " + command, exc);
 				throw new ReflectException("No such class: " + command, exc);
 			}
 			catch (final RuntimeException exc) {
 				// HACK: workaround for bug in Apache Axis2
 				final String msg = exc.getMessage();
 				if (msg != null && msg.indexOf("ClassNotFound") < 0) throw exc;
-				log.debug("No such class: " + command, exc);
 				throw new ReflectException("No such class: " + command, exc);
 			}
 			setVar(varName, c);
@@ -280,7 +262,6 @@ else if (!(var instanceof Class<?>)) {
 				exc = e;
 			}
 			if (exc != null) {
-				log.debug("Cannot instantiate object", exc);
 				throw new ReflectException("Cannot instantiate object", exc);
 			}
 		}
@@ -339,7 +320,6 @@ else if (!(var instanceof Class<?>)) {
 				exc = e;
 			}
 			if (exc != null) {
-				log.debug("Cannot execute method: " + methodName, exc);
 				throw new ReflectException("Cannot execute method: " + methodName, exc);
 			}
 		}
@@ -450,15 +430,13 @@ else if (varName.matches("-?\\d*\\.\\d*")) {
 				if (force) field.setAccessible(true);
 			}
 			catch (final NoSuchFieldException exc) {
-				log.debug("No such field: " + varName, exc);
 				throw new ReflectException("No such field: " + varName, exc);
 			}
 			Object fieldVal;
 			try {
 				fieldVal = field.get(var);
 			}
 			catch (final IllegalAccessException exc) {
-				log.debug("Cannot get field value: " + varName, exc);
 				throw new ReflectException("Cannot get field value: " + varName, exc);
 			}
 			return fieldVal;
@@ -501,7 +479,8 @@ public static void main(final String[] args) throws IOException {
 				r.exec(line);
 			}
 			catch (final ReflectException exc) {
-				r.log.debug("Could not execute '" + line + "'", exc);
+				System.err.println("Could not execute '" + line + "':");
+				exc.printStackTrace();
 			}
 		}
 		System.out.println();