Skip to content

Commit c934d13

Browse files
committed
Converter: remove abstract getXXXType methods
Instead of passing Class instances via constructors, concrete objects should just implement the methods with an appropriate return value, for consistency across SJC.
1 parent 4916f7a commit c934d13

File tree

2 files changed

+10
-28
lines changed

2 files changed

+10
-28
lines changed

src/main/java/org/scijava/convert/AbstractConverter.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,6 @@ public abstract class AbstractConverter extends
5757
AbstractHandlerPlugin<ConversionRequest> implements Converter
5858
{
5959

60-
// -- Fields --
61-
62-
private final Class<?> inClass;
63-
private final Class<?> outClass;
64-
65-
// -- Constructor --
66-
67-
public AbstractConverter(final Class<?> inClass, final Class<?> outClass) {
68-
this.inClass = inClass;
69-
this.outClass = outClass;
70-
}
71-
7260
// -- ConversionHandler methods --
7361

7462
@Override
@@ -99,16 +87,6 @@ public void populateInputs(Set<Object> objects) {
9987
// No-op
10088
}
10189

102-
@Override
103-
public Class<?> getOutputType() {
104-
return outClass;
105-
}
106-
107-
@Override
108-
public Class<?> getInputType() {
109-
return inClass;
110-
}
111-
11290
// -- Typed methods --
11391

11492
@Override

src/main/java/org/scijava/convert/DefaultConverter.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,6 @@
5757
@Plugin(type = Converter.class)
5858
public class DefaultConverter extends AbstractConverter {
5959

60-
// -- Constructor --
61-
62-
public DefaultConverter() {
63-
super(Object.class, Object.class);
64-
}
65-
6660
// -- ConversionHandler methods --
6761

6862
@Override
@@ -271,6 +265,16 @@ public <T> T convert(final Object src, final Class<T> dest) {
271265
}
272266
}
273267

268+
@Override
269+
public Class<?> getOutputType() {
270+
return Object.class;
271+
}
272+
273+
@Override
274+
public Class<?> getInputType() {
275+
return Object.class;
276+
}
277+
274278
// -- Helper methods --
275279

276280
private Constructor<?> getConstructor(final Class<?> type,

0 commit comments

Comments
 (0)