AbstractUIDetails: do not let getTitle return null

ctrueden · ctrueden · commit 93c340f47240 · 2014-11-04T13:31:09.000-06:00
Since it is possible for getIdentifier() to return null, we need to
guard against that circumstance, and only return non-null identifiers.
diff --git a/src/main/java/org/scijava/AbstractUIDetails.java b/src/main/java/org/scijava/AbstractUIDetails.java
@@ -105,7 +105,8 @@ public String getTitle() {
 
 		// use the unique identifier, if available
 		if (this instanceof Identifiable) {
-			return ((Identifiable) this).getIdentifier();
+			final String id = ((Identifiable) this).getIdentifier();
+			if (id != null) return id;
 		}
 
 		// use class name as a last resort

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,8 @@ public String getTitle() {`
`105`	`105`
`106`	`106`	`// use the unique identifier, if available`
`107`	`107`	`if (this instanceof Identifiable) {`
`108`		`- return ((Identifiable) this).getIdentifier();`
	`108`	`+ final String id = ((Identifiable) this).getIdentifier();`
	`109`	`+ if (id != null) return id;`
`109`	`110`	`}`
`110`	`111`
`111`	`112`	`// use class name as a last resort`