Skip to content

Commit 257ca6c

Browse files
committed
.
1 parent b0dfe1a commit 257ca6c

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/agentex/lib/cli/handlers/deploy_handlers.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,10 +470,19 @@ def deploy_agent(
470470
helm_repository_name: str | None = None
471471
oci_registry: str | None = None
472472

473+
# Track OCI provider for provider-specific features
474+
oci_provider: str | None = None
475+
473476
if use_oci:
474477
oci_registry = agent_env_config.helm_oci_registry # type: ignore[union-attr]
478+
oci_provider = agent_env_config.helm_oci_provider # type: ignore[union-attr]
475479
console.print(f"[blue]ℹ[/blue] Using OCI Helm registry: {oci_registry}")
476-
login_to_gar_registry(oci_registry) # type: ignore[arg-type]
480+
481+
# Only auto-authenticate for GAR provider
482+
if oci_provider == "gar":
483+
login_to_gar_registry(oci_registry) # type: ignore[arg-type]
484+
else:
485+
console.print("[blue]ℹ[/blue] Skipping auto-authentication (no provider specified, assuming already authenticated)")
477486
else:
478487
if agent_env_config:
479488
helm_repository_name = agent_env_config.helm_repository_name
@@ -497,6 +506,9 @@ def deploy_agent(
497506
if not use_oci:
498507
console.print("[yellow]⚠[/yellow] --use-latest-chart only works with OCI registries, using default version")
499508
chart_version = DEFAULT_HELM_CHART_VERSION
509+
elif oci_provider != "gar":
510+
console.print("[yellow]⚠[/yellow] --use-latest-chart only works with GAR provider (helm_oci_provider: gar), using default version")
511+
chart_version = DEFAULT_HELM_CHART_VERSION
500512
else:
501513
chart_version = get_latest_gar_chart_version(oci_registry) # type: ignore[arg-type]
502514
elif agent_env_config and agent_env_config.helm_chart_version:

src/agentex/lib/sdk/config/environment_config.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
from __future__ import annotations
99

10-
from typing import Any, Dict, override
10+
from typing import Any, Dict, Literal, override
1111
from pathlib import Path
1212

1313
import yaml
@@ -74,6 +74,12 @@ class AgentEnvironmentConfig(BaseModel):
7474
description="OCI registry URL for Helm charts (e.g., 'us-west1-docker.pkg.dev/project/repo'). "
7575
"When set, OCI mode is used instead of classic helm repo."
7676
)
77+
helm_oci_provider: Literal["gar"] | None = Field(
78+
default=None,
79+
description="OCI registry provider for provider-specific features. "
80+
"Set to 'gar' for Google Artifact Registry to enable auto-authentication via gcloud "
81+
"and latest version fetching. When not set, assumes user has already authenticated."
82+
)
7783
helm_chart_version: str | None = Field(
7884
default=None,
7985
description="Helm chart version to deploy. If not set, uses the default version from the CLI."

0 commit comments

Comments
 (0)