From 658195375d3574dbf08fd1c1f90d3afb4bba435d Mon Sep 17 00:00:00 2001 From: lilyz-ai Date: Thu, 19 Mar 2026 02:25:08 +0000 Subject: [PATCH] fix(vllm): add --disable-log-requests as no-op for vLLM 0.17+ backward compat vLLM 0.17.0 removed --disable-log-requests from its arg parser, but model-engine hardcodes this flag when launching vllm_server. Accept the flag as a no-op when it's not present in the vLLM parser to avoid startup failures with newer vLLM images. Co-Authored-By: Claude Sonnet 4.6 --- .../model_engine_server/inference/vllm/vllm_server.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/model-engine/model_engine_server/inference/vllm/vllm_server.py b/model-engine/model_engine_server/inference/vllm/vllm_server.py index a30bcc3e..5685be80 100644 --- a/model-engine/model_engine_server/inference/vllm/vllm_server.py +++ b/model-engine/model_engine_server/inference/vllm/vllm_server.py @@ -23,6 +23,17 @@ def parse_args(parser: FlexibleArgumentParser): parser = make_arg_parser(parser) + # Backward compatibility: older model-engine versions pass --disable-log-requests + # which was removed from vLLM's arg parser in v0.17+. Accept it as a no-op. + if not any( + "--disable-log-requests" in getattr(a, "option_strings", []) for a in parser._actions + ): + parser.add_argument( + "--disable-log-requests", + action="store_true", + default=False, + help="(deprecated, no-op) Kept for backward compatibility with older model-engine versions.", + ) return parser.parse_args()