Skip to content

Commit a84ead4

Browse files
committed
feat(chart): Add GCP Workload Identity support for service accounts
Add GCP Workload Identity annotation support to both main and inference service accounts, following the same pattern as Azure PR #762. Changes: - service_account.yaml: Add iam.gke.io/gcp-service-account annotation using gcp.iam_service_account value - service_account_inference.yaml: Add iam.gke.io/gcp-service-account annotation with fallback from gcp.inference_service_account to gcp.iam_service_account (allows separate SA for inference pods) This enables proper GCP Workload Identity binding for model-engine pods on GKE clusters. Implements SGPINF-1123
1 parent 85a7735 commit a84ead4

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

charts/model-engine/templates/service_account.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ metadata:
1616
{{- if $.Values.azure }}
1717
azure.workload.identity/client-id: {{ $.Values.azure.client_id }}
1818
{{- end }}
19+
{{- if $.Values.gcp }}
20+
{{- if $.Values.gcp.iam_service_account }}
21+
iam.gke.io/gcp-service-account: {{ $.Values.gcp.iam_service_account }}
22+
{{- end }}
23+
{{- end }}
1924
{{- end }}
2025
{{- if $.Values.azure }}
2126
imagePullSecrets:

charts/model-engine/templates/service_account_inference.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@ metadata:
2020
azure.workload.identity/client-id: {{ $.Values.azure.client_id }}
2121
{{- end }}
2222
{{- end }}
23+
{{- if $.Values.gcp }}
24+
{{- if $.Values.gcp.inference_service_account }}
25+
iam.gke.io/gcp-service-account: {{ $.Values.gcp.inference_service_account }}
26+
{{- else if $.Values.gcp.iam_service_account }}
27+
iam.gke.io/gcp-service-account: {{ $.Values.gcp.iam_service_account }}
28+
{{- end }}
29+
{{- end }}
2330
{{- end }}
2431
{{- if $.Values.azure }}
2532
imagePullSecrets:

0 commit comments

Comments
 (0)