Commit 274d49e
committed
Ensure scala.concurrent.java8._ is packaged
The implementation of `FutureConverters` needs to access
some `private[concurrent]` members in the standard library.
To do so, it places some of its implementation under this package.
However, the OSGi SBT plugin seems to silently remove packages from the
final artifact that aren't either a publicly exported or a declared
private package.
Because of this, the 0.2.0 released JARs did not contain these
classes, and using FutureConverters resulted in a linkage error.
After this commit:
```
% sbt clean publishLocal
% jar tf target/scala-2.11/scala-java8-compat_2.11-0.2.0-SNAPSHOT.jar | grep -v 'scala/compat'
META-INF/MANIFEST.MF
scala-java8-compat.properties
scala/
scala/concurrent/
scala/concurrent/java8/
scala/concurrent/java8/FuturesConvertersImpl$.class
scala/concurrent/java8/FuturesConvertersImpl$CF$$anon$1.class
scala/concurrent/java8/FuturesConvertersImpl$CF.class
scala/concurrent/java8/FuturesConvertersImpl$P.class
scala/concurrent/java8/FuturesConvertersImpl.class
```
As compared with:
```
% curl --silent https://oss.sonatype.org/content/repositories/releases/org/scala-lang/modules/scala-java8-compat_2.11/0.2.0/scala-java8-compat_2.11-0.2.0.jar | tar tf - | grep -v 'scala/compat'
META-INF/MANIFEST.MF
scala-java8-compat.properties
scala/
```
Fixes #261 parent cab9c39 commit 274d49e
1 file changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
96 | 98 | | |
97 | 99 | | |
98 | 100 | | |
99 | | - | |
| 101 | + | |
100 | 102 | | |
101 | 103 | | |
0 commit comments