Tidy up

Author: japgolly

build.sbt

@@ -1,7 +1,14 @@
+import _root_.scalafix.sbt.BuildInfo.scalafixVersion
 import scalatex.ScalatexReadme
 
 ThisBuild / shellPrompt := ((s: State) => Project.extract(s).currentRef.project + "> ")
 
+lazy val scalafixRules = project
+  .in(file("scalafix"))
+  .settings(
+    libraryDependencies += "ch.epfl.scala" %% "scalafix-core" % scalafixVersion,
+  )
+
 lazy val root = project
   .in(file("."))
   .enablePlugins(ScalaJSPlugin)
@@ -15,8 +22,7 @@ ThisBuild / crossScalaVersions := {
   if (scalaJSVersion.startsWith("1.")) Seq("2.12.10", "2.11.12", "2.13.1")
   else Seq("2.12.10", "2.11.12", "2.10.7", "2.13.1")
 }
-// ThisBuild / scalaVersion := crossScalaVersions.value.head
-ThisBuild / scalaVersion := "2.13.1"
+ThisBuild / scalaVersion := crossScalaVersions.value.head
 
 val commonSettings = Seq(
   organization := "org.scala-js",
@@ -117,13 +123,3 @@ lazy val example = project.
   settings(commonSettings: _*).
   settings(noPublishSettings: _*).
   dependsOn(root)
-
-
-import _root_.scalafix.sbt.BuildInfo.scalafixVersion
-
-lazy val scalafixRules = project
-  .in(file("scalafix"))
-  .enablePlugins(ScalaJSPlugin)
-  .settings(
-    libraryDependencies += "ch.epfl.scala" %% "scalafix-core" % scalafixVersion,
-  )

scalafix.sbt

@@ -1,5 +1,5 @@
 ThisBuild / semanticdbEnabled          := true
-ThisBuild / semanticdbVersion          := "4.4.26"
+ThisBuild / semanticdbVersion          := "4.4.27"
 ThisBuild / scalafixScalaBinaryVersion := CrossVersion.binaryScalaVersion(scalaVersion.value)
 
 ThisBuild / scalacOptions ++= {

scalafix/src/main/scala/org/scalajs/dom/scalafix/GenerateApiReport.scala

@@ -15,8 +15,6 @@ class GenerateApiReport extends SemanticRule("GenerateApiReport") {
   override def fix(implicit doc: SemanticDocument): Patch = {
 
     doc.tree.traverse {
-      // case a: Defn.Object if a.name.value.contains("AesCbcParams") => process(a.symbol, a.templ, ScopeType.Object)
-
       case a: Defn.Class  => process(a.symbol, a.templ, ScopeType.Class)
       case a: Defn.Object => process(a.symbol, a.templ, ScopeType.Object)
       case a: Defn.Trait  => process(a.symbol, a.templ, ScopeType.Trait)
@@ -28,7 +26,7 @@ class GenerateApiReport extends SemanticRule("GenerateApiReport") {
   }
 
   private def process(sym: Symbol, body: Template, typ: ScopeType)(implicit doc: SemanticDocument): Unit = {
-    // Skip non-public API
+    // Skip non-public scopes
     if (!sym.info.get.isPublic)
       return
 
@@ -38,8 +36,7 @@ class GenerateApiReport extends SemanticRule("GenerateApiReport") {
     val s          = state.register(sym, isJsType, typ, domParents)
 
     def letsSeeHowLazyWeCanBeLol(t: Tree): Unit = {
-
-      // Skip non-public API
+      // Skip non-public members
       if (!t.symbol.info.get.isPublic)
         return