From 4ad6f85bfbb64c87e26d49ec4fabcd665a862d38 Mon Sep 17 00:00:00 2001 From: Steve Dignam Date: Sat, 6 Dec 2025 12:09:26 -0500 Subject: [PATCH] parser: fix reindex parsing we were using a name instead of a name_ref for the table name --- crates/squawk_parser/src/grammar.rs | 2 +- .../tests/snapshots/tests__reindex_err.snap | 2 +- .../tests/snapshots/tests__reindex_ok.snap | 16 ++++++++-------- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/crates/squawk_parser/src/grammar.rs b/crates/squawk_parser/src/grammar.rs index 2116c223..926c4cd5 100644 --- a/crates/squawk_parser/src/grammar.rs +++ b/crates/squawk_parser/src/grammar.rs @@ -11301,7 +11301,7 @@ fn reindex(p: &mut Parser<'_>) -> CompletedMarker { } }; p.eat(CONCURRENTLY_KW); - if opt_path_name(p).is_none() && name_required { + if opt_path_name_ref(p).is_none() && name_required { p.error("expected name"); } m.complete(p, REINDEX) diff --git a/crates/squawk_parser/tests/snapshots/tests__reindex_err.snap b/crates/squawk_parser/tests/snapshots/tests__reindex_err.snap index 164cdde2..08e3be68 100644 --- a/crates/squawk_parser/tests/snapshots/tests__reindex_err.snap +++ b/crates/squawk_parser/tests/snapshots/tests__reindex_err.snap @@ -23,7 +23,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "i" SEMICOLON ";" WHITESPACE "\n" diff --git a/crates/squawk_parser/tests/snapshots/tests__reindex_ok.snap b/crates/squawk_parser/tests/snapshots/tests__reindex_ok.snap index c024ade7..9891e234 100644 --- a/crates/squawk_parser/tests/snapshots/tests__reindex_ok.snap +++ b/crates/squawk_parser/tests/snapshots/tests__reindex_ok.snap @@ -12,7 +12,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "my_index" SEMICOLON ";" WHITESPACE "\n\n" @@ -23,7 +23,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "my_table" SEMICOLON ";" WHITESPACE "\n\n" @@ -36,7 +36,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "my_broken_table" SEMICOLON ";" WHITESPACE "\n\n" @@ -70,7 +70,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "foo" SEMICOLON ";" WHITESPACE "\n\n" @@ -81,7 +81,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "foo" SEMICOLON ";" WHITESPACE "\n\n" @@ -92,7 +92,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "foo" SEMICOLON ";" WHITESPACE "\n" @@ -103,7 +103,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "foo" SEMICOLON ";" WHITESPACE "\n" @@ -114,7 +114,7 @@ SOURCE_FILE WHITESPACE " " PATH PATH_SEGMENT - NAME + NAME_REF IDENT "foo" SEMICOLON ";" WHITESPACE "\n\n"