`ALTER COLUMN x SET NOT NULL` no longer triggers `adding-not-nullable-field` as of v2.0.0

[vicrep]

Version 1.5.4 introduced a regression where SET NO NULL was no longer triggering the adding-not-nullable-field warning. This was fixed in version 1.5.5 here: #412

Unfortunately, it seems that this fix did not survive the rewrite, as of version 2.0, the violation is no longer emitted.

Repro

Given the following migration, with pg_version set to ≥ 12

-- tmp-migration.sql

BEGIN;

-- Running upgrade a -> b

ALTER TABLE my_table ALTER COLUMN my_column SET NOT NULL;

UPDATE alembic_version SET version_num='b' WHERE alembic_version.version_num = 'a';

COMMIT;

Running on 1.6.1 (last version pre-rewrite):

npx -y squawk-cli@1.6.1 tmp-migration.sql
tmp-migration.sql:2:2: warning: adding-not-nullable-field

   2 | -- Running upgrade a -> b
   3 |
   4 | ALTER TABLE my_table ALTER COLUMN my_column SET NOT NULL;

  note: Setting a column NOT NULL blocks reads while the table is scanned.
  help: Use a check constraint instead.

find detailed examples and solutions for each rule at https://squawkhq.com/docs/rules
Found 1 issue in 1 file (checked 1 source file)

Running on v2.0.0 (note, the same applied on latest, i.e. 2.10.0)

npx -y squawk-cli@2.0.0 tmp-migration.sql

Found 0 issues in 1 file 🎉

[sbdchd]

Ah seems like #412 / 360e3ee didn't make it to v2

In v2 we still have the check:

squawk/crates/squawk_linter/src/rules/adding_not_null_field.rs

Lines 9 to 10 in 0456dba

	if ctx.settings.pg_version >= Version::new(11, 0, 0) {
	return;

squawk/crates/squawk_linter/src/rules/adding_not_null_field.rs

Lines 59 to 64 in 0456dba

	BEGIN;
	-- This will cause a table rewrite for Postgres versions before 11, but that is handled by
	-- adding-field-with-default.
	ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10 NOT NULL;
	ALTER TABLE "core_recipe" ALTER COLUMN "foo" DROP DEFAULT;
	COMMIT;

[sbdchd]

Should be fixed in 2.11.0!

❯ npx squawk-cli@latest --version
squawk 2.11.0

❯ npx -y squawk-cli@latest foo.sql
warning[adding-not-nullable-field]: Setting a column `NOT NULL` blocks reads while the table is scanned.
 --> foo.sql:7:45
  |
7 | ALTER TABLE my_table ALTER COLUMN my_column SET NOT NULL;
  |                                             ------------
  |
  = help: Make the field nullable and use a `CHECK` constraint instead.

Find detailed examples and solutions for each rule at https://squawkhq.com/docs/rules
Found 1 issue in 1 file (checked 1 source file)

[sbdchd]

Thanks for the report!

[vicrep]

Amazing, thank you so much for the super quick turnaround!