W-22285553: update default dev command for design mode#55
Closed
elle-nk wants to merge 1 commit into
Closed
Conversation
|
Thanks for the contribution! It looks like @enguyenkhoa is an internal user so signing the CLA is not required. However, we need to confirm this. |
elle-nk
changed the title
elle-nk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes DEFAULT_DEV_COMMAND in src/config/uiBundleDiscovery.ts from 'npm run dev' to 'npm run dev:design'. When a bundle's ui-bundle.json has no explicit dev.command, sf ui-bundle dev now boots Vite with --mode design so the Hybrid Editor design runtime loads automatically. Manifest dev.command still wins; bundles that need plain mode opt out via dev.command: "npm run dev".
What issues does this PR fix or reference?
@W-22285553@: Hybrid Editor / Design Mode in the Salesforce Live Preview VS Code extension needs the Vite dev server in --mode design. The extension shells out to sf ui-bundle dev and has no way to influence the command without modifying the bundle's ui-bundle.json. This change makes design mode the default so the extension doesn't need a per-launch lever.