Skip to content

Commit ee65167

Browse files
committed
Raise allowable epsilon errors on logspace and geomspace
For some reason, when Miri runs, we get higher floating point error on these methods.
1 parent cb74358 commit ee65167

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/geomspace.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,16 +117,16 @@ mod tests
117117
use approx::assert_abs_diff_eq;
118118

119119
let array: Array1<_> = geomspace(1e0, 1e3, 4).unwrap().collect();
120-
assert_abs_diff_eq!(array, arr1(&[1e0, 1e1, 1e2, 1e3]), epsilon = 1e-12);
120+
assert_abs_diff_eq!(array, arr1(&[1e0, 1e1, 1e2, 1e3]), epsilon = 1e-11);
121121

122122
let array: Array1<_> = geomspace(1e3, 1e0, 4).unwrap().collect();
123-
assert_abs_diff_eq!(array, arr1(&[1e3, 1e2, 1e1, 1e0]), epsilon = 1e-12);
123+
assert_abs_diff_eq!(array, arr1(&[1e3, 1e2, 1e1, 1e0]), epsilon = 1e-11);
124124

125125
let array: Array1<_> = geomspace(-1e3, -1e0, 4).unwrap().collect();
126-
assert_abs_diff_eq!(array, arr1(&[-1e3, -1e2, -1e1, -1e0]), epsilon = 1e-12);
126+
assert_abs_diff_eq!(array, arr1(&[-1e3, -1e2, -1e1, -1e0]), epsilon = 1e-11);
127127

128128
let array: Array1<_> = geomspace(-1e0, -1e3, 4).unwrap().collect();
129-
assert_abs_diff_eq!(array, arr1(&[-1e0, -1e1, -1e2, -1e3]), epsilon = 1e-12);
129+
assert_abs_diff_eq!(array, arr1(&[-1e0, -1e1, -1e2, -1e3]), epsilon = 1e-11);
130130
}
131131

132132
#[test]

src/impl_constructors.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,10 @@ where S: DataOwned<Elem = A>
140140
/// use ndarray::{Array, arr1};
141141
///
142142
/// let array = Array::logspace(10.0, 0.0, 3.0, 4);
143-
/// assert_abs_diff_eq!(array, arr1(&[1e0, 1e1, 1e2, 1e3]));
143+
/// assert_abs_diff_eq!(array, arr1(&[1e0, 1e1, 1e2, 1e3]), epsilon = 1e-12);
144144
///
145145
/// let array = Array::logspace(-10.0, 3.0, 0.0, 4);
146-
/// assert_abs_diff_eq!(array, arr1(&[-1e3, -1e2, -1e1, -1e0]));
146+
/// assert_abs_diff_eq!(array, arr1(&[-1e3, -1e2, -1e1, -1e0]), epsilon = 1e-12);
147147
/// # }
148148
/// ```
149149
#[cfg(feature = "std")]

src/logspace.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,16 +111,16 @@ mod tests
111111
use approx::assert_abs_diff_eq;
112112

113113
let array: Array1<_> = logspace(10.0, 0.0, 3.0, 4).collect();
114-
assert_abs_diff_eq!(array, arr1(&[1e0, 1e1, 1e2, 1e3]));
114+
assert_abs_diff_eq!(array, arr1(&[1e0, 1e1, 1e2, 1e3]), epsilon = 1e-12);
115115

116116
let array: Array1<_> = logspace(10.0, 3.0, 0.0, 4).collect();
117-
assert_abs_diff_eq!(array, arr1(&[1e3, 1e2, 1e1, 1e0]));
117+
assert_abs_diff_eq!(array, arr1(&[1e3, 1e2, 1e1, 1e0]), epsilon = 1e-12);
118118

119119
let array: Array1<_> = logspace(-10.0, 3.0, 0.0, 4).collect();
120-
assert_abs_diff_eq!(array, arr1(&[-1e3, -1e2, -1e1, -1e0]));
120+
assert_abs_diff_eq!(array, arr1(&[-1e3, -1e2, -1e1, -1e0]), epsilon = 1e-12);
121121

122122
let array: Array1<_> = logspace(-10.0, 0.0, 3.0, 4).collect();
123-
assert_abs_diff_eq!(array, arr1(&[-1e0, -1e1, -1e2, -1e3]));
123+
assert_abs_diff_eq!(array, arr1(&[-1e0, -1e1, -1e2, -1e3]), epsilon = 1e-12);
124124
}
125125

126126
#[test]

0 commit comments

Comments
 (0)