Rename the client_async module to bdk_client

The client is only designed for BDK and is not a general purpose async
client.

Rename it to bdk_client to make the purpose clear.

Author: jamillambert

client/src/client_async/error.rs client/src/bdk_client/error.rsclient/src/client_async/error.rs renamed to client/src/bdk_client/error.rs

@@ -1,16 +1,16 @@
 // SPDX-License-Identifier: CC0-1.0
 
-//! Async JSON-RPC clients for specific versions of Bitcoin Core.
+//! Async JSON-RPC clients for Bitcoin Core v25 to v30.
 
-pub mod bdk_client;
+pub mod rpcs;
 mod error;
 
 use std::fmt;
 use std::fs::File;
 use std::io::{BufRead, BufReader};
 use std::path::PathBuf;
 
-pub use crate::client_async::error::Error;
+pub use crate::bdk_client::error::Error;
 
 /// Crate-specific Result type.
 ///

client/src/client_async/mod.rs client/src/bdk_client/mod.rsclient/src/client_async/mod.rs renamed to client/src/bdk_client/mod.rs

@@ -1,10 +1,11 @@
 // SPDX-License-Identifier: CC0-1.0
 
-//! Async JSON-RPC client with the RPC set used by BDK for Core versions 25 to 30.
+//! RPC set used by BDK.
+//! All functions return the version nonspecific, strongly typed types.
 
 use bitcoin::{block, Block, BlockHash, Transaction, Txid};
 
-use crate::client_async::{into_json, Client, Result};
+use crate::bdk_client::{into_json, Client, Result};
 use crate::types::model::{GetBlockFilter, GetBlockHeaderVerbose, GetBlockVerboseOne};
 
 impl Client {
@@ -15,13 +16,13 @@ impl Client {
         Ok(json.into_model()?.0)
     }
 
-    /// Gets block count.
+    /// Gets the block count.
     pub async fn get_block_count(&self) -> Result<u64> {
         let json: crate::types::v25::GetBlockCount = self.call("getblockcount", &[]).await?;
         Ok(json.into_model().0)
     }
 
-    /// Gets block hash for a height.
+    /// Gets the block hash for a height.
     pub async fn get_block_hash(&self, height: u32) -> Result<BlockHash> {
         let json: crate::types::v25::GetBlockHash =
             self.call("getblockhash", &[into_json(height)?]).await?;
@@ -34,14 +35,14 @@ impl Client {
         Ok(json.into_model()?.0)
     }
 
-    /// Gets block header by blockhash.
+    /// Gets the block header by blockhash.
     pub async fn get_block_header(&self, hash: &BlockHash) -> Result<block::Header> {
         let json: crate::types::v25::GetBlockHeader =
             self.call("getblockheader", &[into_json(hash)?, into_json(false)?]).await?;
         Ok(json.into_model()?.0)
     }
 
-    /// Gets block header with verbose output.
+    /// Gets the block header with verbose output.
     pub async fn get_block_header_verbose(
         &self,
         hash: &BlockHash,
@@ -74,20 +75,20 @@ impl Client {
         }
     }
 
-    /// Gets block filter for a blockhash.
+    /// Gets the block filter for a blockhash.
     pub async fn get_block_filter(&self, hash: &BlockHash) -> Result<GetBlockFilter> {
         let json: crate::types::v25::GetBlockFilter =
             self.call("getblockfilter", &[into_json(hash)?]).await?;
         Ok(json.into_model()?)
     }
 
-    /// Gets transaction IDs currently in the mempool.
+    /// Gets the transaction IDs currently in the mempool.
     pub async fn get_raw_mempool(&self) -> Result<Vec<Txid>> {
         let json: crate::types::v25::GetRawMempool = self.call("getrawmempool", &[]).await?;
         Ok(json.into_model()?.0)
     }
 
-    /// Gets raw transaction by txid.
+    /// Gets the raw transaction by txid.
     pub async fn get_raw_transaction(&self, txid: &Txid) -> Result<Transaction> {
         let json: crate::types::v25::GetRawTransaction =
             self.call("getrawtransaction", &[into_json(txid)?]).await?;

client/src/client_async/bdk_client.rs client/src/bdk_client/rpcs.rsclient/src/client_async/bdk_client.rs renamed to client/src/bdk_client/rpcs.rs

@@ -13,4 +13,4 @@ pub extern crate types;
 pub mod client_sync;
 
 #[cfg(feature = "client-async")]
-pub mod client_async;
+pub mod bdk_client;

client/src/lib.rs

@@ -7,7 +7,7 @@
 
 use bitcoin::address::KnownHrp;
 use bitcoin::{Address, CompressedPublicKey, PrivateKey};
-use corepc_client::client_async::{Auth, Client, Error as AsyncClientError};
+use corepc_client::bdk_client::{Auth, Client, Error as AsyncClientError};
 use integration_test::{Node, NodeExt as _, Wallet};
 use node::mtype;