Skip to content

Commit def519b

Browse files
authored
rename enforce_layer -> enforce_layers (#45)
* rename enforce_layer -> enforce_layers * bump version to 0.25.0
1 parent 764aa94 commit def519b

6 files changed

Lines changed: 21 additions & 21 deletions

File tree

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
parse_packwerk (0.24.0)
4+
parse_packwerk (0.25.0)
55
bigdecimal
66
sorbet-runtime
77

lib/parse_packwerk.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def self.write_package_yml!(package)
7373
end
7474

7575
if Extensions.layer_extension_installed?
76-
merged_config.merge!('enforce_layer' => package.enforce_layer)
76+
merged_config.merge!('enforce_layers' => package.enforce_layers)
7777
end
7878

7979
unless package.public_path == DEFAULT_PUBLIC_PATH
@@ -107,7 +107,7 @@ def self.key_sort_order
107107
enforce_dependencies
108108
enforce_privacy
109109
enforce_visibility
110-
enforce_layer
110+
enforce_layers
111111
public_path
112112
owner
113113
layer

lib/parse_packwerk/constants.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module ParsePackwerk
77
PACKAGE_TODO_YML_NAME = T.let('package_todo.yml'.freeze, String)
88
ENFORCE_DEPENDENCIES = T.let('enforce_dependencies'.freeze, String)
99
ENFORCE_PRIVACY = T.let('enforce_privacy'.freeze, String)
10-
ENFORCE_LAYER = T.let('enforce_layer'.freeze, String)
10+
ENFORCE_LAYERS = T.let('enforce_layers'.freeze, String)
1111
DEPENDENCY_VIOLATION_TYPE = T.let('dependency'.freeze, String)
1212
PRIVACY_VIOLATION_TYPE = T.let('privacy'.freeze, String)
1313
PUBLIC_PATH = T.let('public_path'.freeze, String)

lib/parse_packwerk/package.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class Package < T::Struct
77
const :name, String
88
const :enforce_dependencies, T.nilable(T.any(T::Boolean, String))
99
const :enforce_privacy, T.any(T::Boolean, String), default: false
10-
const :enforce_layer, T.any(T::Boolean, String), default: false
10+
const :enforce_layers, T.any(T::Boolean, String), default: false
1111
const :public_path, String, default: DEFAULT_PUBLIC_PATH
1212
const :metadata, MetadataYmlType
1313
const :dependencies, T::Array[String]
@@ -23,7 +23,7 @@ def self.from(pathname)
2323
name: package_name,
2424
enforce_dependencies: package_loaded_yml[ENFORCE_DEPENDENCIES],
2525
enforce_privacy: package_loaded_yml[ENFORCE_PRIVACY] || false,
26-
enforce_layer: package_loaded_yml[ENFORCE_LAYER] || false,
26+
enforce_layers: package_loaded_yml[ENFORCE_LAYERS] || false,
2727
public_path: package_loaded_yml[PUBLIC_PATH] || DEFAULT_PUBLIC_PATH,
2828
metadata: package_loaded_yml[METADATA] || {},
2929
dependencies: package_loaded_yml[DEPENDENCIES] || [],
@@ -63,8 +63,8 @@ def enforces_privacy?
6363
end
6464

6565
sig { returns(T.any(T::Boolean, String)) }
66-
def enforces_layer?
67-
enforce_layer
66+
def enforces_layers?
67+
enforce_layers
6868
end
6969
end
7070
end

parse_packwerk.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Gem::Specification.new do |spec|
22
spec.name = 'parse_packwerk'
3-
spec.version = '0.24.0'
3+
spec.version = '0.25.0'
44
spec.authors = ['Gusto Engineers']
55
spec.email = ['dev@gusto.com']
66
spec.summary = 'A low-dependency gem for parsing and writing packwerk YML files'

spec/parse_packwerk_spec.rb

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -983,12 +983,12 @@
983983
let(:package_yml) { package_dir.join('package.yml') }
984984
let(:package_todo_yml) { package_dir.join('package_todo.yml') }
985985

986-
def build_pack(public_path: 'app/public', enforce_privacy: true, enforce_layer: true, dependencies: [], metadata: {}, config: {})
986+
def build_pack(public_path: 'app/public', enforce_privacy: true, enforce_layers: true, dependencies: [], metadata: {}, config: {})
987987
ParsePackwerk::Package.new(
988988
name: package_dir.to_s,
989989
enforce_dependencies: true,
990990
enforce_privacy: enforce_privacy,
991-
enforce_layer: enforce_layer,
991+
enforce_layers: enforce_layers,
992992
public_path: public_path,
993993
dependencies: dependencies,
994994
metadata: metadata,
@@ -1002,7 +1002,7 @@ def pack_as_hash(package)
10021002
name: package.name,
10031003
enforce_dependencies: package.enforce_dependencies,
10041004
enforce_privacy: package.enforce_privacy,
1005-
enforce_layer: package.enforce_layer,
1005+
enforce_layers: package.enforce_layers,
10061006
dependencies: package.dependencies,
10071007
metadata: package.metadata
10081008
}
@@ -1016,7 +1016,7 @@ def pack_as_hash(package)
10161016
expect(package_yml.read).to eq <<~PACKAGEYML
10171017
enforce_dependencies: true
10181018
enforce_privacy: true
1019-
enforce_layer: true
1019+
enforce_layers: true
10201020
PACKAGEYML
10211021

10221022
expect(all_packages.count).to eq 1
@@ -1034,7 +1034,7 @@ def pack_as_hash(package)
10341034
expect(package_yml.read).to eq <<~PACKAGEYML
10351035
enforce_dependencies: true
10361036
enforce_privacy: true
1037-
enforce_layer: true
1037+
enforce_layers: true
10381038
public_path: other/path
10391039
PACKAGEYML
10401040

@@ -1053,7 +1053,7 @@ def pack_as_hash(package)
10531053
expect(package_yml.read).to eq <<~PACKAGEYML
10541054
enforce_dependencies: true
10551055
enforce_privacy: strict
1056-
enforce_layer: true
1056+
enforce_layers: true
10571057
PACKAGEYML
10581058

10591059
expect(all_packages.count).to eq 1
@@ -1071,7 +1071,7 @@ def pack_as_hash(package)
10711071
expect(package_yml.read).to eq <<~PACKAGEYML
10721072
enforce_dependencies: true
10731073
enforce_privacy: true
1074-
enforce_layer: true
1074+
enforce_layers: true
10751075
dependencies:
10761076
- my_other_pack1
10771077
- my_other_pack2
@@ -1096,7 +1096,7 @@ def pack_as_hash(package)
10961096
expect(package_yml.read).to eq <<~PACKAGEYML
10971097
enforce_dependencies: true
10981098
enforce_privacy: true
1099-
enforce_layer: true
1099+
enforce_layers: true
11001100
metadata:
11011101
owner: Mission > Team
11021102
protections:
@@ -1113,7 +1113,7 @@ def pack_as_hash(package)
11131113
write_file(package_yml, <<~CONTENTS)
11141114
enforce_dependencies: true
11151115
enforce_privacy: true
1116-
enforce_layer: true
1116+
enforce_layers: true
11171117
public_path: other/path
11181118
dependencies:
11191119
- packs/package2
@@ -1132,7 +1132,7 @@ def pack_as_hash(package)
11321132
expect(package_yml.read).to eq <<~PACKAGEYML
11331133
enforce_dependencies: true
11341134
enforce_privacy: true
1135-
enforce_layer: true
1135+
enforce_layers: true
11361136
public_path: other/path
11371137
PACKAGEYML
11381138
end
@@ -1153,7 +1153,7 @@ def pack_as_hash(package)
11531153
expect(package_yml.read).to eq <<~PACKAGEYML
11541154
enforce_dependencies: true
11551155
enforce_privacy: true
1156-
enforce_layer: true
1156+
enforce_layers: true
11571157
my_special_key:
11581158
blah: 1
11591159
my_other_special_key: true
@@ -1169,7 +1169,7 @@ def pack_as_hash(package)
11691169
write_file('packwerk.yml', '{}')
11701170
end
11711171

1172-
let(:package) { build_pack(enforce_privacy: false, enforce_layer: false) }
1172+
let(:package) { build_pack(enforce_privacy: false, enforce_layers: false) }
11731173

11741174
it 'writes the right package' do
11751175
ParsePackwerk.write_package_yml!(package)

0 commit comments

Comments
 (0)