From 221ca71f3d73934effc0c0822896ac7bda736027 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 5 Mar 2026 15:03:45 -0800 Subject: [PATCH 1/3] Add typos config to suppress false positive in test fixture data `#pulic_api:` in test/unit/privacy/checker_test.rb is intentional test data verifying that a misspelled sigil is rejected as invalid. Suppress the false positive with a _typos.toml extend-words entry. --- _typos.toml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 _typos.toml diff --git a/_typos.toml b/_typos.toml new file mode 100644 index 0000000..62b9aa1 --- /dev/null +++ b/_typos.toml @@ -0,0 +1,3 @@ +[default.extend-words] +# `#pulic_api:` is intentional test data verifying that a misspelled sigil is rejected +pulic = "pulic" From 310b958f39da1c4b061cd240b01490ff719ee898 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 5 Mar 2026 15:03:59 -0800 Subject: [PATCH 2/3] Fix grammatical issues in README - Fix missing words in folder_privacy checker description: "allows packages to their sibling packs" -> "allows packages to be private to their sibling packs" - Remove duplicate word: "way of of defining" -> "way of defining" --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e6ddaed..169d441 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@ Currently, it ships the following checkers to help improve the boundaries between packages. These checkers are: - A `privacy` checker that ensures other packages are using your package's public API - A `visibility` checker that allows packages to be private except to an explicit group of other packages. -- A `folder_privacy` checker that allows packages to their sibling packs and parent pack (to be used in an application that uses folder packs) +- A `folder_privacy` checker that allows packages to be private to their sibling packs and parent pack (to be used in an application that uses folder packs) - A `layer` (formerly `architecture`) checker that allows packages to specify their "layer" and ensures they cannot use packages from higher layers ## Installation @@ -63,7 +63,7 @@ public_path: my/custom/path/ ### Defining public constants through sigil > [!WARNING] -> This way of of defining the public API of a package should be considered WIP. It is not supported by all tooling in the RubyAtScale ecosystem, as @alexevanczuk pointed out in a [comment on the PR](https://github.com/rubyatscale/packwerk-extensions/pull/35#discussion_r1334331797): +> This way of defining the public API of a package should be considered WIP. It is not supported by all tooling in the RubyAtScale ecosystem, as @alexevanczuk pointed out in a [comment on the PR](https://github.com/rubyatscale/packwerk-extensions/pull/35#discussion_r1334331797): > > There are a couple of other places that will require changes related to this sigil. Namely, everything that is coupled to the public folder implementation of privacy. > From b308bb0f700323929126a9bb10bb00d4c0ea4796 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 5 Mar 2026 15:19:57 -0800 Subject: [PATCH 3/3] Remove _typos.toml --- _typos.toml | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 _typos.toml diff --git a/_typos.toml b/_typos.toml deleted file mode 100644 index 62b9aa1..0000000 --- a/_typos.toml +++ /dev/null @@ -1,3 +0,0 @@ -[default.extend-words] -# `#pulic_api:` is intentional test data verifying that a misspelled sigil is rejected -pulic = "pulic"